glassfish
  1. glassfish
  2. GLASSFISH-17652

need clear message in console while enabling secure admin with empty domain password.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.2_dev
    • Component/s: admin_gui
    • Labels:
      None
    • Environment:

      GF 3.1.2 nightly dated b09_11_07_2011
      firefox 3.6

      Description

      When Console is accessed from localhost, try to enable secure admin when the domain password is empty, The error thrown in console complains about the keystore not containing the specified aliases, which is confusing and does not provide an informative error message about what is wrong..as in CLI. In CLI the below error is thrown which is informative:

      #asadmin enable-secure-admin
      remote failure: At least one admin user has an empty password, which secure admi
      n does not permit.
      Command enable-secure-admin failed.

      attached the screenshot.

        Issue Links

          Activity

          Hide
          Anissa Lam added a comment -

          This is fixed when fixing GLASSFISH-17654.
          The message now says:

          Secure admin is turned on, empty password is not allowed.

          Show
          Anissa Lam added a comment - This is fixed when fixing GLASSFISH-17654 . The message now says: Secure admin is turned on, empty password is not allowed.
          Hide
          Anissa Lam added a comment -

          I thought this issue was fixed. It seems to appear again, or was never fixed before. Request Srini to take a look.
          I filed GLASSFISH-17907 on this same issue. Will close that as duplicate. I wonder why the CLI gives a different message than what is showed in the console.

          Show
          Anissa Lam added a comment - I thought this issue was fixed. It seems to appear again, or was never fixed before. Request Srini to take a look. I filed GLASSFISH-17907 on this same issue. Will close that as duplicate. I wonder why the CLI gives a different message than what is showed in the console.
          Hide
          srinik76 added a comment -

          Issue 17654 fix is while setting admin password.

          But current issue is during enable secure admin page, when there is failure error is hardcoded in the gui, the fix needs to be propagate the back end error. Will fix this.

          Show
          srinik76 added a comment - Issue 17654 fix is while setting admin password. But current issue is during enable secure admin page, when there is failure error is hardcoded in the gui, the fix needs to be propagate the back end error. Will fix this.
          Hide
          srinik76 added a comment -

          The fix is

          Index: src/main/resources/org/glassfish/common/admingui/Strings.properties
          ===================================================================
          — src/main/resources/org/glassfish/common/admingui/Strings.properties (revision 51338)
          +++ src/main/resources/org/glassfish/common/admingui/Strings.properties (working copy)
          @@ -91,7 +91,6 @@
          security.secureAdmin.adminaliasHelp=The alias that refers to the SSL/TLS certificate on the DAS. This alias is used by the instances to authenticate against the DAS.
          security.secureAdmin.instancealias=Instance Alias:
          security.secureAdmin.instancealiasHelp=The alias that refers to the SSL/TLS certificate on the instances. This alias is used by the DAS to authenticate against the instances.
          -security.secureAdminEnableFailure=Error enabling secure admin, the keystore does not contain the specified aliases
          security.secureLabel=Secure Administration:

          Index: src/main/resources/appServer/securityAdmin.jsf
          ===================================================================
          — src/main/resources/appServer/securityAdmin.jsf (revision 51338)
          +++ src/main/resources/appServer/securityAdmin.jsf (working copy)
          @@ -77,7 +77,7 @@
          <!command
          gf.restRequest(endpoint="#

          {sessionScope.REST_URL}

          /enable-secure-admin", attrs="#

          {pageSession.valueMap}

          ", method="POST", result="#

          {pageSession.resultMap}

          ", throwException="false");
          if ("#

          {pageSession.resultMap.data.exit_code}

          =FAILURE") {

          • prepareAlertMsg(summary="$resource {i18nc.security.secureAdminEnableFailure}

            ", type="error");
            + prepareAlertMsg(summary="#

            {pageSession.resultMap.data.message}

            ", type="error");
            gf.redirect("#

            {facesContext.externalContext.requestContextPath}/common/appServer/securityAdmin.jsf?&alertType=${alertType}&alertSummary=${alertSummary}&alertDetail=${alertDetail}");
            }
            gf.redirect("#{facesContext.externalContext.requestContextPath}

            /common/appServer/restart-2.jsf");

          Show
          srinik76 added a comment - The fix is Index: src/main/resources/org/glassfish/common/admingui/Strings.properties =================================================================== — src/main/resources/org/glassfish/common/admingui/Strings.properties (revision 51338) +++ src/main/resources/org/glassfish/common/admingui/Strings.properties (working copy) @@ -91,7 +91,6 @@ security.secureAdmin.adminaliasHelp=The alias that refers to the SSL/TLS certificate on the DAS. This alias is used by the instances to authenticate against the DAS. security.secureAdmin.instancealias=Instance Alias: security.secureAdmin.instancealiasHelp=The alias that refers to the SSL/TLS certificate on the instances. This alias is used by the DAS to authenticate against the instances. -security.secureAdminEnableFailure=Error enabling secure admin, the keystore does not contain the specified aliases security.secureLabel=Secure Administration: Index: src/main/resources/appServer/securityAdmin.jsf =================================================================== — src/main/resources/appServer/securityAdmin.jsf (revision 51338) +++ src/main/resources/appServer/securityAdmin.jsf (working copy) @@ -77,7 +77,7 @@ <!command gf.restRequest(endpoint="# {sessionScope.REST_URL} /enable-secure-admin", attrs="# {pageSession.valueMap} ", method="POST", result="# {pageSession.resultMap} ", throwException="false"); if ("# {pageSession.resultMap.data.exit_code} =FAILURE") { prepareAlertMsg(summary="$resource {i18nc.security.secureAdminEnableFailure} ", type="error"); + prepareAlertMsg(summary="# {pageSession.resultMap.data.message} ", type="error"); gf.redirect("# {facesContext.externalContext.requestContextPath}/common/appServer/securityAdmin.jsf?&alertType=${alertType}&alertSummary=${alertSummary}&alertDetail=${alertDetail}"); } gf.redirect("#{facesContext.externalContext.requestContextPath} /common/appServer/restart-2.jsf");
          Hide
          srinik76 added a comment -

          Fixed the issue in 3.1.2 branch

          Sending common/src/main/resources/appServer/securityAdmin.jsf
          Sending common/src/main/resources/org/glassfish/common/admingui/Strings.properties
          Transmitting file data ..
          Committed revision 51365.

          Show
          srinik76 added a comment - Fixed the issue in 3.1.2 branch Sending common/src/main/resources/appServer/securityAdmin.jsf Sending common/src/main/resources/org/glassfish/common/admingui/Strings.properties Transmitting file data .. Committed revision 51365.
          Hide
          srinik76 added a comment -

          Checked in the fix in trunk

          Sending common/src/main/resources/appServer/securityAdmin.jsf
          Sending common/src/main/resources/org/glassfish/common/admingui/Strings.properties
          Transmitting file data ..
          Committed revision 51367.

          Show
          srinik76 added a comment - Checked in the fix in trunk Sending common/src/main/resources/appServer/securityAdmin.jsf Sending common/src/main/resources/org/glassfish/common/admingui/Strings.properties Transmitting file data .. Committed revision 51367.
          Hide
          shaline added a comment -

          verified in GF 3.1.2 b18.

          Show
          shaline added a comment - verified in GF 3.1.2 b18.

            People

            • Assignee:
              srinik76
              Reporter:
              shaline
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: