glassfish
  1. glassfish
  2. GLASSFISH-17683

admin-cli.jar classpath references JAR files which are not in nucleus

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0_b73
    • Component/s: command_line_interface
    • Labels:
      None

      Description

      The Class-Path manifest entry for the admin-cli.jar file (nucleus/admin/cli module) references the following JAR files that are not part of nucleus.

      backup.jar
      cli-optional.jar

      Suggested fix:
      backup.jar doesn't contain any local commands, so it can just be removed.

      cli-optional.jar is defined in the appserver. It could be placed into the lib/asadmin directory so that it would be picked up by asadmin. However, it
      has "backup.jar" in its classpath so if cli-optional.jar is moved, then backup.jar won't be found.

      Nucleus needs a better way of allowing the asadmin command to be extended.

      Note: lib/asadmin really should be called lib/nadmin now.

        Activity

        Hide
        Tom Mueller added a comment -

        Fixed on the trunk in revision 59033.

        Show
        Tom Mueller added a comment - Fixed on the trunk in revision 59033.
        Hide
        Tom Mueller added a comment -

        One way to fix this is to make the following changes:

        1. remove cli-optional.jar and backup.jar from the classpath for admin-cli.jar
        2. change the packaging to put cli-optional.jar in lib/asadmin
        3. modify the classpath for cli-optional.jar so that it references backup.jar and all other JAR files using ../modules/jarname.jar

        Show
        Tom Mueller added a comment - One way to fix this is to make the following changes: 1. remove cli-optional.jar and backup.jar from the classpath for admin-cli.jar 2. change the packaging to put cli-optional.jar in lib/asadmin 3. modify the classpath for cli-optional.jar so that it references backup.jar and all other JAR files using ../modules/jarname.jar

          People

          • Assignee:
            Tom Mueller
            Reporter:
            Tom Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: