glassfish
  1. glassfish
  2. GLASSFISH-17683

admin-cli.jar classpath references JAR files which are not in nucleus

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0_b73
    • Component/s: command_line_interface
    • Labels:
      None

      Description

      The Class-Path manifest entry for the admin-cli.jar file (nucleus/admin/cli module) references the following JAR files that are not part of nucleus.

      backup.jar
      cli-optional.jar

      Suggested fix:
      backup.jar doesn't contain any local commands, so it can just be removed.

      cli-optional.jar is defined in the appserver. It could be placed into the lib/asadmin directory so that it would be picked up by asadmin. However, it
      has "backup.jar" in its classpath so if cli-optional.jar is moved, then backup.jar won't be found.

      Nucleus needs a better way of allowing the asadmin command to be extended.

      Note: lib/asadmin really should be called lib/nadmin now.

        Activity

        Tom Mueller created issue -
        Tom Mueller made changes -
        Field Original Value New Value
        Fix Version/s 4.0 [ 10970 ]
        Tom Mueller made changes -
        Description The Class-Path manifest entry for the admin-cli.jar file (nucleus/admin/cli module) references a JAR file called "backup.jar" which isn't part of nucleus.

        Suggested fix:
        Remove this, and modify the asadmin script in the appserver to include backup.jar in the classpath.

        Generally, any nucleus-based product that defines local commands must have a script that run admin-cli.jar that adds the JAR files containing those commands to the classpath.
        The Class-Path manifest entry for the admin-cli.jar file (nucleus/admin/cli module) references a JAR file called "backup.jar" which isn't part of nucleus.

        Suggested fix:
        Remove this, and move the backup.jar file from $INSTALLDIR/modules to $INSTALLDIR/lib/asadmin (which is the asadmin extension directory). If there are classes in backup.jar that are needed in the server, then create a new JAR file that contains only the local backup commands and put that JAR file in the asadmin extension directory.

        Note: lib/asadmin really should be called lib/nadmin now.
        Tom Mueller made changes -
        Summary admin-cli.jar classpath references backup.jar which isn't in nucleus admin-cli.jar classpath references JAR files which are not in nucleus
        Description The Class-Path manifest entry for the admin-cli.jar file (nucleus/admin/cli module) references a JAR file called "backup.jar" which isn't part of nucleus.

        Suggested fix:
        Remove this, and move the backup.jar file from $INSTALLDIR/modules to $INSTALLDIR/lib/asadmin (which is the asadmin extension directory). If there are classes in backup.jar that are needed in the server, then create a new JAR file that contains only the local backup commands and put that JAR file in the asadmin extension directory.

        Note: lib/asadmin really should be called lib/nadmin now.
        The Class-Path manifest entry for the admin-cli.jar file (nucleus/admin/cli module) references the following JAR files that are not part of nucleus.

        backup.jar
        cli-optional.jar

        Suggested fix:
        backup.jar doesn't contain any local commands, so it can just be removed.

        cli-optional.jar is defined in the appserver. It could be placed into the lib/asadmin directory so that it would be picked up by asadmin. However, it
        has "backup.jar" in its classpath so if cli-optional.jar is moved, then backup.jar won't be found.

        Nucleus needs a better way of allowing the asadmin command to be extended.

        Note: lib/asadmin really should be called lib/nadmin now.
        Tom Mueller made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.0_b73 [ 16102 ]
        Fix Version/s 4.0 [ 10970 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Tom Mueller
            Reporter:
            Tom Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: