glassfish
  1. glassfish
  2. GLASSFISH-18043

Delete and uninstall node deletes a CONFIG node

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.2_b14
    • Fix Version/s: 3.1.2_b17
    • Component/s: docs
    • Labels:
      None
    • Environment:

      ogs-3.1.2-b14.zip

      Description

      When clicking on Delete and Uninstall for a CONFIG node, the node is deleted. This should not be allowed, since CONFIG node cannot be uninstalled on a remote machine, thus it is misleading. There is a Delete button, to remove the node from domain.xml.

        Activity

        Hide
        Anissa Lam added a comment -

        The node listing table allows multiple selection. Whenever there is any row selected, both "delete" and "delete and uninstall" button will be enabled, since user may select multiple types of node, including CONFIG, SSH and DCOM, we cannot just enable the Delete button only.
        Just like when there is start and stop button on instances table, both button will be enabled whenever any row is selected, even though the start instance button doesn't apply to instance that already started. It will just be an no-op.

        The page title help hasn't been updated to mention about the new "Delete and Uninstall" button. It should explain what "Delete and Uninstall" means, and mention that if the type is CONFIG, the CONFIG node will be deleted as uninstall will not apply.

        Transfer to 'doc' for adding this info.

        Show
        Anissa Lam added a comment - The node listing table allows multiple selection. Whenever there is any row selected, both "delete" and "delete and uninstall" button will be enabled, since user may select multiple types of node, including CONFIG, SSH and DCOM, we cannot just enable the Delete button only. Just like when there is start and stop button on instances table, both button will be enabled whenever any row is selected, even though the start instance button doesn't apply to instance that already started. It will just be an no-op. The page title help hasn't been updated to mention about the new "Delete and Uninstall" button. It should explain what "Delete and Uninstall" means, and mention that if the type is CONFIG, the CONFIG node will be deleted as uninstall will not apply. Transfer to 'doc' for adding this info.
        Hide
        lidiam added a comment -

        Could we have an additional popup when user selects to "Delete and Uninstall" a CONFIG node? We could notify them that node will not be uninstalled, only deleted in domain.xml and if they click OK, then we proceed. I presume we can detect that user selected a CONFIG node, versus SSH or DCOM, right? The "Delete and Uninstall" should work fine for both SSH and DCOM, only CONFIG is different.

        Show
        lidiam added a comment - Could we have an additional popup when user selects to "Delete and Uninstall" a CONFIG node? We could notify them that node will not be uninstalled, only deleted in domain.xml and if they click OK, then we proceed. I presume we can detect that user selected a CONFIG node, versus SSH or DCOM, right? The "Delete and Uninstall" should work fine for both SSH and DCOM, only CONFIG is different.
        Hide
        Paul Davies added a comment -

        The page title help is fine as is. It doesn't mention any of the other buttons, so I see no need to describe the behavior of Delete and Uninstall in the page title help. This information should be added to the online help for the nodes page.

        Show
        Paul Davies added a comment - The page title help is fine as is. It doesn't mention any of the other buttons, so I see no need to describe the behavior of Delete and Uninstall in the page title help. This information should be added to the online help for the nodes page.
        Hide
        Paul Davies added a comment -

        Fix committed in revision 51972.

        Show
        Paul Davies added a comment - Fix committed in revision 51972.
        Hide
        lidiam added a comment -

        Verified in build ogs-3.1.2-b17.zip

        Show
        lidiam added a comment - Verified in build ogs-3.1.2-b17.zip

          People

          • Assignee:
            Paul Davies
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: