glassfish
  1. glassfish
  2. GLASSFISH-18223

JMS config section in Create cluster page does not hide the custom config section once custom Radio button is selected

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1.2_b17
    • Fix Version/s: 3.1.2_b19
    • Component/s: admin_gui
    • Labels:
      None

      Description

      In the create new cluster page, the custom jms config section is not hidden if you select custom and then change back to use Default MQ cluster config.
      This is very confusing to user, eg,
      1. user 'seems' to be allowed to do an Embedded HA cluster in Local mode which should never happen. (attached invalid-config).
      2. user wants to have shared DB, and filled in all the required info, but then, the cluster is created using Default mode (attached, user-data-lost).

      Once Default mode is selected, the custom jms section needs to be hidden.

        Activity

        Hide
        Jason Lee added a comment - - edited

        Simple fix:

        Index: jms-plugin/src/main/resources/configureJmsCluster.js
        ===================================================================
        --- jms-plugin/src/main/resources/configureJmsCluster.js	(revision 52149)
        +++ jms-plugin/src/main/resources/configureJmsCluster.js	(working copy)
        @@ -64,14 +64,14 @@
         }
             
         function updateJmsPropertySheet(customConfig) {
        +    var jmsTypeSheet = 'propertyForm:jmsTypePropertySheet';
        +    var jmsPropsheet = 'propertyForm:jmsPropertySheet';
             if (!customConfig) {
                 setDisplay(jmsTypeSheet, 'none');
                 setDisplay(jmsPropsheet, 'none');
                 return;
             }
             
        -    var jmsTypeSheet = 'propertyForm:jmsTypePropertySheet';
        -    var jmsPropsheet = 'propertyForm:jmsPropertySheet';
             var baseId = jmsPropsheet + ':configureJmsClusterSection';
             var configStoreType = document.getElementById(baseId+':ConfigStoreTypeProp:configStoreType').value;
             var messageStoreType = document.getElementById(baseId+':MessageStoreTypeProp:messageStoreType').value;
        
        Show
        Jason Lee added a comment - - edited Simple fix: Index: jms-plugin/src/main/resources/configureJmsCluster.js =================================================================== --- jms-plugin/src/main/resources/configureJmsCluster.js (revision 52149) +++ jms-plugin/src/main/resources/configureJmsCluster.js (working copy) @@ -64,14 +64,14 @@ } function updateJmsPropertySheet(customConfig) { + var jmsTypeSheet = 'propertyForm:jmsTypePropertySheet'; + var jmsPropsheet = 'propertyForm:jmsPropertySheet'; if (!customConfig) { setDisplay(jmsTypeSheet, 'none'); setDisplay(jmsPropsheet, 'none'); return ; } - var jmsTypeSheet = 'propertyForm:jmsTypePropertySheet'; - var jmsPropsheet = 'propertyForm:jmsPropertySheet'; var baseId = jmsPropsheet + ':configureJmsClusterSection'; var configStoreType = document.getElementById(baseId+':ConfigStoreTypeProp:configStoreType').value; var messageStoreType = document.getElementById(baseId+':MessageStoreTypeProp:messageStoreType').value;
        Hide
        Jason Lee added a comment -
        • What is the impact on the customer of the bug?

        Data may be lost if the Custom radio button is not selected

        • What is the cost/risk of fixing the bug?

        Minimial. Two line JS change (see diff above)

        • Is there an impact on documentation or message strings?

        No.

        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?

        ClusterTest in Console devtests

        • Which is the targeted build of 3.1.2 for this fix?

        b19

        Show
        Jason Lee added a comment - What is the impact on the customer of the bug? Data may be lost if the Custom radio button is not selected What is the cost/risk of fixing the bug? Minimial. Two line JS change (see diff above) Is there an impact on documentation or message strings? No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? ClusterTest in Console devtests Which is the targeted build of 3.1.2 for this fix? b19
        Hide
        Jason Lee added a comment -

        Fix committed.

        Show
        Jason Lee added a comment - Fix committed.
        Hide
        Jason Lee added a comment -

        Fix revision is r52209.

        Show
        Jason Lee added a comment - Fix revision is r52209.

          People

          • Assignee:
            Jason Lee
            Reporter:
            Anissa Lam
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: