glassfish
  1. glassfish
  2. GLASSFISH-18423

JMS: Inspect JDK 7 getMethods()/getDeclaredMethods() usage

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Works as designed
    • Affects Version/s: 4.0_b25
    • Fix Version/s: 4.0_b25
    • Component/s: jms
    • Labels:
      None

      Description

      Recent JDK 7 releases have altered the order of methods returned by the
      Class.getMethods() and Class.getDeclaredMethods() calls. The order is
      no longer stable and can change from one JVM run to the next.

      This caused a number of sporadic bugs to appear during 3.1.2 development
      when running with JDK 7. Those have been fixed, but further inspection
      of the source has found a number of cases where we use getMethods() and
      getDeclaredMethods().

      Each of these cases should be visually inspected to see if the code is
      making any assumptions on the order of methods returned by get*Methods().
      In particular it should handle the case of multiple methods having the
      same name.

      For more details on what to look for and how to fix it see this document:

      https://wikis.oracle.com/display/GlassFish/Method+Ordering+from+Class.getMethods

      Please inspect the following files for their use of getMethods() /
      getDeclaredMethods() to ensure the code is not making any assumptions
      with respect to the order of methods returned. Create bugs for
      any issues that need to be fixed and link them to this task. Once you
      have completed inspection update this task with status and close it.

      JMS admin
          JMSDestination.java
      

        Activity

        Hide
        David Zhao added a comment -

        In JMSDestination class, it invokes MQ's ResourceAdapter.getJMXConnectorEnv() and ResourceAdapter.getJMXServiceURLList() by feflection. The methods are matched by name during going through all methods returned by ResourceAdapter.class.getMethods(). It would be still safe with JDK7 for the methods are not overloaded in ResourceAdaper - only the expected methods can be matched and it is order irrelevant for now.

        Show
        David Zhao added a comment - In JMSDestination class, it invokes MQ's ResourceAdapter.getJMXConnectorEnv() and ResourceAdapter.getJMXServiceURLList() by feflection. The methods are matched by name during going through all methods returned by ResourceAdapter.class.getMethods(). It would be still safe with JDK7 for the methods are not overloaded in ResourceAdaper - only the expected methods can be matched and it is order irrelevant for now.

          People

          • Assignee:
            David Zhao
            Reporter:
            Joe Di Pol
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: