glassfish
  1. glassfish
  2. GLASSFISH-18429

Error message should be more informative when dealing with stalled objects, during display and update.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0_b78, 4.0
    • Component/s: admin_gui
    • Labels:
      None

      Description

      A customer reported that when trying to update a cluster that has been deleted by another user/browser, the error message is not informative.
      It should provide suggestion on what maybe the cause and provide a suggestion.

      Actually this is a more general issue about how the console provide error message in dealing with stalled elements, and not just for cluster itself. There are 2 use case that the error message can be improved:
      1. Retrieve and display inform for a deleted object, when user click on a stalled tree node.
      2. Update a deleted object. This is the case where user is already in the info page and the object got deleted by other before the Save button is pressed.
      Currently, depending on the object type, the error msg maybe informative, or just suggest checking server.log

      1. screenshot-1.jpg
        238 kB

        Activity

        Hide
        Jeremy_Lv added a comment -

        Thanks to Andriy's suggestion.
        I have revised all of the unfriendly information related to the phenomenon when the cluster is deleted by other customer and unfied the information as picture showed.(including all of the information in configration)

        Show
        Jeremy_Lv added a comment - Thanks to Andriy's suggestion. I have revised all of the unfriendly information related to the phenomenon when the cluster is deleted by other customer and unfied the information as picture showed.(including all of the information in configration)
        Hide
        Jeremy_Lv added a comment -

        I defined new handlers in java file to judge whether the cluster is exists and add the handler in jsf file.
        the code is the most original, I will review the code and do test to provide better one in a few days.

        Show
        Jeremy_Lv added a comment - I defined new handlers in java file to judge whether the cluster is exists and add the handler in jsf file. the code is the most original, I will review the code and do test to provide better one in a few days.
        Hide
        Jeremy_Lv added a comment - - edited

        I have revised the information in cluster and config when deleted by by another user/browser. please check my idea in my attachment file. Thank you.

        Show
        Jeremy_Lv added a comment - - edited I have revised the information in cluster and config when deleted by by another user/browser. please check my idea in my attachment file. Thank you.
        Hide
        Anissa Lam added a comment -

        Thanks for the patch. Will try this out and target this for EE7 MS4 feature freeze date.

        Show
        Anissa Lam added a comment - Thanks for the patch. Will try this out and target this for EE7 MS4 feature freeze date.
        Hide
        Anissa Lam added a comment -

        Evaluated the patch and tried that out. Everything is working as expected.
        The patch has been committed.
        Log Message:
        ------------
        GLASSFISH-18429. To give better error message when a stalled object (configuration, cluster, applications) during display and update.

        Revisions:
        ----------
        58321

        Show
        Anissa Lam added a comment - Evaluated the patch and tried that out. Everything is working as expected. The patch has been committed. Log Message: ------------ GLASSFISH-18429 . To give better error message when a stalled object (configuration, cluster, applications) during display and update. Revisions: ---------- 58321
        Hide
        Anissa Lam added a comment -

        Need to check latest version. Exception is thrown in server.log

        Show
        Anissa Lam added a comment - Need to check latest version. Exception is thrown in server.log
        Hide
        Anissa Lam added a comment -

        The standalone instances and cluster instances was not in the previous fix list. Tests is added to ensure those pages also behave properly.

        Show
        Anissa Lam added a comment - The standalone instances and cluster instances was not in the previous fix list. Tests is added to ensure those pages also behave properly.

          People

          • Assignee:
            Anissa Lam
            Reporter:
            Anissa Lam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: