glassfish
  1. glassfish
  2. GLASSFISH-18584

"description" elements in glassfish-resources.xml not moved to "description" fields in domain.xml

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1.1, 3.1.2
    • Fix Version/s: None
    • Component/s: jca
    • Labels:
      None
    • Environment:

      All

      Description

      For application/module resources files (glassfish-resources.xml) located in either the "META-INF" or "WEB-INF" directories of war, ear, or ejb projects, the DTD at:
      http://glassfish.org/dtds/glassfish-resources_1_5.dtd

      Specifies that the "description" must be a subelement of many of the elements (not an attribute). Specifically the "property" element has a description subelement possible.

      However, the domain.xml file requires that the description be an attribute. This relates to issue GLASSFISH-16630 which is marked as "Won't fix". If we accept that we will not fix this because it causes problems migrating configuration from glassfish 2.x to 3.x, then at least when a project is deployed that has application/module resources, the "description" element should be copied into the "description" attribute.

      One of the great benefits of the new portable JNDI namespaces and application resource files, you can now modify an application/module resource inside the of the Glassfish Admin site without redeploying or packaging the application. However, it gets very confusing when your configuration properties do not have a description associated with them.

        Activity

        Hide
        naman_mehta added a comment -

        Couldn't find option for attachment here so sent as separate email.

        Show
        naman_mehta added a comment - Couldn't find option for attachment here so sent as separate email.
        Hide
        naman_mehta added a comment -

        I tried on the latest workspace and this bug is not reproducible. I can find description is mapped to domain.xml.

        e.g.

        <jdbc-resource pool-name="java:app/TestPool" description="This is the default pool." jndi-name="java:app/jdbc/TestDB"></jdbc-resource>
        <mail-resource host="localhost" description="This is the mail resorce." jndi-name="java:app/mail/csjdb1" from="xtecuan@gmail.com" user="xtecuan"></mail-resource>

        I am attaching the sample .war file with test code. Just try to deploy the same and verify this bug.

        Show
        naman_mehta added a comment - I tried on the latest workspace and this bug is not reproducible. I can find description is mapped to domain.xml. e.g. <jdbc-resource pool-name="java:app/TestPool" description="This is the default pool." jndi-name="java:app/jdbc/TestDB"></jdbc-resource> <mail-resource host="localhost" description="This is the mail resorce." jndi-name="java:app/mail/csjdb1" from="xtecuan@gmail.com" user="xtecuan"></mail-resource> I am attaching the sample .war file with test code. Just try to deploy the same and verify this bug.
        Hide
        Jagadish added a comment -

        Transferring to Naman for investigation.
        It looks like we do seem to handle "description" element of glassfish-resources.xml for jdbc resource but not for other resource types.

        Show
        Jagadish added a comment - Transferring to Naman for investigation. It looks like we do seem to handle "description" element of glassfish-resources.xml for jdbc resource but not for other resource types.
        Hide
        Hong Zhang added a comment -

        The resource team owns glassfish-resources.xml, assign to Jagadish for evaluation

        Show
        Hong Zhang added a comment - The resource team owns glassfish-resources.xml, assign to Jagadish for evaluation
        Hide
        Tom Mueller added a comment -

        This appears to be deployment related, so assigning to the deployment category.

        Show
        Tom Mueller added a comment - This appears to be deployment related, so assigning to the deployment category.

          People

          • Assignee:
            naman_mehta
            Reporter:
            fishcream
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: