Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0_b32_ms1
    • Fix Version/s: 4.0_b80_EE7MS6
    • Component/s: deployment
    • Labels:
      None

      Description

      I don't see any reason for this class to exist. We should defer initialization of sniffers to first application deployment.
      /**

      • Optimization to force the loading of sniffers post deployment.
      • Sniffers can be slow to load and should not delay server statup when
      • no application is deployed.
        *
        */
        @Service
        @PostStartupRunLevel
        public class PostInitializer implements PostConstruct {

      @Inject
      SnifferManager sniffers;

      public void postConstruct()

      { sniffers.getCompositeSniffers(); sniffers.getSniffers(); }

      }

        Activity

        Hide
        Hong Zhang added a comment -

        From the svn log message, Jerome added this for performance improvement? Is this no longer applicable in the current code?

        r32996 | dochez | 2009-10-20 13:06:15 -0400 (Tue, 20 Oct 2009) | 7 lines

        Deployment performance improvement by reducing the sniffer loading time (reducin
        g the imported bundle list)
        moved WebServicesSniffer to a new module to avoid resolving the entire web servi
        ces stack for any deployment
        IT 10256 : hk2 lookup used on invocation path (reviewed by Ken Saks)
        IT 10069 : incremental fix for app name registration in embedded mode
        turned off autodeploy in embedded mode by default.

        Show
        Hong Zhang added a comment - From the svn log message, Jerome added this for performance improvement? Is this no longer applicable in the current code? r32996 | dochez | 2009-10-20 13:06:15 -0400 (Tue, 20 Oct 2009) | 7 lines Deployment performance improvement by reducing the sniffer loading time (reducin g the imported bundle list) moved WebServicesSniffer to a new module to avoid resolving the entire web servi ces stack for any deployment IT 10256 : hk2 lookup used on invocation path (reviewed by Ken Saks) IT 10069 : incremental fix for app name registration in embedded mode turned off autodeploy in embedded mode by default.
        Hide
        Sanjeeb Sahoo added a comment -

        I can't see that improving performance except for first deployment. Instead of loading during first deployment, we are loading early defeating lazy initialization. So, pl. remove it.

        Show
        Sanjeeb Sahoo added a comment - I can't see that improving performance except for first deployment. Instead of loading during first deployment, we are loading early defeating lazy initialization. So, pl. remove it.
        Hide
        Hong Zhang added a comment -

        Remove PostInitializer as sugguested (checked with Scott/Tom also).

        Show
        Hong Zhang added a comment - Remove PostInitializer as sugguested (checked with Scott/Tom also).

          People

          • Assignee:
            Hong Zhang
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: