Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_b37
    • Fix Version/s: None
    • Component/s: web_container
    • Labels:
      None

      Description

      In JSP processing, we spend a large amount of time in JSPWriter.<init> – every time we call that method, the JVM has to allocate and zero-fill an 8K buffer (for a default page size).

      When we turn on defaultBufferingNone, we get a 5-8% improvement in throughput just from not allocating the buffer. There are additional optimizations there if we leave the static byte encoding on – but the bulk of the improvement actually comes from not allocating that byte array.

      We should investigate ways to handle the buffer management to avoid the large zero-fill calls.

        Activity

        Hide
        DongbinNie added a comment - - edited

        The fix has been committed into jsp-impl repository, will integrate it into Glassfish.

        Show
        DongbinNie added a comment - - edited The fix has been committed into jsp-impl repository, will integrate it into Glassfish.
        Hide
        DongbinNie added a comment -

        The fix for jsp-impl is submitted at change 1430 in jsp-impl svn repository, jsp-impl v2.2.6 is integrated into glassfish trunk at change 55761 in glassfish svn repository.

        Show
        DongbinNie added a comment - The fix for jsp-impl is submitted at change 1430 in jsp-impl svn repository, jsp-impl v2.2.6 is integrated into glassfish trunk at change 55761 in glassfish svn repository.

          People

          • Assignee:
            DongbinNie
            Reporter:
            Scott Oaks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: