glassfish
  1. glassfish
  2. GLASSFISH-18825

asadmin deploy must not use the provided file name but the actual file name to guess an application name

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.1_b12
    • Fix Version/s: 4.0_b84_RC1
    • Component/s: deployment
    • Labels:
      None
    • Environment:

      GF3.1.1 Win7 Pro SP1 64Bit JDK1.6.0_26

      Description

      asadmin deploy guesses the application name by simply taking the provided file name (excluding extension). This might work nice on Linux, but is a problem on Windows as that operating system is not case sensitive. This is leading to problems:

      Sample Scenario:

      Physical name of EAR to deploy is "Sample.ear".

      Administrator type "asadmin deploy sample.ear" which IS WORKING, but will guess the application name to be lower case.

      When trying to undeploy, another administrator (not knowing of the typo) want to undeploy. He finds the local file "Sample.ear" so he thinks he must type UPPER case "asadmin undeploy Sample", which is NOT WORKING as GF is case sensitive.

      A solution for this is simple: GF must not guess the application name by using the PROVIDED file name, but instead it must check the File system for the ACTUAL file name instead. So the guessed deploy name will be in the exact same spelling.

        Activity

        Hide
        Jeremy_Lv added a comment -

        mkarg:

        Administrator type "asadmin deploy sample.ear" which IS WORKING, but will guess the application name to be lower case.

        The phenomenon in the latest version of GFV4.0: if physical name of EAR to deploy is "Sample.ear", when you type "asadmin deploy sample.ear", the application will be deployed successfully and named as Sample because the application name is Sample.ear. It will not guess the application name to be lower case.

        When trying to undeploy, another administrator (not knowing of the typo) want to undeploy. He finds the local file "Sample.ear" so he thinks he must type UPPER case "asadmin undeploy Sample", which is NOT WORKING as GF is case sensitive.

        Nowadays, the application can be undeployed as "asadmin undeploy Sample" successfully. However, while another administrator want to undeploy an application . I think he will type as "asadmin list-applications" to list the applications and undeploy the application can be list in the command.

        Thanks.

        Show
        Jeremy_Lv added a comment - mkarg: Administrator type "asadmin deploy sample.ear" which IS WORKING, but will guess the application name to be lower case. The phenomenon in the latest version of GFV4.0: if physical name of EAR to deploy is "Sample.ear", when you type "asadmin deploy sample.ear", the application will be deployed successfully and named as Sample because the application name is Sample.ear. It will not guess the application name to be lower case. When trying to undeploy, another administrator (not knowing of the typo) want to undeploy. He finds the local file "Sample.ear" so he thinks he must type UPPER case "asadmin undeploy Sample", which is NOT WORKING as GF is case sensitive. Nowadays, the application can be undeployed as "asadmin undeploy Sample" successfully. However, while another administrator want to undeploy an application . I think he will type as "asadmin list-applications" to list the applications and undeploy the application can be list in the command. Thanks.
        Hide
        Jeremy_Lv added a comment -

        Nowadays, the feature of deploment is worked as desigend just as mkarg documented.

        Show
        Jeremy_Lv added a comment - Nowadays, the feature of deploment is worked as desigend just as mkarg documented.
        Hide
        Hong Zhang added a comment -

        Thanks Jeremy. Please mark the issue as fixed if things are working as expected now.

        Show
        Hong Zhang added a comment - Thanks Jeremy. Please mark the issue as fixed if things are working as expected now.
        Hide
        Jeremy_Lv added a comment -

        Worked as expected.

        Show
        Jeremy_Lv added a comment - Worked as expected.

          People

          • Assignee:
            Hong Zhang
            Reporter:
            mkarg
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: