glassfish
  1. glassfish
  2. GLASSFISH-18948

The error message isn't friend to user while deploying a rar the size of which is larger than current allocated java heap size

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_b45
    • Fix Version/s: 4.0_b51
    • Component/s: deployment
    • Labels:
      None
    • Environment:

      Windows Xp

      Description

      [Bug Description]
      The error message isn't friend to user while deploying a rar the size of which is larger than current allocated java heap size

      [Operations]
      1、Prepare a rar which contains a large file(this file's size is larger than current allocated java heap size).

      2、While deploying the rar using GUI or command, the following error message is displayed on cmd:

      ""Jave heap size""

      [revise way]
      let user know that the current deployed file is larger than current allocated java heap size.

      [Affected versions ]
      1 4.0_b45
      2 gf's trunk until 2012/07/24

      1. screenshot-1.jpg
        141 kB
      2. screenshot-2.jpg
        146 kB

        Activity

        Hide
        Hong Zhang added a comment -

        Changes look good. Please run the necessary tests before check in. And please check in all the files in the same svn commit as we discussed through the email.

        Show
        Hong Zhang added a comment - Changes look good. Please run the necessary tests before check in. And please check in all the files in the same svn commit as we discussed through the email.
        Hide
        Jeremy_Lv added a comment -

        Dear Hong:
        I have some dev tests questions:
        for example:the modified file are related to the directory like "GF_main\nucleus\common\common-util\src\main\java\com\sun\enterprise\util\io", I can't find any profile files like "common" in the directory of "dev_test_main\devtests".
        shall I run all of the dev tests?

        Show
        Jeremy_Lv added a comment - Dear Hong: I have some dev tests questions: for example:the modified file are related to the directory like "GF_main\nucleus\common\common-util\src\main\java\com\sun\enterprise\util\io", I can't find any profile files like "common" in the directory of "dev_test_main\devtests". shall I run all of the dev tests?
        Hide
        Hong Zhang added a comment -

        No, you don't need to do. As the fix you did was for a negative case and should not be harmful for regular cases, you could just run QuickLook tests.

        Show
        Hong Zhang added a comment - No, you don't need to do. As the fix you did was for a negative case and should not be harmful for regular cases, you could just run QuickLook tests.
        Hide
        Jeremy_Lv added a comment -

        The QL tests results looks OK.

        QL test information:
        Test environment: Linux RHEL5-x32
        Glassfish trunk: until 2012/08/06
        QuickLook tests version: until 2012/08/06
        scenarios: Glassfish Profile
        Passed cases/Tests number: 107/107

        I have uploaded my QL tests results.

        Show
        Jeremy_Lv added a comment - The QL tests results looks OK. QL test information: Test environment: Linux RHEL5-x32 Glassfish trunk: until 2012/08/06 QuickLook tests version: until 2012/08/06 scenarios: Glassfish Profile Passed cases/Tests number: 107/107 I have uploaded my QL tests results.
        Hide
        Jeremy_Lv added a comment -

        Sending main\nucleus\common\common-util\src\main\java\com\sun\enterprise\util\io\FileUtils.java
        Sending main\nucleus\common\common-util\src\main\java\com\sun\enterprise\util\io\LocalStrings.properties
        Transmitting file data ..
        Committed revision 55370.

        Show
        Jeremy_Lv added a comment - Sending main\nucleus\common\common-util\src\main\java\com\sun\enterprise\util\io\FileUtils.java Sending main\nucleus\common\common-util\src\main\java\com\sun\enterprise\util\io\LocalStrings.properties Transmitting file data .. Committed revision 55370.

          People

          • Assignee:
            Hong Zhang
            Reporter:
            Jeremy_Lv
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: