glassfish
  1. glassfish
  2. GLASSFISH-19266

list-applications command interface does not look correct

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 4.0_b60
    • Fix Version/s: future release
    • Component/s: deployment
    • Labels:
      None

      Description

      Syntax of list-applications is shown below:
      NAME
      list-applications - lists deployed applications

      SYNOPSIS
      list-applications [--help]
      [--long=

      {false|true}

      ] [--resources] [--subcomponents]
      [--type type] [target]

      When I look at acceptable values for --type, it looks to me that it is not same as what is allowed in --type argument in deploy command. This needs to be fixed. It should be in sync with deploy command.

      Secondly, should --subcomponents not be renamed to --components? The man page refers to a non-existent command called list-sub-components which I think should be list-components.

        Activity

        Hide
        Hong Zhang added a comment -

        There is a asadmin list-sub-components command (the source code locates at main/appserver/deployment/javaee-core/src/main/java/org/glassfish/javaee/core/deployment). This command was there since very earlier time probably 8.*?

        Yes, it might make sense to synch the --type values with deploy --type, but need to address the backward compatibility issue at the same time (the syntax for the --type was carried over from very eariler releases also)..

        Show
        Hong Zhang added a comment - There is a asadmin list-sub-components command (the source code locates at main/appserver/deployment/javaee-core/src/main/java/org/glassfish/javaee/core/deployment). This command was there since very earlier time probably 8.*? Yes, it might make sense to synch the --type values with deploy --type, but need to address the backward compatibility issue at the same time (the syntax for the --type was carried over from very eariler releases also)..
        Hide
        Sanjeeb Sahoo added a comment -

        The problem is list-applications is a nucleus command where as list-sub-components is an appserver command, so if one is just using nucleus, the man page is referring to a non-existent command.

        Show
        Sanjeeb Sahoo added a comment - The problem is list-applications is a nucleus command where as list-sub-components is an appserver command, so if one is just using nucleus, the man page is referring to a non-existent command.
        Hide
        Hong Zhang added a comment -

        I see. We would need to fix the man page for this.

        Show
        Hong Zhang added a comment - I see. We would need to fix the man page for this.
        Hide
        Hong Zhang added a comment -

        Based on discussions with Sahoo/Tom, we don't plan to do anything for this in this release. For doc part, the GlassFish distribution will include list-sub-components command so the link will still work. For synching the type option part, the semantics of the type option of deploy command and list-applications command are actually different (one is archive type which is one per application, the other is sniffer type which could be one or more per application). We will revisit this issue in later release to see if there is anything we want to do that time.

        Show
        Hong Zhang added a comment - Based on discussions with Sahoo/Tom, we don't plan to do anything for this in this release. For doc part, the GlassFish distribution will include list-sub-components command so the link will still work. For synching the type option part, the semantics of the type option of deploy command and list-applications command are actually different (one is archive type which is one per application, the other is sniffer type which could be one or more per application). We will revisit this issue in later release to see if there is anything we want to do that time.

          People

          • Assignee:
            Hong Zhang
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: