Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: future release
    • Fix Version/s: None
    • Component/s: OSGi-JavaEE
    • Labels:
      None

      Description

      According to sahoo's test requirements , adding fighterfish test cases. In addition,

      1) also needing to add negative test like failing to inject myservice as a regular cdi bean.
      2) test cases must separate from stock quote sample, using common test cases liking foo/bar...

        Activity

        Hide
        TangYong added a comment -

        Because osgi-cdi-api will have some changes which are from Siva's suggestions, fighterfish tests will also make some changes. Waiting for final API Release.

        Show
        TangYong added a comment - Because osgi-cdi-api will have some changes which are from Siva's suggestions, fighterfish tests will also make some changes. Waiting for final API Release.
        Hide
        TangYong added a comment -

        Hi siva,

        I have attached a new test case(GLASSFISH-19215_fighterfishtestcase_multi-interfaces.zip) for testing multi interfaces, and please seeing it.

        Thanks.
        --Tang

        Show
        TangYong added a comment - Hi siva, I have attached a new test case( GLASSFISH-19215 _fighterfishtestcase_multi-interfaces.zip) for testing multi interfaces, and please seeing it. Thanks. --Tang
        Hide
        TangYong added a comment -

        Hi siva,

        Thanks your suggestion very much. I have understood your means and I will add test for multi-interface scene.

        Tang

        Show
        TangYong added a comment - Hi siva, Thanks your suggestion very much. I have understood your means and I will add test for multi-interface scene. Tang
        Hide
        Sivakumar Thyagarajan added a comment -

        The test cases looks good. I will try it out once I have your patch integrated locally into my workspace. The only enhancement I would like to see is that both the tests uses the "contracts" annotations attribute in @OSGiService, but do not use to add any new meaning, and just set the only interface that the Bean is implementing as the "contracts" value. It would be nice if we have another test or just reuse the 2 new test you have added, where the test tries to choose from one interface from a set of interfaces a Bean implements, and then testing to make sure that BarBean is available as an OSGiService only through Bar.class and not through Baz.class

        @Publish(contracts =

        {Bar.class}

        )
        public class BarBean implements Bar, Baz{}

        In the test Servlet:
        @Inject @OSGiService Bar bar; //must succeed
        and
        @Inject @OSGiService Baz baz; //must fail

        Show
        Sivakumar Thyagarajan added a comment - The test cases looks good. I will try it out once I have your patch integrated locally into my workspace. The only enhancement I would like to see is that both the tests uses the "contracts" annotations attribute in @OSGiService, but do not use to add any new meaning, and just set the only interface that the Bean is implementing as the "contracts" value. It would be nice if we have another test or just reuse the 2 new test you have added, where the test tries to choose from one interface from a set of interfaces a Bean implements, and then testing to make sure that BarBean is available as an OSGiService only through Bar.class and not through Baz.class @Publish(contracts = {Bar.class} ) public class BarBean implements Bar, Baz{} In the test Servlet: @Inject @OSGiService Bar bar; //must succeed and @Inject @OSGiService Baz baz; //must fail
        Hide
        TangYong added a comment -

        The attachment(GLASSFISH-19215_fighterfishtestcase_final.zip) is the final fighterfish test cases(Totoally two test cases) , and I have added a negative test case for GLASSFISH-19215.

        Please try the attachment.

        Thanks
        --Tang

        Show
        TangYong added a comment - The attachment( GLASSFISH-19215 _fighterfishtestcase_final.zip) is the final fighterfish test cases(Totoally two test cases) , and I have added a negative test case for GLASSFISH-19215 . Please try the attachment. Thanks --Tang
        Hide
        TangYong added a comment -

        Hi sahoo, siva,

        I have created a fighterfish test case for GLASSFISH-19215 and passed on my env successfully.
        Please use my 20121114's patch and run the attachment(GLASSFISH-19215_fighterfishtestcase_20121114.zip).

        Thanks.
        --Tang

        Show
        TangYong added a comment - Hi sahoo, siva, I have created a fighterfish test case for GLASSFISH-19215 and passed on my env successfully. Please use my 20121114's patch and run the attachment( GLASSFISH-19215 _fighterfishtestcase_20121114.zip). Thanks. --Tang

          People

          • Assignee:
            Sanjeeb Sahoo
            Reporter:
            TangYong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: