Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: jca
    • Labels:
      None

      Activity

      Hide
      naman_mehta added a comment -

      Made all required changes. Review is also done on the same.

      Show
      naman_mehta added a comment - Made all required changes. Review is also done on the same.
      Hide
      naman_mehta added a comment - - edited

      1. Added 'ResourceDescriptor' which extends 'Descriptor' and moved resource specific methods from Descriptor class to ResourceDescriptor.
      2. Removed method like combineMailSessionDescriptors, combineConnectorResourceDefinitionDescriptors etc and converted them to generic method combineResourceDescriptors(JndiNameEnvironment env, JavaEEResourceType javaEEResourceType).
      3. CommonResourceFunctionality renamed to ResourceDescriptorRegistry
      4. Removed separate copy of descriptors in CommonResourceDesc and CommonResourceBundleDesc. Used it from ResourceDescriptorRegistry.
      5. Keep Map<ResourceType, Set<ResourceDescriptor>> in ResourceDescriptorRegistry to removed resource type specific methods.
      6. Introuduced 2 new methods 1) getAllResourceDescriptors() 2) getAllResourceDesctiprots(Class givenClass) in ResourceDescriptorRegistry.
      7. Removed JavaEEResourceType.ALL and replaced code with new methods introuduced in above 4.

      Show
      naman_mehta added a comment - - edited 1. Added 'ResourceDescriptor' which extends 'Descriptor' and moved resource specific methods from Descriptor class to ResourceDescriptor. 2. Removed method like combineMailSessionDescriptors, combineConnectorResourceDefinitionDescriptors etc and converted them to generic method combineResourceDescriptors(JndiNameEnvironment env, JavaEEResourceType javaEEResourceType). 3. CommonResourceFunctionality renamed to ResourceDescriptorRegistry 4. Removed separate copy of descriptors in CommonResourceDesc and CommonResourceBundleDesc. Used it from ResourceDescriptorRegistry. 5. Keep Map<ResourceType, Set<ResourceDescriptor>> in ResourceDescriptorRegistry to removed resource type specific methods. 6. Introuduced 2 new methods 1) getAllResourceDescriptors() 2) getAllResourceDesctiprots(Class givenClass) in ResourceDescriptorRegistry. 7. Removed JavaEEResourceType.ALL and replaced code with new methods introuduced in above 4.

        People

        • Assignee:
          naman_mehta
          Reporter:
          naman_mehta
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: