glassfish
  1. glassfish
  2. GLASSFISH-19480

Ability to mask "confidential" properties of a resource-adapter's artifacts

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0_b72_EE7MS4, 4.0
    • Component/s: admin_gui
    • Labels:
      None

      Description

      Following artifacts of a resource-adapter can have configuration properties that can be marked as "confidential". ie., those properties when shown in console need not be shown as plain text values. (Need a display behavior similar to password fields)

      resource-adapter-config
      connector-connection-pool
      admin-object-resource
      message listener config properties

      Raising this request to see whether GUI can display the "confidential" properties specified in any of the above artifacts of the resource-adapter can be shown as masked fields.

      NOTE :

      1) These configuration properties are exposed to GUI via REST/hidden CLI commands. So, these hidden CLI commands can provide additional information about which config properties are confidential.
      eg: _get-admin-object-config-properties currently returns a Map via a entry by name "adminObjectConfigProps" in extra properties.
      Similarly, one more map/list can be provided by entry of name "confidentialProperties" that can be read by GUI and mask those properties present in "adminObjectConfigProps".

      2) Additionally, if any of these config properties are already using password alias ie., the value starts with "${ALIAS=", there is no need for GUI to mask them.

      3) Probably, these REST calls are currently made only while creating the resources. GUI might have to call these commands while displaying the resources too since the values must be masked.

        Activity

        Hide
        Anissa Lam added a comment -

        Talked to Jagadish, the value will be stored in plain text in domain.xml, just the display is masked.

        I would need an API to get the list of property names thats marked as confidential. Then on the creation or edit screen for those resource/config, these properties will be presented as masked text box.

        Since this is masked, we need 2 text boxes and need to ensure user enters the same for both.

        Show
        Anissa Lam added a comment - Talked to Jagadish, the value will be stored in plain text in domain.xml, just the display is masked. I would need an API to get the list of property names thats marked as confidential. Then on the creation or edit screen for those resource/config, these properties will be presented as masked text box. Since this is masked, we need 2 text boxes and need to ensure user enters the same for both.
        Hide
        Anissa Lam added a comment -

        All the changes in the console pages has been committed to mask the confidential config properties.
        This is done for Connector Connection pool, Admin Object Resource and Resource Adapter config.
        There is a bug in the backend such that the list of confidential properties is not returned during the editing of Resource Adapter Config. GLASSFISH-19534. When that is fixed, the edit of RA config in the console should work correctly.

        Marking as resolved.

        Show
        Anissa Lam added a comment - All the changes in the console pages has been committed to mask the confidential config properties. This is done for Connector Connection pool, Admin Object Resource and Resource Adapter config. There is a bug in the backend such that the list of confidential properties is not returned during the editing of Resource Adapter Config. GLASSFISH-19534 . When that is fixed, the edit of RA config in the console should work correctly. Marking as resolved.

          People

          • Assignee:
            Anissa Lam
            Reporter:
            Jagadish
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: