glassfish
  1. glassfish
  2. GLASSFISH-19494

list-log-attributes does not include "multiLineMode" nor "ODLLogFormatter.excludeFields"

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_b70
    • Fix Version/s: 4.0_b71
    • Component/s: logging
    • Labels:
      None

      Description

      2 issues relating ot the logging attributes.

      #1. The logging attribute
      "com.sun.enterprise.server.logging.GFFileHandler.multiLineMode" is not included in the out-of-box loggings.properties file. As a result,
      %asadmin list-log-attributes
      does not include this attribute and value.

      Need to add this attribute to the loggings.properties file so that list-log-attributes will include it.
      Basically, I need the list-log-attributes to return this attribute and value out-of-box.

      ============
      #2. According to the logging requirement doc, one can set the excludes fields as followed. But running the set-log-attributes command returns error.

      %asadmin set-log-attributes com.sun.enterprise.server.logging.ODLLogFormatter.excludeFields=userid
      remote failure: Invalid logging attribute name found com.sun.enterprise.server.logging.ODLLogFormatter.excludeFields.
      Command set-log-attributes failed.
      

        Issue Links

          Activity

          Hide
          Anissa Lam added a comment -

          I have worked around #1 in the console, so the multi line mode is already available in the logging attribute screen.
          I still think that should be fixed.

          After #2 is fixed, i will add the UI for that.

          Show
          Anissa Lam added a comment - I have worked around #1 in the console, so the multi line mode is already available in the logging attribute screen. I still think that should be fixed. After #2 is fixed, i will add the UI for that.
          Hide
          Anissa Lam added a comment -

          The console screen has added the 'Load Default' button.
          Console allows editing of the "com.sun.enterprise.server.logging.GFFileHandler.multiLineMode" attribute with the work around.
          However, since this is not included in the defaultLoggingProperties list either, this is treated as no default value when user press the Load Default Button.

          Show
          Anissa Lam added a comment - The console screen has added the 'Load Default' button. Console allows editing of the "com.sun.enterprise.server.logging.GFFileHandler.multiLineMode" attribute with the work around. However, since this is not included in the defaultLoggingProperties list either, this is treated as no default value when user press the Load Default Button.
          Hide
          sandeep.shrivastava added a comment -

          Committed revision 58987. Added the properties in the template config file.

          Show
          sandeep.shrivastava added a comment - Committed revision 58987. Added the properties in the template config file.
          Hide
          Anissa Lam added a comment -

          I am reopening the issue.
          I just updated my workspace to the latest version, there is still the following issues.

          According to the logging requirement
          http://aseng-wiki.us.oracle.com/asengwiki/display/GlassFish/Logging+Requirements+One+Pager#LoggingRequirementsOnePager-4.1.6LogFormat

          The attribute name should be "ODLLogFormatter.excludeFields'. I will expect list-log-attributes to return this.
          But list-log-attributes still does not include that.
          Here is the result:

          {{
          ~/Awork/BG/glassfish4/glassfish/bin 4) asadmin list-log-attributes
          com.sun.enterprise.server.logging.GFFileHandler.excludeFields <>
          com.sun.enterprise.server.logging.GFFileHandler.file <$

          {com.sun.aas.instanceRoot}

          /logs/server.log>
          com.sun.enterprise.server.logging.GFFileHandler.flushFrequency <1>
          com.sun.enterprise.server.logging.GFFileHandler.formatter <com.sun.enterprise.server.logging.UniformLogFormatter>
          com.sun.enterprise.server.logging.GFFileHandler.logtoConsole <false>
          com.sun.enterprise.server.logging.GFFileHandler.maxHistoryFiles <0>
          com.sun.enterprise.server.logging.GFFileHandler.multiLineMode <false>
          com.sun.enterprise.server.logging.GFFileHandler.retainErrorsStasticsForHours <0>
          com.sun.enterprise.server.logging.GFFileHandler.rotationLimitInBytes <2000000>
          com.sun.enterprise.server.logging.GFFileHandler.rotationOnDateChange <false>
          com.sun.enterprise.server.logging.GFFileHandler.rotationTimelimitInMinutes <0>
          com.sun.enterprise.server.logging.SyslogHandler.useSystemLogging <false>
          handlerServices <com.sun.enterprise.server.logging.GFFileHandler>
          handlers <java.util.logging.ConsoleHandler>
          java.util.logging.ConsoleHandler.formatter <com.sun.enterprise.server.logging.UniformLogFormatter>
          java.util.logging.FileHandler.count <1>
          java.util.logging.FileHandler.formatter <java.util.logging.XMLFormatter>
          java.util.logging.FileHandler.limit <50000>
          java.util.logging.FileHandler.pattern <%h/java%u.log>
          log4j.logger.org.hibernate.validator.util.Version <warn>
          Command list-log-attributes executed successfully.
          }}

          so, ODLLogFormatter.excludeFields is still missing.

          Also, there is still no way to set that attribute:
          {{
          ~/Awork/BG/glassfish4/glassfish/bin 5) asadmin set-log-attributes com.sun.enterprise.server.logging.ODLLogFormatter.excludeFields=userid
          remote failure: Invalid logging attribute name found com.sun.enterprise.server.logging.ODLLogFormatter.excludeFields.
          Command set-log-attributes failed.

          }}

          Show
          Anissa Lam added a comment - I am reopening the issue. I just updated my workspace to the latest version, there is still the following issues. According to the logging requirement http://aseng-wiki.us.oracle.com/asengwiki/display/GlassFish/Logging+Requirements+One+Pager#LoggingRequirementsOnePager-4.1.6LogFormat The attribute name should be "ODLLogFormatter.excludeFields'. I will expect list-log-attributes to return this. But list-log-attributes still does not include that. Here is the result: {{ ~/Awork/BG/glassfish4/glassfish/bin 4) asadmin list-log-attributes com.sun.enterprise.server.logging.GFFileHandler.excludeFields <> com.sun.enterprise.server.logging.GFFileHandler.file <$ {com.sun.aas.instanceRoot} /logs/server.log> com.sun.enterprise.server.logging.GFFileHandler.flushFrequency <1> com.sun.enterprise.server.logging.GFFileHandler.formatter <com.sun.enterprise.server.logging.UniformLogFormatter> com.sun.enterprise.server.logging.GFFileHandler.logtoConsole <false> com.sun.enterprise.server.logging.GFFileHandler.maxHistoryFiles <0> com.sun.enterprise.server.logging.GFFileHandler.multiLineMode <false> com.sun.enterprise.server.logging.GFFileHandler.retainErrorsStasticsForHours <0> com.sun.enterprise.server.logging.GFFileHandler.rotationLimitInBytes <2000000> com.sun.enterprise.server.logging.GFFileHandler.rotationOnDateChange <false> com.sun.enterprise.server.logging.GFFileHandler.rotationTimelimitInMinutes <0> com.sun.enterprise.server.logging.SyslogHandler.useSystemLogging <false> handlerServices <com.sun.enterprise.server.logging.GFFileHandler> handlers <java.util.logging.ConsoleHandler> java.util.logging.ConsoleHandler.formatter <com.sun.enterprise.server.logging.UniformLogFormatter> java.util.logging.FileHandler.count <1> java.util.logging.FileHandler.formatter <java.util.logging.XMLFormatter> java.util.logging.FileHandler.limit <50000> java.util.logging.FileHandler.pattern <%h/java%u.log> log4j.logger.org.hibernate.validator.util.Version <warn> Command list-log-attributes executed successfully. }} so, ODLLogFormatter.excludeFields is still missing. Also, there is still no way to set that attribute: {{ ~/Awork/BG/glassfish4/glassfish/bin 5) asadmin set-log-attributes com.sun.enterprise.server.logging.ODLLogFormatter.excludeFields=userid remote failure: Invalid logging attribute name found com.sun.enterprise.server.logging.ODLLogFormatter.excludeFields. Command set-log-attributes failed. }}
          Hide
          Anissa Lam added a comment -

          Sandeep mentioned that the attribute should be com.sun.enterprise.server.logging.GFFileHandler.excludeFields.
          Console will be using this attribute name. He can close this bug after updating the one page to correctly reflect the change.

          Show
          Anissa Lam added a comment - Sandeep mentioned that the attribute should be com.sun.enterprise.server.logging.GFFileHandler.excludeFields. Console will be using this attribute name. He can close this bug after updating the one page to correctly reflect the change.
          Hide
          sandeep.shrivastava added a comment -

          The one-pager is now updated to reflect the correct attribute name.

          Show
          sandeep.shrivastava added a comment - The one-pager is now updated to reflect the correct attribute name.

            People

            • Assignee:
              sandeep.shrivastava
              Reporter:
              Anissa Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: