glassfish
  1. glassfish
  2. GLASSFISH-19999

gf-client-module.jar isn't an OSGi module but it is in glassfish/modules

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 4.0_dev
    • Fix Version/s: future release
    • Component/s: standalone_client
    • Labels:
      None

      Description

      Every JAR file in the glassfish/modules directory adds to the overhead of server startup. So JAR files that are not OSGi modules should not be in that directory.

      This issue is for moving gf-client-module.jar out of glassfish/modules, possibly to the glassfish/lib/appclient directory.

      It is unclear how much of a performance gain would result from this. Since this bundle is in the "Installed" state, it isn't actually loaded into the server. So this is a low priority item as far as startup performance time improvement goes.

        Activity

        Hide
        Tim Quinn added a comment -

        The gf-client-module.jar is in fact an OSGi module, but it does not need to be used as such by the server.

        The server does need access to it - it reads a class from it as a resource when an app client is deployed as part of generating a JAR for download to client systems. So moving the gf-client-module.jar to another directory where it will not be visible to the OSGi loading process is certainly feasible.

        Some other parts of the system (the package_appclient utility) will also need to change to adjust to the file's new location.

        All in all we should do this but not for 4.0, given the probably small payoff and numerous places we'd have to touch.

        Show
        Tim Quinn added a comment - The gf-client-module.jar is in fact an OSGi module, but it does not need to be used as such by the server. The server does need access to it - it reads a class from it as a resource when an app client is deployed as part of generating a JAR for download to client systems. So moving the gf-client-module.jar to another directory where it will not be visible to the OSGi loading process is certainly feasible. Some other parts of the system (the package_appclient utility) will also need to change to adjust to the file's new location. All in all we should do this but not for 4.0, given the probably small payoff and numerous places we'd have to touch.

          People

          • Assignee:
            Tim Quinn
            Reporter:
            Tom Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: