glassfish
  1. glassfish
  2. GLASSFISH-20000

admin-cli.jar is activated during devx-web benchmark but doesn't need to be

    Details

      Description

      Every JAR file in the glassfish/modules directory adds to the overhead of server startup. So JAR files that are not OSGi modules should not be in that directory.

      This issue is for moving admin-cli.jar out of glassfish/modules, possibly to the glassfish/lib/client directory.

      It is unclear how much of a performance gain would result from this. This bundle is in the Active state, so there is something in it that is getting used by the server. However, this bundle is supposed to just be used by the nadmin/asadmin CLI.

        Activity

        Hide
        Tom Mueller added a comment - - edited

        Actually, I just tried this change and it does cause admin-cli.jar to be "installed" after a startup (but of course, it doesn't help after a deploy).

        The other reference is from the WebContainer class which injects a CommandRunner but then never uses it.

        Show
        Tom Mueller added a comment - - edited Actually, I just tried this change and it does cause admin-cli.jar to be "installed" after a startup (but of course, it doesn't help after a deploy). The other reference is from the WebContainer class which injects a CommandRunner but then never uses it.
        Hide
        Tom Mueller added a comment -

        Based on the discussion in the comments, I'm repurposing this issue to just be about making the admin-cli.jar module not be activated or resolved (just installed) during the developer scenario benchmark.

        I've updated the synopsis but have left the discussion for history.

        Show
        Tom Mueller added a comment - Based on the discussion in the comments, I'm repurposing this issue to just be about making the admin-cli.jar module not be activated or resolved (just installed) during the developer scenario benchmark. I've updated the synopsis but have left the discussion for history.
        Hide
        Tom Mueller added a comment -

        The change to ConfiguratorImpl is checked into the trunk in revision 60768.

        Show
        Tom Mueller added a comment - The change to ConfiguratorImpl is checked into the trunk in revision 60768.
        Hide
        Tom Mueller added a comment -

        Assigning to Shing Wai to make the WebContainer fix.

        Show
        Tom Mueller added a comment - Assigning to Shing Wai to make the WebContainer fix.
        Hide
        Shing Wai Chan added a comment -

        remove unused codes and change the package protected to private for some member variables

        Sending web-glue/src/main/java/com/sun/enterprise/web/WebContainer.java
        Transmitting file data .
        Committed revision 60775.

        Show
        Shing Wai Chan added a comment - remove unused codes and change the package protected to private for some member variables Sending web-glue/src/main/java/com/sun/enterprise/web/WebContainer.java Transmitting file data . Committed revision 60775.

          People

          • Assignee:
            Shing Wai Chan
            Reporter:
            Tom Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: