glassfish
  1. glassfish
  2. GLASSFISH-20028

4.0 deployment performance - ejb container module get loaded for a pure web application

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0_b81
    • Fix Version/s: 4.0_b88_RC4
    • Component/s: hk2
    • Labels:
      None

      Description

      The ejb-container module get loaded for a simple web app deployment.
      After the intial deployment, the ejb-container module is loaded and in active state.

      152|Active | 1|GlassFish Core EJB container implementation (4.0.0.SNAPSHOT)

      The snippet of stack trace to trigger this module loading during initial deployment:

      org.jvnet.hk2.osgiadapter.OsgiPopulatorPostProcessor$1.loadClass(OsgiPopulatorPostProcessor.java:77)
      org.jvnet.hk2.internal.ServiceLocatorImpl.loadClass(ServiceLocatorImpl.java:1639)
      org.jvnet.hk2.internal.ServiceLocatorImpl.reifyDescriptor(ServiceLocatorImpl.java:362)
      org.jvnet.hk2.internal.ServiceLocatorImpl.narrow(ServiceLocatorImpl.java:1701)
      org.jvnet.hk2.internal.ServiceLocatorImpl.internalGetDescriptor(ServiceLocatorImpl.java:898)
      org.jvnet.hk2.internal.ServiceLocatorImpl.getService(ServiceLocatorImpl.java:570)
      org.jvnet.hk2.internal.IterableProviderImpl.get(IterableProviderImpl.java:87)
      com.sun.enterprise.security.ee.SecurityDeployer$AppDeployEventListener.event(SecurityDeployer.java:149)
      org.glassfish.kernel.event.EventsImpl.send(EventsImpl.java:131)
      org.glassfish.internal.data.ApplicationInfo.load(ApplicationInfo.java:328)
      com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:493)
      com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:219)
      org.glassfish.deployment.admin.DeployCommand.execute(DeployCommand.java:491)

      Based on the stack trace, I am assigning it to HK2 team for initial evaluation.

        Issue Links

          Activity

          Hide
          jwells added a comment -

          This is fixed in the current hk2. But we have not been able to uptake that version into GlassFish because of problems in cloudlogic.

          Show
          jwells added a comment - This is fixed in the current hk2. But we have not been able to uptake that version into GlassFish because of problems in cloudlogic.
          Hide
          Hong Zhang added a comment -

          I updated workspace and got the latest HK2 integration

          r61090 | mtaube | 2013-04-02 05:43:34 -0700 (Tue, 02 Apr 2013) | 1 line
          uptake hk2 2.1.78 after succesful cpas admin devtest run

          and still see similar stack trace triggering EJB container loading for deployment.

          Show
          Hong Zhang added a comment - I updated workspace and got the latest HK2 integration r61090 | mtaube | 2013-04-02 05:43:34 -0700 (Tue, 02 Apr 2013) | 1 line uptake hk2 2.1.78 after succesful cpas admin devtest run and still see similar stack trace triggering EJB container loading for deployment.
          Hide
          jwells added a comment -
          • What is the impact on the customer of the bug?
            There will be increased performance in some boot scenarios

          How likely is it that a customer will see the bug and how serious is the bug?
          They will see better boot performance if they have webapps with no ejbs

          Is it a regression?
          It is a performance regression

          Does it meet other bug fix criteria (security, performance, etc.)?
          It makes the performance of boot better in some scenarios

          What CTS failures are caused by this bug?
          None

          • What is the cost/risk of fixing the bug?
            Low risk

          How risky is the fix? How much work is the fix? Is the fix complicated?
          The fix was not complicated

          • Is there an impact on documentation or message strings?
            No
          • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
            WebApp and EJB
          • Which is the targeted build of 4.0 for this fix?
            I don't know
          • If this an integration of a new version of a component from another project,
            what are the changes that are being brought in? This might be list of
            Jira issues from that project or a list of revision messages.

          http://gf-hudson.us.oracle.com/hudson/job/promote-hk2/166/changes#detail0

          Show
          jwells added a comment - What is the impact on the customer of the bug? There will be increased performance in some boot scenarios How likely is it that a customer will see the bug and how serious is the bug? They will see better boot performance if they have webapps with no ejbs Is it a regression? It is a performance regression Does it meet other bug fix criteria (security, performance, etc.)? It makes the performance of boot better in some scenarios What CTS failures are caused by this bug? None What is the cost/risk of fixing the bug? Low risk How risky is the fix? How much work is the fix? Is the fix complicated? The fix was not complicated Is there an impact on documentation or message strings? No Which tests should QA (re)run to verify the fix did not destabilize GlassFish? WebApp and EJB Which is the targeted build of 4.0 for this fix? I don't know If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. http://gf-hudson.us.oracle.com/hudson/job/promote-hk2/166/changes#detail0
          Hide
          Tom Mueller added a comment -

          Approved for 4.0.

          Show
          Tom Mueller added a comment - Approved for 4.0.
          Hide
          jwells added a comment -

          $ svn --message "GLASSFISH-20028 Fix performance regression" commit
          Sending nucleus/pom.xml
          Transmitting file data .
          Committed revision 61140.

          Show
          jwells added a comment - $ svn --message " GLASSFISH-20028 Fix performance regression" commit Sending nucleus/pom.xml Transmitting file data . Committed revision 61140.

            People

            • Assignee:
              jwells
              Reporter:
              Hong Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: