glassfish
  1. glassfish
  2. GLASSFISH-20102

Samples: Inspect projects with <packaging>pom</packaging> so their <modules> accurately reflects the intent

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0_b87_RC3
    • Component/s: sample_apps
    • Labels:
      None

      Description

      I have discovered one case where the <packaging>pom<packaging> that directs the flow of the build is missing entries in its <modules> section that apparently should be included.

      This one instance is the jsf/pom.xml. I'll work with the engineers who contributed those samples to ensure they are wired up and do not break the build, but this brings to my attention the possibility for other instances of this problem.

      I think a manual inspection is in order.

        Activity

        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        POM review has been completed. I checked in all trivial changes:

        • Fixed all pom.xml files to use consistent EOLs (quite a few contained the mix of Windows and Unix style EOL characters).
        • Removed references to java.net repository definition which is now consolidated in top level pom.xml
        • Removed explicit versions for managed plugin references.
        • Introduced glassfish.version property which can be used to reference GlassFish promoted build artifacts.
        • Removed javaee7/rest/tictactoe sample from the default reactor since it requires manual installation of JavaFX dependency prior to building.

        I also filed following issue to resolve questionable EJB sample gf-client dependency: GLASSFISH-20454.

        Show
        Snjezana Sevo-Zenzerovic added a comment - POM review has been completed. I checked in all trivial changes: Fixed all pom.xml files to use consistent EOLs (quite a few contained the mix of Windows and Unix style EOL characters). Removed references to java.net repository definition which is now consolidated in top level pom.xml Removed explicit versions for managed plugin references. Introduced glassfish.version property which can be used to reference GlassFish promoted build artifacts. Removed javaee7/rest/tictactoe sample from the default reactor since it requires manual installation of JavaFX dependency prior to building. I also filed following issue to resolve questionable EJB sample gf-client dependency: GLASSFISH-20454 .
        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        I am planning to use this bug to cover overall review and sanity check on Java EE 7 samples workspace pom files. This will cover items such as dependency usage, hard-coded plugin and dependency versions and module list check.

        Show
        Snjezana Sevo-Zenzerovic added a comment - I am planning to use this bug to cover overall review and sanity check on Java EE 7 samples workspace pom files. This will cover items such as dependency usage, hard-coded plugin and dependency versions and module list check.
        Hide
        shreedhar_ganapathy added a comment -

        Hi Snjezana, Ed
        Was there any further progress on this task?
        Hopefully this is limited only to the jsf and no other modules.

        Show
        shreedhar_ganapathy added a comment - Hi Snjezana, Ed Was there any further progress on this task? Hopefully this is limited only to the jsf and no other modules.
        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        This is more of a task than a bug, but I'll leave it as is so that it stays on the current dashboard. We do need to review sample application pom files, both for the correct module list and also for dependencies.

        Show
        Snjezana Sevo-Zenzerovic added a comment - This is more of a task than a bug, but I'll leave it as is so that it stays on the current dashboard. We do need to review sample application pom files, both for the correct module list and also for dependencies.

          People

          • Assignee:
            Snjezana Sevo-Zenzerovic
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: