Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0_b82_EE7MS7
    • Fix Version/s: 4.0_b85
    • Component/s: jsf
    • Labels:
      None

      Description

      Bill Shannon's tool showed up some errors in our OSGi metadata in the org.glassfish:javax.faces:2.2.0-m12 jar. These need to be fixed before M13.

      >>>>> On Tue, 26 Mar 2013 11:57:08 -0700 (PDT), Bill Shannon said:

      EB> Hello Bill,
      EB>
      EB> To that end, can you please check:
      EB>
      EB> https://maven.java.net/index.html#nexus-search;gav~org.glassfish~javax.faces~2.2.0-m12~~
      EB>
      EB> and
      EB>
      EB> https://maven.java.net/index.html#nexus-search;gav~javax.faces~javax.faces-api~2.2-m12~~

      B> Here's the errors I get:

      B> API jar file: javax.faces-api.jar
      B> OSGi Bundle-SymbolicName: javax.faces-api
      B> OSGi bundle specversion: 2.1.99.m12
      B> OSGi Bundle-Version: 2.1.99.m12
      B> Maven group ID, artifact ID: javax.faces:javax.faces-api
      B> Maven version: 2.2-m12
      B> Maven API jar file: javax.faces-api-2.2-m12.jar
      B> Jar Extension-Name: javax.faces
      B> jar Specification-Version: 2.1.99.12
      B> jar Implementation-Version: 2.2-m12

      B> Implementation jar file: javax.faces.jar
      B> OSGi Bundle-SymbolicName: org.glassfish.javax.faces
      B> OSGi bundle specversion: 2.1.99.m12
      B> OSGi Bundle-Version: 2.1.99.m12
      B> Maven group ID, artifact ID: org.glassfish:javax.faces
      B> Maven version: 2.2.0-m12
      B> Maven impl jar file: javax.faces-2.2.0-m12.jar
      B> jar Extension-Name: javax.faces
      B> jar Specification-Version: 2.1.99.12
      B> jar Implementation-Version: 2.2.0-m12

      B> Checking API jar file:
      B> https://maven.java.net/content/repositories/public/javax/faces/javax.faces-api/2.2-m12/javax.faces-api-2.2-m12.jar
      B> ERROR: Attribute Bundle-Version is 2.2 but should be 2.1.99.m12
      B> ERROR: Attribute Specification-Version is 2.2 but should be 2.1.99.12
      B> ERROR: Attribute Implementation-Version is 2.2 but should be 2.2-m12

      B> Checking implementation jar file:
      B> https://maven.java.net/content/repositories/public/org/glassfish/javax.faces/2.2.0-m12/javax.faces-2.2.0-m12.jar
      B> ERROR: Attribute Bundle-Version is 2.2.0.m12-SNAPSHOT but should be 2.1.99.m12
      B> ERROR: Attribute Specification-Version is 2.2 but should be 2.1.99.12
      B> ERROR: Attribute Implementation-Version is 2.2.0-m12-SNAPSHOT but should be
      B> 2.2.0-m12
      B> WARNING: jar file includes class in wrong package: com.sun.faces.renderkit

      B> And lots more warnings like that, which you can ignore.
      B> But the errors should be fixed.

        Activity

        Hide
        Ed Burns added a comment -

        Now, looking in the MANIFEST.MF for javax.faces-2.2.0-m12.jar, I don't
        see the string "99" in there at all. Why should the Bundle-Version be
        2.1.99.m12?

        B> ERROR: Attribute Specification-Version is 2.2 but should be 2.1.99.12

        The version of the JSF spec is indeed 2.2, so why should it be
        2.1.99.12?

        B> ERROR: Attribute Implementation-Version is 2.2.0-m12-SNAPSHOT but should be
        B> 2.2.0-m12

        Does this mean that the Implementation-Version should exactly match the
        <version> of the pom associated with this jar artifact?

        B> WARNING: jar file includes class in wrong package: com.sun.faces.renderkit

        I'm not sure how to resolve this one.

        I see that your calendar says you are not available til 4pm today and I
        will be unavailable at that time. Can you please leve me as detailed
        instructions as you can saying how I should fix my jar so that the
        2.2.0-m13, which we plan to generate Monday, will pass muster with your
        tool?

        Show
        Ed Burns added a comment - Now, looking in the MANIFEST.MF for javax.faces-2.2.0-m12.jar, I don't see the string "99" in there at all. Why should the Bundle-Version be 2.1.99.m12? B> ERROR: Attribute Specification-Version is 2.2 but should be 2.1.99.12 The version of the JSF spec is indeed 2.2, so why should it be 2.1.99.12? B> ERROR: Attribute Implementation-Version is 2.2.0-m12-SNAPSHOT but should be B> 2.2.0-m12 Does this mean that the Implementation-Version should exactly match the <version> of the pom associated with this jar artifact? B> WARNING: jar file includes class in wrong package: com.sun.faces.renderkit I'm not sure how to resolve this one. I see that your calendar says you are not available til 4pm today and I will be unavailable at that time. Can you please leve me as detailed instructions as you can saying how I should fix my jar so that the 2.2.0-m13, which we plan to generate Monday, will pass muster with your tool?
        Hide
        Ed Burns added a comment -

        Patch
        Index: jsf-ri/build.xml
        ===================================================================
        — jsf-ri/build.xml (revision 11823)
        +++ jsf-ri/build.xml (working copy)
        @@ -659,32 +659,57 @@

        <target name="jars" depends="compile">

        +<!--
        +
        +https://wikis.oracle.com/display/GlassFish/Maven+Versioning+Rules
        +
        +The Maven and OSGi Packaging and Naming Guidelines state that for
        +non-final artifacts a value "less than" the final version number
        +must be used for all OSGi version numbers. The inputs to this build
        +script take final version numbers. It would be nice if we could
        +derive the "less than" values programmatically.
        +
        +For example, if $

        {impl.version.number} is 2.2.0-m12, the value should be
        +2.1.99.m12. The Maven and OSGi versioning rules say the numeric value
        +should be "less than" the final release version number until the product
        +is actually final. Thus, 2.1.99 is the closest thing 2.2.0 that is
        +still less than 2.2.0. They also say you should not have dashes in the
        +value, hence the "-" gets replaced with ".".
        +
        +Unfortunately, this is difficult to accomplish with ant, so we will hard
        +code the values for now. These values must be updated whenever we release
        +a new version.
        +
        +-->
        +
        <copy file="${basedir}/mojarra-jsf-impl.bnd" tofile="tmp.bnd"/>
        +
        +<!-- start of properties that must be update when incrementing version numbers -->
        +
        +<!-- Spec version is something like 2.2 -->
        +
        <replace file="tmp.bnd"
        token="@spec.version@"
        - value="${spec.version}"/>
        + value="2.1.99.13"/>
        +
        +<!-- osgi.version is based on impl.version.number, which is something like
        + 2.2.0-m12 -->
        +
        <replace file="tmp.bnd"
        + token="@osgi.version@"
        + value="2.1.99.m13"/>
        +
        +<!-- end of properties that must be update when incrementing version numbers -->
        +
        + <replace file="tmp.bnd"
        token="@impl.name@"
        value="${impl.name}"/>
        <replace file="tmp.bnd"
        token="@impl.version@"
        - value="${impl.version}"/>
        + value="${impl.version.number}

        "/>
        <replace file="tmp.bnd"
        token="@full.impl.version@"
        value="$

        {full.impl.version} ${svn.revision.url}"/>
        - <if>
        - <equals arg1="${build.type}" arg2=""/>
        - <then>
        - <replace file="tmp.bnd"
        - token="@osgi.version@"
        - value="${impl.version.number}"/>
        - </then>
        - <else>
        - <replace file="tmp.bnd"
        - token="@osgi.version@"
        - value="${impl.version.number}${build.type}"/>
        - </else>
        - </if>
        <replace file="tmp.bnd"
        token="@extension.name@"
        value="javax.faces"/>
        Index: jsf-api/build.xml
        ===================================================================
        — jsf-api/build.xml (revision 11823)
        +++ jsf-api/build.xml (working copy)
        @@ -629,32 +629,58 @@
        -->
        <target name="jars" depends="build">

        +<!--
        +
        +https://wikis.oracle.com/display/GlassFish/Maven+Versioning+Rules
        +
        +The Maven and OSGi Packaging and Naming Guidelines state that for
        +non-final artifacts a value "less than" the final version number
        +must be used for all OSGi version numbers. The inputs to this build
        +script take final version numbers. It would be nice if we could
        +derive the "less than" values programmatically.
        +
        +For example, if ${impl.version.number} is 2.2.0-m12, the value should be
        +2.1.99.m12. The Maven and OSGi versioning rules say the numeric value
        +should be "less than" the final release version number until the product
        +is actually final. Thus, 2.1.99 is the closest thing 2.2.0 that is
        +still less than 2.2.0. They also say you should not have dashes in the
        +value, hence the "-" gets replaced with ".".
        +
        +Unfortunately, this is difficult to accomplish with ant, so we will hard
        +code the values for now. These values must be updated whenever we release
        +a new version.
        +
        +-->
        +
        <copy file="${basedir}/mojarra-jsf-api.bnd" tofile="tmp.bnd"/>
        +
        +<!-- start of properties that must be update when incrementing version numbers -->
        +
        +<!-- Spec version is something like 2.2 -->
        +
        <replace file="tmp.bnd"
        token="@spec.version@"
        - value="${spec.version}"/>
        + value="2.1.99.13"/>
        +
        +<!-- osgi.version is based on impl.version.number, which is something like
        + 2.2.0-m12 -->
        +
        <replace file="tmp.bnd"
        + token="@osgi.version@"
        + value="2.1.99.m13"/>
        +
        + <replace file="tmp.bnd"
        + token="@impl.version@"
        + value="2.2-m13"/>
        +
        +<!-- end of properties that must be update when incrementing version numbers -->
        +
        + <replace file="tmp.bnd"
        token="@impl.name@"
        value="${impl.name}"/>
        <replace file="tmp.bnd"
        - token="@impl.version@"
        - value="${impl.version}"/>
        - <replace file="tmp.bnd"
        token="@full.impl.version@"
        value="${full.impl.version}

        "/>

        • <if>
        • <equals arg1="$ {build.type}" arg2=""/>
          - <then>
          - <replace file="tmp.bnd"
          - token="@osgi.version@"
          - value="${impl.version.number}"/>
          - </then>
          - <else>
          - <replace file="tmp.bnd"
          - token="@osgi.version@"
          - value="${impl.version.number}${build.type}

          "/>

        • </else>
        • </if>
          <replace file="tmp.bnd"
          token="@extension.name@"
          value="javax.faces"/>
          @@ -922,7 +948,7 @@

        <target name="mvn.deploy.release.local" depends="strip.api.jar">
        <mvn.deploy.release.local type="api"

        • version="$ {spec.version}"/>
          + version="${spec.version}

          -m13"/>
          </target>

        <target name="strip.api.jar"

        Show
        Ed Burns added a comment - Patch Index: jsf-ri/build.xml =================================================================== — jsf-ri/build.xml (revision 11823) +++ jsf-ri/build.xml (working copy) @@ -659,32 +659,57 @@ <target name="jars" depends="compile"> +<!-- + + https://wikis.oracle.com/display/GlassFish/Maven+Versioning+Rules + +The Maven and OSGi Packaging and Naming Guidelines state that for +non-final artifacts a value "less than" the final version number +must be used for all OSGi version numbers. The inputs to this build +script take final version numbers. It would be nice if we could +derive the "less than" values programmatically. + +For example, if $ {impl.version.number} is 2.2.0-m12, the value should be +2.1.99.m12. The Maven and OSGi versioning rules say the numeric value +should be "less than" the final release version number until the product +is actually final. Thus, 2.1.99 is the closest thing 2.2.0 that is +still less than 2.2.0. They also say you should not have dashes in the +value, hence the "-" gets replaced with ".". + +Unfortunately, this is difficult to accomplish with ant, so we will hard +code the values for now. These values must be updated whenever we release +a new version. + +--> + <copy file="${basedir}/mojarra-jsf-impl.bnd" tofile="tmp.bnd"/> + +<!-- start of properties that must be update when incrementing version numbers --> + +<!-- Spec version is something like 2.2 --> + <replace file="tmp.bnd" token="@spec.version@" - value="${spec.version}"/> + value="2.1.99.13"/> + +<!-- osgi.version is based on impl.version.number, which is something like + 2.2.0-m12 --> + <replace file="tmp.bnd" + token="@osgi.version@" + value="2.1.99.m13"/> + +<!-- end of properties that must be update when incrementing version numbers --> + + <replace file="tmp.bnd" token="@impl.name@" value="${impl.name}"/> <replace file="tmp.bnd" token="@impl.version@" - value="${impl.version}"/> + value="${impl.version.number} "/> <replace file="tmp.bnd" token="@full.impl.version@" value="$ {full.impl.version} ${svn.revision.url}"/> - <if> - <equals arg1="${build.type}" arg2=""/> - <then> - <replace file="tmp.bnd" - token="@osgi.version@" - value="${impl.version.number}"/> - </then> - <else> - <replace file="tmp.bnd" - token="@osgi.version@" - value="${impl.version.number}${build.type}"/> - </else> - </if> <replace file="tmp.bnd" token="@extension.name@" value="javax.faces"/> Index: jsf-api/build.xml =================================================================== — jsf-api/build.xml (revision 11823) +++ jsf-api/build.xml (working copy) @@ -629,32 +629,58 @@ --> <target name="jars" depends="build"> +<!-- + + https://wikis.oracle.com/display/GlassFish/Maven+Versioning+Rules + +The Maven and OSGi Packaging and Naming Guidelines state that for +non-final artifacts a value "less than" the final version number +must be used for all OSGi version numbers. The inputs to this build +script take final version numbers. It would be nice if we could +derive the "less than" values programmatically. + +For example, if ${impl.version.number} is 2.2.0-m12, the value should be +2.1.99.m12. The Maven and OSGi versioning rules say the numeric value +should be "less than" the final release version number until the product +is actually final. Thus, 2.1.99 is the closest thing 2.2.0 that is +still less than 2.2.0. They also say you should not have dashes in the +value, hence the "-" gets replaced with ".". + +Unfortunately, this is difficult to accomplish with ant, so we will hard +code the values for now. These values must be updated whenever we release +a new version. + +--> + <copy file="${basedir}/mojarra-jsf-api.bnd" tofile="tmp.bnd"/> + +<!-- start of properties that must be update when incrementing version numbers --> + +<!-- Spec version is something like 2.2 --> + <replace file="tmp.bnd" token="@spec.version@" - value="${spec.version}"/> + value="2.1.99.13"/> + +<!-- osgi.version is based on impl.version.number, which is something like + 2.2.0-m12 --> + <replace file="tmp.bnd" + token="@osgi.version@" + value="2.1.99.m13"/> + + <replace file="tmp.bnd" + token="@impl.version@" + value="2.2-m13"/> + +<!-- end of properties that must be update when incrementing version numbers --> + + <replace file="tmp.bnd" token="@impl.name@" value="${impl.name}"/> <replace file="tmp.bnd" - token="@impl.version@" - value="${impl.version}"/> - <replace file="tmp.bnd" token="@full.impl.version@" value="${full.impl.version} "/> <if> <equals arg1="$ {build.type}" arg2=""/> - <then> - <replace file="tmp.bnd" - token="@osgi.version@" - value="${impl.version.number}"/> - </then> - <else> - <replace file="tmp.bnd" - token="@osgi.version@" - value="${impl.version.number}${build.type} "/> </else> </if> <replace file="tmp.bnd" token="@extension.name@" value="javax.faces"/> @@ -922,7 +948,7 @@ <target name="mvn.deploy.release.local" depends="strip.api.jar"> <mvn.deploy.release.local type="api" version="$ {spec.version}"/> + version="${spec.version} -m13"/> </target> <target name="strip.api.jar"
        Hide
        Ed Burns added a comment -

        Found this problem when deploying a simple war after using the Mojarra with this fix applied:

        Caused by: org.osgi.framework.BundleException: Unresolved constraint in bundle org.glassfish.main.web.weld-integration [274]: Unable to resolve 274.0: missing requirement [274.0] osgi.wiring.package; (&(osgi.wiring.package=com.sun.faces.spi)(version>=2.2.0)(!(version>=3.0.0)))
        at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:3974)
        at org.apache.felix.framework.Felix.startBundle(Felix.java:2037)
        at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:955)
        at org.jvnet.hk2.osgiadapter.OSGiModuleImpl.start(OSGiModuleImpl.java:210)
        ... 66 more
        MultiException stack 2 of 2

        Because of this problem, I am going to revert r11824 and re-open the bug.

        Show
        Ed Burns added a comment - Found this problem when deploying a simple war after using the Mojarra with this fix applied: Caused by: org.osgi.framework.BundleException: Unresolved constraint in bundle org.glassfish.main.web.weld-integration [274] : Unable to resolve 274.0: missing requirement [274.0] osgi.wiring.package; (&(osgi.wiring.package=com.sun.faces.spi)(version>=2.2.0)(!(version>=3.0.0))) at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:3974) at org.apache.felix.framework.Felix.startBundle(Felix.java:2037) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:955) at org.jvnet.hk2.osgiadapter.OSGiModuleImpl.start(OSGiModuleImpl.java:210) ... 66 more MultiException stack 2 of 2 Because of this problem, I am going to revert r11824 and re-open the bug.
        Hide
        Ed Burns added a comment -
        • What is the impact on the customer of the bug?

        Milestone builds are using final version numbers for OSGi meta-information.

        How likely is it that a customer will see the bug and how serious is the bug?
        Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)?
        What CTS failures are caused by this bug?

        If the customer uses a milestone build it will not have an "older" OSGi meta-information set than the final release build.

        • What is the cost/risk of fixing the bug?

        Low because an incorrectly implemented fix will cause apps to fail to deploy.

        How risky is the fix? How much work is the fix? Is the fix complicated?

        The only complexity of this fix is how it relates to the jsf integration module in GlassFish.

        • Is there an impact on documentation or message strings?

        No.

        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?

        None, Mojarra dev tests will cover it.

        • Which is the targeted build of 4.0 for this fix?

        TBD

        Show
        Ed Burns added a comment - What is the impact on the customer of the bug? Milestone builds are using final version numbers for OSGi meta-information. How likely is it that a customer will see the bug and how serious is the bug? Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)? What CTS failures are caused by this bug? If the customer uses a milestone build it will not have an "older" OSGi meta-information set than the final release build. What is the cost/risk of fixing the bug? Low because an incorrectly implemented fix will cause apps to fail to deploy. How risky is the fix? How much work is the fix? Is the fix complicated? The only complexity of this fix is how it relates to the jsf integration module in GlassFish. Is there an impact on documentation or message strings? No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? None, Mojarra dev tests will cover it. Which is the targeted build of 4.0 for this fix? TBD
        Hide
        Tom Mueller added a comment -

        Approved for 4.0.

        Show
        Tom Mueller added a comment - Approved for 4.0.
        Show
        Ed Burns added a comment - Safe to integrate when < http://hudson-sca.us.oracle.com/view/MOJARRA_ALL/job/MOJARRA_2_2_0_GLASSFISH_3_1_2_2_NO_CLUSTER/19/ > and < http://slc03qna.us.oracle.com:7070/hudson/view/Mojarra%202.2/job/2_2_x-test-glassfish-4_0/40/ > are clean.
        Hide
        Ed Burns added a comment -

        Both of those jobs are clean.

        This is fixed and will be included in Mojarra 2.2.0-m14, due by COB Monday 15 April 2013.

        Show
        Ed Burns added a comment - Both of those jobs are clean. This is fixed and will be included in Mojarra 2.2.0-m14, due by COB Monday 15 April 2013.
        Hide
        Ed Burns added a comment -

        Integrated with 2.2.0-m14, committed as

        r61425 | rogerk | 2013-04-15 09:06:17 -0400 (Mon, 15 Apr 2013) | 213 lines

        http://java.net/jira/browse/GLASSFISH-20292 http://java.net/jira/browse/GLASSFISH-20232 http://java.net/jira/browse/GLASSFISH-20123 http://java.net/jira/browse/GLASSFISH-20122

        http://java.net/jira/browse/GLASSFISH-20292

        M jsf-ri/conf/share/facelets_jsf_core.taglib.xml

        f:attributes - MISSING WHOLE TAG
        f:passThroughAttribute - MISSING WHOLE TAG
        f:passThroughAttributes - MISSING WHOLE TAG
        f:ajax - MISSING delay, resetValues ATTR
        f:view - MISSING transient, contracts ATTR
        f:selectItems - MISSING rendered, actionListener ATTR

        M jsf-ri/conf/share/html_basic.taglib.xml

        h:inputFile - MISSING WHOLE TAG
        h:button - MISSING role, disableClientWindow ATTR
        h:commandButton - MISSING role ATTR
        h:commandLink - MISSING role ATTR
        h:link - MISSING role, disableClientWindow ATTR
        h:doctype - MISSING WHOLE TAG

        Sending jsf-ri/conf/share/facelets_jsf_core.taglib.xml
        Sending jsf-ri/conf/share/html_basic.taglib.xml
        Transmitting file data ..
        Committed revision 11873.

        http://java.net/jira/browse/GLASSFISH-20232

        M jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java

        • Instead of polling the config manager to see if there are flows, use
          the addFlow() method.
          Sending jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java
          Transmitting file data .
          Committed revision 11852.

        http://java.net/jira/browse/GLASSFISH-20123

        M jsf-ri/build-pre-maven-rename.xml
        M jsf-api/build-pre-maven-rename.xml

        • Apply the changes from "svn diff -r 11859:11860" to the
          "pre-maven-rename" variant.

        Sending jsf-api/build-pre-maven-rename.xml
        Sending jsf-ri/build-pre-maven-rename.xml
        Transmitting file data ..
        Committed revision 11872.

        M jsf-ri/build.xml

        • change mvn.deploy.release.local and mvn.deploy.release to depend on m14.

        M jsf-ri/mojarra-jsf-impl.bnd

        • change OSGi Implementation-Version to be 2.2.0-m14.
        • change OSGi Bundle-Version to be 2.1.99.b14

        M common/ant/maven.xml

        • If the build.type is not -SNAPSHOT, activate the check-module property
          when invoking maven. This causes the

        <groupId>org.glassfish.build</groupId>
        <artifactId>spec-version-maven-plugin</artifactId>
        <version>1.1</version>

        plugin to be invoked, as shown in this output

        [INFO] Building jar: /Users/ejburns/Documents/JavaEE/workareas/mojarra-MOJARRA_2_2_0_GLASSFISH_4_0/jsf-api/build/mvn/target/javax.faces-api-2.2-m14.jar
        [INFO] [build-helper:attach-artifact

        {execution: attach-artifacts}

        ]
        [INFO] [spec-version:check-module

        {execution: default}

        ]
        [INFO] [source:jar-no-fork

        {execution: attach-sources}

        ]
        [INFO] Building jar: /Users/ejburns/Documents/JavaEE/workareas/mojarra-MOJARRA_2_2_0_GLASSFISH_4_0/jsf-ri/build/mvn/target/javax.faces-2.2.0-m14.jar
        [INFO] [build-helper:attach-artifact

        {execution: attach-artifacts}

        ]
        [INFO] [spec-version:check-module

        {execution: default}

        ]
        [INFO] [source:jar-no-fork

        {execution: attach-sources}

        ]

        M common/ant/template/jsf-impl-pom-template.xml
        M common/ant/template/jsf-api-pom-template.xml

        • invoke the spec-version-maven-plugin if the check-module property is
          activated.

        M jsf-api/mojarra-jsf-api.bnd

        • Change OSGi Implementation-Version to be 2.2.0-m14
        • Change OSGi Bundle-Version to be 2.1.99.b14

        M jsf-api/build.xml

        • change mvn.deploy.release.local and mvn.deploy.release to depend on m14
          Sending common/ant/maven.xml
          Sending common/ant/template/jsf-api-pom-template.xml
          Sending common/ant/template/jsf-impl-pom-template.xml
          Sending jsf-api/build.xml
          Sending jsf-api/mojarra-jsf-api.bnd
          Sending jsf-ri/build.xml
          Sending jsf-ri/mojarra-jsf-impl.bnd
          Transmitting file data .......
          Committed revision 11860.

        To preverve backward compatibility with the now deprecated Facelets
        ResourceResolver, ensure it gets consulted on ViewHandler0.viewExists().

        r=mriem

        SECTION: Modified Files
        ----------------------------
        M jsf-ri/src/main/java/com/sun/faces/facelets/impl/DefaultFaceletFactory.java
        M jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java
        M jsf-demo/sandbox/flow_and_contract/app/pom.xml
        M jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/OutcomeTargetRenderer.java

        • Unrelated change. Don't renderd the flow attributes on outcomeTarget
          components unless there are flows.

        D jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts
        D jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts/leftNav
        D jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts/topNav

        • Unrelated change, the focus of this demo changed so that now the flows
          and contracts are bundled in jars, not with the app.

        A test/agnostic/vdl/facelets/resource-resolver
        A test/agnostic/vdl/facelets/resource-resolver/nbactions.xml
        A test/agnostic/vdl/facelets/resource-resolver/src
        A test/agnostic/vdl/facelets/resource-resolver/src/test
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver
        A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/VerifyResourceResolverUsageIT.java
        A test/agnostic/vdl/facelets/resource-resolver/src/main
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver
        A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/TestResolver.java
        A test/agnostic/vdl/facelets/resource-resolver/src/main/resources
        A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp
        A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF
        A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/web.xml
        A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/glassfish-web.xml
        A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/a.xhtml
        A test/agnostic/vdl/facelets/resource-resolver/pom.xml

        • New test
          Sending jsf-demo/sandbox/flow_and_contract/app/pom.xml
          Deleting jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts
          Sending jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java
          Sending jsf-ri/src/main/java/com/sun/faces/facelets/impl/DefaultFaceletFactory.java
          Sending jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/OutcomeTargetRenderer.java
          Adding test/agnostic/vdl/facelets/resource-resolver
          Adding test/agnostic/vdl/facelets/resource-resolver/nbactions.xml
          Adding test/agnostic/vdl/facelets/resource-resolver/pom.xml
          Adding test/agnostic/vdl/facelets/resource-resolver/src
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/TestResolver.java
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/resources
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/glassfish-web.xml
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/web.xml
          Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/a.xhtml
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver
          Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/VerifyResourceResolverUsageIT.java
          Transmitting file data ...........
          Committed revision 11850.

        SECTION: Modified Files
        ----------------------------
        M jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java

        • Found by jsp-flash systest-per-webapp.

        Sending jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java
        Transmitting file data .
        Committed revision 11851.

        Show
        Ed Burns added a comment - Integrated with 2.2.0-m14, committed as r61425 | rogerk | 2013-04-15 09:06:17 -0400 (Mon, 15 Apr 2013) | 213 lines http://java.net/jira/browse/GLASSFISH-20292 http://java.net/jira/browse/GLASSFISH-20232 http://java.net/jira/browse/GLASSFISH-20123 http://java.net/jira/browse/GLASSFISH-20122 http://java.net/jira/browse/GLASSFISH-20292 M jsf-ri/conf/share/facelets_jsf_core.taglib.xml f:attributes - MISSING WHOLE TAG f:passThroughAttribute - MISSING WHOLE TAG f:passThroughAttributes - MISSING WHOLE TAG f:ajax - MISSING delay, resetValues ATTR f:view - MISSING transient, contracts ATTR f:selectItems - MISSING rendered, actionListener ATTR M jsf-ri/conf/share/html_basic.taglib.xml h:inputFile - MISSING WHOLE TAG h:button - MISSING role, disableClientWindow ATTR h:commandButton - MISSING role ATTR h:commandLink - MISSING role ATTR h:link - MISSING role, disableClientWindow ATTR h:doctype - MISSING WHOLE TAG Sending jsf-ri/conf/share/facelets_jsf_core.taglib.xml Sending jsf-ri/conf/share/html_basic.taglib.xml Transmitting file data .. Committed revision 11873. http://java.net/jira/browse/GLASSFISH-20232 M jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java Instead of polling the config manager to see if there are flows, use the addFlow() method. Sending jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java Transmitting file data . Committed revision 11852. http://java.net/jira/browse/GLASSFISH-20123 M jsf-ri/build-pre-maven-rename.xml M jsf-api/build-pre-maven-rename.xml Apply the changes from "svn diff -r 11859:11860" to the "pre-maven-rename" variant. Sending jsf-api/build-pre-maven-rename.xml Sending jsf-ri/build-pre-maven-rename.xml Transmitting file data .. Committed revision 11872. M jsf-ri/build.xml change mvn.deploy.release.local and mvn.deploy.release to depend on m14. M jsf-ri/mojarra-jsf-impl.bnd change OSGi Implementation-Version to be 2.2.0-m14. change OSGi Bundle-Version to be 2.1.99.b14 M common/ant/maven.xml If the build.type is not -SNAPSHOT, activate the check-module property when invoking maven. This causes the <groupId>org.glassfish.build</groupId> <artifactId>spec-version-maven-plugin</artifactId> <version>1.1</version> plugin to be invoked, as shown in this output [INFO] Building jar: /Users/ejburns/Documents/JavaEE/workareas/mojarra-MOJARRA_2_2_0_GLASSFISH_4_0/jsf-api/build/mvn/target/javax.faces-api-2.2-m14.jar [INFO] [build-helper:attach-artifact {execution: attach-artifacts} ] [INFO] [spec-version:check-module {execution: default} ] [INFO] [source:jar-no-fork {execution: attach-sources} ] [INFO] Building jar: /Users/ejburns/Documents/JavaEE/workareas/mojarra-MOJARRA_2_2_0_GLASSFISH_4_0/jsf-ri/build/mvn/target/javax.faces-2.2.0-m14.jar [INFO] [build-helper:attach-artifact {execution: attach-artifacts} ] [INFO] [spec-version:check-module {execution: default} ] [INFO] [source:jar-no-fork {execution: attach-sources} ] M common/ant/template/jsf-impl-pom-template.xml M common/ant/template/jsf-api-pom-template.xml invoke the spec-version-maven-plugin if the check-module property is activated. M jsf-api/mojarra-jsf-api.bnd Change OSGi Implementation-Version to be 2.2.0-m14 Change OSGi Bundle-Version to be 2.1.99.b14 M jsf-api/build.xml change mvn.deploy.release.local and mvn.deploy.release to depend on m14 Sending common/ant/maven.xml Sending common/ant/template/jsf-api-pom-template.xml Sending common/ant/template/jsf-impl-pom-template.xml Sending jsf-api/build.xml Sending jsf-api/mojarra-jsf-api.bnd Sending jsf-ri/build.xml Sending jsf-ri/mojarra-jsf-impl.bnd Transmitting file data ....... Committed revision 11860. To preverve backward compatibility with the now deprecated Facelets ResourceResolver, ensure it gets consulted on ViewHandler0.viewExists(). r=mriem SECTION: Modified Files ---------------------------- M jsf-ri/src/main/java/com/sun/faces/facelets/impl/DefaultFaceletFactory.java M jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java M jsf-demo/sandbox/flow_and_contract/app/pom.xml M jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/OutcomeTargetRenderer.java Unrelated change. Don't renderd the flow attributes on outcomeTarget components unless there are flows. D jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts D jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts/leftNav D jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts/topNav Unrelated change, the focus of this demo changed so that now the flows and contracts are bundled in jars, not with the app. A test/agnostic/vdl/facelets/resource-resolver A test/agnostic/vdl/facelets/resource-resolver/nbactions.xml A test/agnostic/vdl/facelets/resource-resolver/src A test/agnostic/vdl/facelets/resource-resolver/src/test A test/agnostic/vdl/facelets/resource-resolver/src/test/java A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver A test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/VerifyResourceResolverUsageIT.java A test/agnostic/vdl/facelets/resource-resolver/src/main A test/agnostic/vdl/facelets/resource-resolver/src/main/java A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver A test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/TestResolver.java A test/agnostic/vdl/facelets/resource-resolver/src/main/resources A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/web.xml A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/glassfish-web.xml A test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/a.xhtml A test/agnostic/vdl/facelets/resource-resolver/pom.xml New test Sending jsf-demo/sandbox/flow_and_contract/app/pom.xml Deleting jsf-demo/sandbox/flow_and_contract/app/src/main/webapp/contracts Sending jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java Sending jsf-ri/src/main/java/com/sun/faces/facelets/impl/DefaultFaceletFactory.java Sending jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/OutcomeTargetRenderer.java Adding test/agnostic/vdl/facelets/resource-resolver Adding test/agnostic/vdl/facelets/resource-resolver/nbactions.xml Adding test/agnostic/vdl/facelets/resource-resolver/pom.xml Adding test/agnostic/vdl/facelets/resource-resolver/src Adding test/agnostic/vdl/facelets/resource-resolver/src/main Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver Adding test/agnostic/vdl/facelets/resource-resolver/src/main/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/TestResolver.java Adding test/agnostic/vdl/facelets/resource-resolver/src/main/resources Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/glassfish-web.xml Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/WEB-INF/web.xml Adding test/agnostic/vdl/facelets/resource-resolver/src/main/webapp/a.xhtml Adding test/agnostic/vdl/facelets/resource-resolver/src/test Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver Adding test/agnostic/vdl/facelets/resource-resolver/src/test/java/com/sun/faces/test/agnostic/vdl/facelets/resource_resolver/VerifyResourceResolverUsageIT.java Transmitting file data ........... Committed revision 11850. SECTION: Modified Files ---------------------------- M jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java Found by jsp-flash systest-per-webapp. Sending jsf-ri/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java Transmitting file data . Committed revision 11851.

          People

          • Assignee:
            Ed Burns
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 11 hours, 11 minutes
              11h 11m