glassfish
  1. glassfish
  2. GLASSFISH-20160

asadmin get command referring to a default configured item fails

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0_dev
    • Fix Version/s: 4.0_dev
    • Component/s: admin
    • Labels:
      None

      Description

      In 3.1.2.2 one can do this:

      adc6140581:3.1.2.2 $ ./glassfish3/glassfish/bin/asadmin get server-config.security-service.audit-module.default.*
      server-config.security-service.audit-module.default.classname=com.sun.enterprise.security.Audit
      server-config.security-service.audit-module.default.name=default
      server-config.security-service.audit-module.default.property.auditOn=false
      Command get executed successfully.

      In 4.0 this happens:

      adc6140581:publish $ ./glassfish4/glassfish/bin/asadmin get server-config.security-service.audit-module.default.*
      remote failure: Dotted name path server-config.security-service.audit-module.default.* not found.
      Command get failed.

      This is causing SQE tests to fail, as reported in GLASSFISH-19943

      I am assigning this to Masoud, at least to start with.

        Issue Links

          Activity

          Hide
          Tim Quinn added a comment -

          Linking this to the issue SQE filed.

          Show
          Tim Quinn added a comment - Linking this to the issue SQE filed.
          Hide
          Tim Quinn added a comment - - edited

          I meant to point out that in 3.1.2.2 the domain.xml contains an explicit audit-module element - and subelements - for the "default" module.

          In 4.0 the SecurityServices config bean provides a default value for getAuditModules() (which returns "default").

          Does this need to be addressed by restoring some previously-removed elements?

          Show
          Tim Quinn added a comment - - edited I meant to point out that in 3.1.2.2 the domain.xml contains an explicit audit-module element - and subelements - for the "default" module. In 4.0 the SecurityServices config bean provides a default value for getAuditModules() (which returns "default"). Does this need to be addressed by restoring some previously-removed elements?
          Hide
          Tim Quinn added a comment -

          Back in 2011 quite a bit of work was done to separate the appserver configuration and classes from the nucleus configuration and classes.

          The audit-module section of domain.xml referred to a class that was moving from nucleus into the new appserver server/core-ee module, so the nucleus domain.xml template was revised to remove the audit-module section but that section was never placed into the new appserver-specific domain.xml template. The absence of that section in the appserver domain.xml is at least part of the reason the SQE tests mentioned in GLASSFISH-19943 are failing.

          • What is the impact on the customer of the bug?
            This is a regression.
          • What is the cost/risk of fixing the bug?
            Small - restoring the inadvertently-dropped <audit-module> element to the appserver domain.xml template.
          • Is there an impact on documentation or message strings?
            No
          • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
            The test mentioned in GLASSFISH-19943
          • Which is the targeted build of 4.0 for this fix?
            b84
          • If this an integration of a new version of a component from another project,
            what are the changes that are being brought in? This might be list of
            Jira issues from that project or a list of revision messages.
            N/A
          Show
          Tim Quinn added a comment - Back in 2011 quite a bit of work was done to separate the appserver configuration and classes from the nucleus configuration and classes. The audit-module section of domain.xml referred to a class that was moving from nucleus into the new appserver server/core-ee module, so the nucleus domain.xml template was revised to remove the audit-module section but that section was never placed into the new appserver-specific domain.xml template. The absence of that section in the appserver domain.xml is at least part of the reason the SQE tests mentioned in GLASSFISH-19943 are failing. What is the impact on the customer of the bug? This is a regression. What is the cost/risk of fixing the bug? Small - restoring the inadvertently-dropped <audit-module> element to the appserver domain.xml template. Is there an impact on documentation or message strings? No Which tests should QA (re)run to verify the fix did not destabilize GlassFish? The test mentioned in GLASSFISH-19943 Which is the targeted build of 4.0 for this fix? b84 If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. N/A
          Hide
          Tim Quinn added a comment -

          Fix checked in.

          Project: glassfish
          Repository: svn
          Revision: 61179
          Author: tjquinn
          Date: 2013-04-04 21:27:30 UTC
          Link:

          Log Message:
          ------------
          GLASSFISH-20160 - asadmin get command referring to a default configured item fails

          Back in 2011 quite a bit of work was done to separate the appserver configuration and classes from the nucleus configuration and classes.

          The audit-module section of domain.xml referred to a class that was moving from nucleus into the new appserver server/core-ee module, so the nucleus domain.xml template was revised (one of the changes in svn rev 48070) to remove the audit-module section but that section was never placed into the new appserver-specific domain.xml template which was created a short while later.

          This change restores the audit-module section in the server-config and default-config sections.

          Reviewed by Tom Mueller
          Approved by Michael
          Passed QL tests

          Revisions:
          ----------
          61179

          Modified Paths:
          ---------------
          trunk/main/appserver/admin/template/src/main/resources/config/domain.xml

          Show
          Tim Quinn added a comment - Fix checked in. Project: glassfish Repository: svn Revision: 61179 Author: tjquinn Date: 2013-04-04 21:27:30 UTC Link: Log Message: ------------ GLASSFISH-20160 - asadmin get command referring to a default configured item fails Back in 2011 quite a bit of work was done to separate the appserver configuration and classes from the nucleus configuration and classes. The audit-module section of domain.xml referred to a class that was moving from nucleus into the new appserver server/core-ee module, so the nucleus domain.xml template was revised (one of the changes in svn rev 48070) to remove the audit-module section but that section was never placed into the new appserver-specific domain.xml template which was created a short while later. This change restores the audit-module section in the server-config and default-config sections. Reviewed by Tom Mueller Approved by Michael Passed QL tests Revisions: ---------- 61179 Modified Paths: --------------- trunk/main/appserver/admin/template/src/main/resources/config/domain.xml
          Hide
          Tim Quinn added a comment -

          The earlier fix to this issue, which added back a removed section of XML, introduced an error in the upgrade logic which is heavily dependent on the order of data in the domain.xml template.

          The original change should stand but we now need to correct the upgrade logic to work with the corrected domain.xml template.

          • What is the impact on the customer of the bug?
            The upgrade (via start-domain --upgrade) does not work and leaves a CPU-bound DAS running.
          • What is the cost/risk of fixing the bug?
            The repair to the upgrade logic is relatively minor, updating it so it conforms to what is in the revised template domain.xml.
          • Is there an impact on documentation or message strings?
            No.
          • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
            The GlassFish admin devtests which include the upgrade test.
          • Which is the targeted build of 4.0 for this fix?
            b84
          • If this an integration of a new version of a component from another project,
            what are the changes that are being brought in? This might be list of
            Jira issues from that project or a list of revision messages.
            N/A
          Show
          Tim Quinn added a comment - The earlier fix to this issue, which added back a removed section of XML, introduced an error in the upgrade logic which is heavily dependent on the order of data in the domain.xml template. The original change should stand but we now need to correct the upgrade logic to work with the corrected domain.xml template. What is the impact on the customer of the bug? The upgrade (via start-domain --upgrade) does not work and leaves a CPU-bound DAS running. What is the cost/risk of fixing the bug? The repair to the upgrade logic is relatively minor, updating it so it conforms to what is in the revised template domain.xml. Is there an impact on documentation or message strings? No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? The GlassFish admin devtests which include the upgrade test. Which is the targeted build of 4.0 for this fix? b84 If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. N/A
          Hide
          Tim Quinn added a comment -

          Fix checked in:

          Project: glassfish
          Repository: svn
          Revision: 61214
          Author: tjquinn
          Date: 2013-04-05 23:16:32 UTC
          Link:

          Log Message:
          ------------
          Additional fix for GLASSFISH-20160 - asadmin get command referring to a default configured item fails

          An earlier check-in restored a long-ago removed bit of the domain.xml template for the default security audit-module, but that confused the upgrade logic that had been changed when the audit-module had been removed earlier.

          This change fixes the upgrade problem.

          Approved by Tom
          Reviewed by Tom
          Passed QL, the upgrade GlassFish admin devtest

          Revisions:
          ----------
          61214

          Modified Paths:
          ---------------
          trunk/main/nucleus/admin/config-api/src/main/java/org/glassfish/config/support/DefaultConfigUpgrade.java

          Show
          Tim Quinn added a comment - Fix checked in: Project: glassfish Repository: svn Revision: 61214 Author: tjquinn Date: 2013-04-05 23:16:32 UTC Link: Log Message: ------------ Additional fix for GLASSFISH-20160 - asadmin get command referring to a default configured item fails An earlier check-in restored a long-ago removed bit of the domain.xml template for the default security audit-module, but that confused the upgrade logic that had been changed when the audit-module had been removed earlier. This change fixes the upgrade problem. Approved by Tom Reviewed by Tom Passed QL, the upgrade GlassFish admin devtest Revisions: ---------- 61214 Modified Paths: --------------- trunk/main/nucleus/admin/config-api/src/main/java/org/glassfish/config/support/DefaultConfigUpgrade.java

            People

            • Assignee:
              Tim Quinn
              Reporter:
              Tim Quinn
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: