glassfish
  1. glassfish
  2. GLASSFISH-20179

4.0 SDK: EJB samples need to be removed from Web Distribution

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_b82_EE7MS7
    • Fix Version/s: 4.0_b83
    • Component/s: sample_apps
    • Labels:
      None
    • Environment:

      java_ee_sdk-7-web-b81-unix.sh or java_ee_sdk-7-web-b82-jdk7-linux.sh, OEL6 system, JDK1.7.0_13.

      Description

      This issue is being reported to track the packaging changes required for the Web Distribution. Below is the context of the task.

      This has been postponed to b83 since I run into build issues related to sample separation and wanted to avoid further promotion delays.
      Thanks,
      Snjezana

      ----- Original Message -----
      From: alex.pineda@oracle.com
      To: snjezana.sevozenzerovic@oracle.com
      Cc: bhavya.h.s@oracle.com, Tom.Mueller@oracle.com, qiang.l.liu@oracle.com
      Sent: Thursday, April 4, 2013 8:28:29 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
      Subject: Re: EJB samples in the SDK Web distribution

      Snjezana,

      I'm looking at the GF4.0 build 82 Web Distribution and I still see the 4
      EJB samples. My understanding based on the email below was that only 1
      sample would be included in the distribution (ejb32-war). If
      so, when do you plan resolve this.

      Please advise.

      Alex Pineda

      On 3/26/2013 6:05 PM, Snjezana Sevo-Zenzerovic wrote:
      > Alex,
      >
      > I actually asked about this couple of days ago and this is the answer I got back from Qiang who ported EJB samples:
      >
      >> By now, there have been 4 EJB samples available which are automatic-timer, ejb32-war, ejb-embedded and hello-stateless-ejb.
      >> I would suggest only ejb32-war be packaged in Web Profile. Because automatic-timer contans remote interface and persistence timer, hello-stateless-ejb contains remote >interface and ejb-embedded is not a feature of EJB Lite 3.2.
      > I am planning to implement this content split in SDK b82.
      >
      > Thanks,
      >
      > Snjezana
      >
      > ----- Original Message -----
      > From: alex.pineda@oracle.com
      > To: marina.vatkina@oracle.com
      > Cc: Tom.Mueller@oracle.com, snjezana.sevozenzerovic@oracle.com, padma.rengavittal@oracle.com, bhavya.h.s@oracle.com
      > Sent: Wednesday, March 27, 2013 2:01:19 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
      > Subject: EJB samples in the SDK Web distribution
      >
      > Marina,
      >
      > We just received promoted SDK build 81 and I noticed that the Web/Full
      > distributions have the same EJB samples. I wonder if they should be as
      > I believe the Web distribution has limited support for EJB (that was the
      > case in GF 3.x). I just tried the sample hello-stateless-ejb-bean, and
      > it worked in the Full distribution, but I saw errors in the Web
      > distribution while trying to deploy. This was a very quick test, thus,
      > the reason for the question, and before I spend more time trying to file
      > bugs. I thought I should ask. Can you please tell us if all the EJB
      > samples belong in both distributions.
      >
      > Thanks in advance.
      >
      > Alex Pineda

        Activity

        Hide
        Alex Pineda added a comment -

        I believe one more sample needs to be removed. It's from CDI executor sample. When I try to deploy it, it complains that is unable to deploy the EJB module. The error is:

        remote failure: Error occurred during deployment: Exception while preparing the app : Unable to load the EJB module. DeploymentContext does not contain any EJB. Check the archive to ensure correct packaging for $Test/workspace/glassfish4/glassfish/domains/cargo-domain/applications/executor.

        Sadly, this sample had another failure during deployment (reported in 19900) but the fix was only verified on the Full GF distribution and the Web distribution.

        My hope is that when the re-packing is done, this sample (samples/cdi/executor) can be removed as well.

        Show
        Alex Pineda added a comment - I believe one more sample needs to be removed. It's from CDI executor sample. When I try to deploy it, it complains that is unable to deploy the EJB module. The error is: remote failure: Error occurred during deployment: Exception while preparing the app : Unable to load the EJB module. DeploymentContext does not contain any EJB. Check the archive to ensure correct packaging for $Test/workspace/glassfish4/glassfish/domains/cargo-domain/applications/executor. Sadly, this sample had another failure during deployment (reported in 19900) but the fix was only verified on the Full GF distribution and the Web distribution. My hope is that when the re-packing is done, this sample (samples/cdi/executor) can be removed as well.
        Hide
        Alex Pineda added a comment -

        Type error in the last comment. The fix (19900) was not verified on the Web distribution.

        Show
        Alex Pineda added a comment - Type error in the last comment. The fix (19900) was not verified on the Web distribution.
        Hide
        Snjezana Sevo-Zenzerovic added a comment -
        • What is the impact on the customer of the bug?

        Java EE 7 Sample packages shipped with SDK distribution should ship only those samples that are able to run on integrated GlassFish (i.e. Web Profile vs. full platform). The impact is that we otherwise ship several full platform technology samples which will not deploy or run on Web Profile SDK installation. Significant usability impact.

        • What is the cost/risk of fixing the bug?

        Low risk, no runtime impact. SDK build will filter out full platform specific samples and package them into dedicated IPS package installed only in full platform distribution. Sample pom files also need to be adjusted to avoid referencing non-existing sample modules for web profile subset.

        • Is there an impact on documentation or message strings?

        No impact.

        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?

        Verify the fix as part of regular samples testing.

        • Which is the targeted build of 4.0 for this fix?

        SDK b83.

        • If this an integration of a new version of a component from another project,
          what are the changes that are being brought in? This might be list of
          Jira issues from that project or a list of revision messages.

        N/A

        Show
        Snjezana Sevo-Zenzerovic added a comment - What is the impact on the customer of the bug? Java EE 7 Sample packages shipped with SDK distribution should ship only those samples that are able to run on integrated GlassFish (i.e. Web Profile vs. full platform). The impact is that we otherwise ship several full platform technology samples which will not deploy or run on Web Profile SDK installation. Significant usability impact. What is the cost/risk of fixing the bug? Low risk, no runtime impact. SDK build will filter out full platform specific samples and package them into dedicated IPS package installed only in full platform distribution. Sample pom files also need to be adjusted to avoid referencing non-existing sample modules for web profile subset. Is there an impact on documentation or message strings? No impact. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? Verify the fix as part of regular samples testing. Which is the targeted build of 4.0 for this fix? SDK b83. If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. N/A

          People

          • Assignee:
            Snjezana Sevo-Zenzerovic
            Reporter:
            Alex Pineda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: