Issue Details (XML | Word | Printable)

Key: GLASSFISH-20196
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Mahesh Kannan
Reporter: arunkumar_s
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
glassfish

BATCH CLI: asadmin set-batch-runtime-configuration able to set wrong values to the lookup name

Created: 05/Apr/13 01:19 PM   Updated: 09/Apr/13 04:21 PM   Resolved: 09/Apr/13 04:21 PM
Component/s: batch
Affects Version/s: 4.0_b83
Fix Version/s: 4.0_b84_RC1

Time Tracking:
Not Specified

Issue Links:
Dependency
 

Tags:
Participants: arunkumar_s and Mahesh Kannan


 Description  « Hide

Tested with latest nightly

Able to set Datasource look up values to Executor lookup service and vice versa.

bin/asadmin set-batch-runtime-configuration -d concurrent/__defaultManagedExecutorService
Command set-batch-runtime-configuration executed successfully.

bin/asadmin set-batch-runtime-configuration -x jdbc/__TimerPool
Command set-batch-runtime-configuration executed successfully.

Issue --> Set batch runtime configuration should allow to set only possible values



Mahesh Kannan added a comment - 07/Apr/13 02:49 PM

This has been fixed as part of svn commit 61217. However, I am not closing this until GlassFish-20210 is fixed.

svn commit -m "Fix for 20194, and partial fix for 20196. QL Passed"
Sending batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/SetBatchRuntimeConfiguration.java
Sending batch/glassfish-batch-connector/src/main/java/org/glassfish/batch/spi/impl/BatchRuntimeHelper.java
Adding batch/glassfish-batch-connector/src/main/java/org/glassfish/batch/spi/impl/GlassFishBatchValidationException.java
Transmitting file data ...
Committed revision 61217.


Mahesh Kannan added a comment - 09/Apr/13 04:21 PM

Resolved. Not set-batch-runtime-configuration command does validation.
svn commit -m "Fix for 20121, 20196. QL Passed"
Sending batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchRuntimeConfiguration.java
Sending batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/SetBatchRuntimeConfiguration.java
Sending batch/glassfish-batch-connector/pom.xml
Sending batch/glassfish-batch-connector/src/main/java/org/glassfish/batch/spi/impl/BatchRuntimeConfiguration.java
Sending batch/glassfish-batch-connector/src/main/java/org/glassfish/batch/spi/impl/BatchRuntimeHelper.java
Adding batch/glassfish-batch-connector/src/main/java/org/glassfish/batch/spi/impl/ManagedServiceActivator.java
Transmitting file data ......
Committed revision 61253.