Issue Details (XML | Word | Printable)

Key: GLASSFISH-20205
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Tom Mueller
Reporter: Tom Mueller
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
glassfish

concurrent config created at startup rather than when used

Created: 05/Apr/13 07:16 PM   Updated: 05/Apr/13 09:04 PM   Resolved: 05/Apr/13 09:04 PM
Component/s: concurrency
Affects Version/s: 4.0_b83
Fix Version/s: 4.0_b84_RC1

Time Tracking:
Not Specified

Tags: devx_web 4_0-approved
Participants: Tom Mueller


 Description  « Hide

The concurrent/concurrent-connector module defines several startup services for initializing the config beans for the module. These config beans are not actually needed until they are used, so if the initialization can be deferred, this could improve startup time.

Proposed fix: remove the @RunLevel annotations from the activator services and instead add an @Inject for those services in the Default*Service classes and in the list commands. With this change, we see about a 2-4% reduction in the developer scenario performance regression.



Tom Mueller added a comment - 05/Apr/13 07:19 PM
  • What is the impact on the customer of the bug?

How likely is it that a customer will see the bug and how serious is the bug?
Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)?
What CTS failures are caused by this bug?

This is a performance regression from 3.1.2.

  • What is the cost/risk of fixing the bug?

How risky is the fix? How much work is the fix? Is the fix complicated?

Low risk.

  • Is there an impact on documentation or message strings?
    No.
  • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
    Concurrent related tests.
  • Which is the targeted build of 4.0 for this fix?
    b84.
  • If this an integration of a new version of a component from another project,
    what are the changes that are being brought in? This might be list of
    Jira issues from that project or a list of revision messages.
    N/A

Tom Mueller added a comment - 05/Apr/13 07:19 PM

Approved for 4.0


Tom Mueller added a comment - 05/Apr/13 09:04 PM

Fixed on the trunk in revision 61212.