glassfish
  1. glassfish
  2. GLASSFISH-20264

BATCH CLI: asadmin list-batch-job-executions with some string operands shows no error message

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0_b83
    • Fix Version/s: 4.0_b86_RC2
    • Component/s: batch
    • Labels:
      None

      Description

      Tested with latest build

      asadmin list-batch-job-executions p

      For input string: "p"
      Command list-batch-job-executions executed successfully.

      Expected: Command should fail, says no instance id p found.

      Same case for list-batch-job-steps

        Activity

        Hide
        Mahesh Kannan added a comment -
        • What is the impact on the customer of the bug?
          Without this fix the command will report success despite being pass an invalid parameter
        • What is the cost/risk of fixing the bug?
          Very low. Just a few lines.
        • Is there an impact on documentation or message strings?
          No
        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
          All batch tests. Although I have run batch devtests and QL.
        • Which is the targeted build of 4.0 for this fix?
          The fix is ready, Most likely in RC2.
        • If this an integration of a new version of a component from another project,
          what are the changes that are being brought in? This might be list of
          Jira issues from that project or a list of revision messages.
          N/A
        Show
        Mahesh Kannan added a comment - What is the impact on the customer of the bug? Without this fix the command will report success despite being pass an invalid parameter What is the cost/risk of fixing the bug? Very low. Just a few lines. Is there an impact on documentation or message strings? No Which tests should QA (re)run to verify the fix did not destabilize GlassFish? All batch tests. Although I have run batch devtests and QL. Which is the targeted build of 4.0 for this fix? The fix is ready, Most likely in RC2. If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. N/A
        Hide
        Mahesh Kannan added a comment -

        I changed the data type to Long which means this command takes only an int or long as parameter. Any other input will be flagged as an error by CLI framework

        svn commit -m "Integrate b26 jars. Fix for 20335, 20264. QL and batch devtests passed. Approved by Tom"
        Sending appserver/batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchJobExecutions.java
        Sending appserver/batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchJobExecutionsProxy.java
        Sending appserver/batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchJobStepsProxy.java
        Sending appserver/pom.xml
        Transmitting file data ....
        Committed revision 61563.

        Show
        Mahesh Kannan added a comment - I changed the data type to Long which means this command takes only an int or long as parameter. Any other input will be flagged as an error by CLI framework svn commit -m "Integrate b26 jars. Fix for 20335, 20264. QL and batch devtests passed. Approved by Tom" Sending appserver/batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchJobExecutions.java Sending appserver/batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchJobExecutionsProxy.java Sending appserver/batch/glassfish-batch-commands/src/main/java/org/glassfish/batch/ListBatchJobStepsProxy.java Sending appserver/pom.xml Transmitting file data .... Committed revision 61563.

          People

          • Assignee:
            Mahesh Kannan
            Reporter:
            arunkumar_s
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: