glassfish
  1. glassfish
  2. GLASSFISH-20340

[regression] Make HK2 cache io buffer size is not configurable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_b84_RC1
    • Fix Version/s: 4.0_b87_RC3
    • Component/s: hk2
    • Labels:
      None

      Description

      It used to be configurable earlier, but during hk2 2.x, it has been changed to become a fixed value. Fix it so that perf team can use it to tune the system.

        Activity

        Hide
        mtaube added a comment -

        What is the impact on the customer of the bug?

        They will see a performance improvement during startup when io buffer size is optimized for the machine running glassfish

        What is the cost/risk of fixing the bug?

        This particular change is not risky, will only take effect if a property is specified in osgi.properties

        Is there an impact on documentation or message strings?

        No

        Which tests should QA (re)run to verify the fix did not destabilize GlassFish?

        quicklook

        Which is the targeted build of 4.0 for this fix?

        b88

        If this an integration of a new version of a component from another project,
        what are the changes that are being brought in? This might be list of
        Jira issues from that project or a list of revision messages.

        n/a

        Show
        mtaube added a comment - What is the impact on the customer of the bug? They will see a performance improvement during startup when io buffer size is optimized for the machine running glassfish What is the cost/risk of fixing the bug? This particular change is not risky, will only take effect if a property is specified in osgi.properties Is there an impact on documentation or message strings? No Which tests should QA (re)run to verify the fix did not destabilize GlassFish? quicklook Which is the targeted build of 4.0 for this fix? b88 If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. n/a
        Hide
        Tom Mueller added a comment -

        I hesitate in approving this in that I don't completely agree that this should even be tunable (or should have ever been tunable). More knobs are not necessarily better, and there isn't any proof that different values are needed for different systems. And even if different values were beneficial, is there actually going to be documentation on how users could actually tune this value or is there a performance tuner that sets the value. IMHO, it would be better to just determine a single value that is reasonable for the systems that we target and put that value in the code.

        Approved for 4.0.

        Show
        Tom Mueller added a comment - I hesitate in approving this in that I don't completely agree that this should even be tunable (or should have ever been tunable). More knobs are not necessarily better, and there isn't any proof that different values are needed for different systems. And even if different values were beneficial, is there actually going to be documentation on how users could actually tune this value or is there a performance tuner that sets the value. IMHO, it would be better to just determine a single value that is reasonable for the systems that we target and put that value in the code. Approved for 4.0.

          People

          • Assignee:
            mtaube
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: