glassfish
  1. glassfish
  2. GLASSFISH-20389

endpointDeactivation not called for during MDB undeployment for MDB's with no resource-adapter-mid specified

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_dev
    • Fix Version/s: 4.0_dev
    • Component/s: jca
    • Labels:
      None

      Description

      While trying to verify another issue(GLASSFISH-20296), it was found that ResourceAdapter.endpointDeactivation was not called for MDBs that do not specify the resource-adapter-mid in their glassfish-ejb-jar.xml.

      To reproduce:

        Activity

        Hide
        Jagadish added a comment -
        • What is the impact on the customer of the bug?
          Customer's implementation of EndpointDeactivation in their RAR implementation will not get called
          if <resource-adapter-mid> is not specified in the ejb descriptor.
        • How likely is it that a customer will see the bug and how serious is the bug?
          This issue will be seen in inbound resource-adapters, <resource-adapter-mid> is not
          specified in the ejb descriptor.
        • Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)?
          What CTS failures are caused by this bug?
          No CTS failures. This seems to be a bug that existed ever since the "default" RA detection
          mechanism was introduced (Probably, GlassFish 3.0)
        • What is the cost/risk of fixing the bug?
          Fix is simple, use the same logic to determine the "matching" RA during endpoint activation
          that is used today for endpoint deactivation also.
        • How risky is the fix? How much work is the fix? Is the fix complicated?
          Fix is simple, refactored the RA selection algorithm so that its used during endpoint
          deactivation also.
        • Is there an impact on documentation or message strings?
          No.
        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
          I shall make sure that no regressions in connector SQE tests happen before checking in.
          [QL, connector-dev, jdbc-dev, jms-dev, connector-standalone-cts (Web, Classic), resources-admin-cli are all passing.]
        • Which is the targeted build of 4.0 for this fix?
          Build-86
        • If this an integration of a new version of a component from another project,
          what are the changes that are being brought in? This might be list of
          Jira issues from that project or a list of revision messages.
          No
        Show
        Jagadish added a comment - What is the impact on the customer of the bug? Customer's implementation of EndpointDeactivation in their RAR implementation will not get called if <resource-adapter-mid> is not specified in the ejb descriptor. How likely is it that a customer will see the bug and how serious is the bug? This issue will be seen in inbound resource-adapters, <resource-adapter-mid> is not specified in the ejb descriptor. Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)? What CTS failures are caused by this bug? No CTS failures. This seems to be a bug that existed ever since the "default" RA detection mechanism was introduced (Probably, GlassFish 3.0) What is the cost/risk of fixing the bug? Fix is simple, use the same logic to determine the "matching" RA during endpoint activation that is used today for endpoint deactivation also. How risky is the fix? How much work is the fix? Is the fix complicated? Fix is simple, refactored the RA selection algorithm so that its used during endpoint deactivation also. Is there an impact on documentation or message strings? No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? I shall make sure that no regressions in connector SQE tests happen before checking in. [QL, connector-dev, jdbc-dev, jms-dev, connector-standalone-cts (Web, Classic), resources-admin-cli are all passing.] Which is the targeted build of 4.0 for this fix? Build-86 If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. No
        Hide
        Tom Mueller added a comment -

        Approved for 4.0.

        Show
        Tom Mueller added a comment - Approved for 4.0.
        Hide
        Jagadish added a comment -

        FIX INFORMATION :

        svn log -v -r 61615
        ------------------------------------------------------------------------
        r61615 | jr158900 | 2013-04-24 15:24:52 +0530 (Wed, 24 Apr 2013) | 9 lines
        Changed paths:
        M /trunk/main/appserver/connectors/connectors-inbound-runtime/src/main/java/com/sun/enterprise/connectors/inbound/ConnectorMessageBeanClient.java
        M /trunk/main/appserver/connectors/connectors-inbound-runtime/src/main/resources/com/sun/enterprise/connectors/inbound/LocalStrings.properties

        GLASSFISH-20389 : endpointDeactivation not called for during MDB undeployment for MDB's with no resource-adapter-mid specified

        Fix is to make sure that resource-adapter-mid is derived during endpoint deactivation similar to
        how it is done during endpoint activation

        Show
        Jagadish added a comment - FIX INFORMATION : svn log -v -r 61615 ------------------------------------------------------------------------ r61615 | jr158900 | 2013-04-24 15:24:52 +0530 (Wed, 24 Apr 2013) | 9 lines Changed paths: M /trunk/main/appserver/connectors/connectors-inbound-runtime/src/main/java/com/sun/enterprise/connectors/inbound/ConnectorMessageBeanClient.java M /trunk/main/appserver/connectors/connectors-inbound-runtime/src/main/resources/com/sun/enterprise/connectors/inbound/LocalStrings.properties GLASSFISH-20389 : endpointDeactivation not called for during MDB undeployment for MDB's with no resource-adapter-mid specified Fix is to make sure that resource-adapter-mid is derived during endpoint deactivation similar to how it is done during endpoint activation

          People

          • Assignee:
            Jagadish
            Reporter:
            Sivakumar Thyagarajan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: