Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0_b85
    • Fix Version/s: 4.0_b86_RC2
    • Component/s: admin
    • Labels:
      None

      Description

      Most references to the domain-scoped password alias store (looked up using hk2) in this class use the get... method which populates the field if necessary, but two references in one method do not, referring directly to the field itself, and those references can lead to NPEs.

      • What is the impact on the customer of the bug?

      This is a regression. Diagnosing a connector devtest error led to this.

      • What is the cost/risk of fixing the bug?
        Very low risk. Two call sites in one class need to invoke a method (which is already used in other places in the class) instead of referring directly to a field.
      • Is there an impact on documentation or message strings?
        No
      • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
        QL
      • Which is the targeted build of 4.0 for this fix?
        b86_RC2
      • If this an integration of a new version of a component from another project,
        what are the changes that are being brought in?
        n/a

        Activity

        Hide
        Tim Quinn added a comment -

        Fix checked in.

        Project: glassfish
        Repository: svn
        Revision: 61604
        Author: tjquinn
        Date: 2013-04-24 00:42:12 UTC
        Link:

        Log Message:
        ------------
        GLASSFISH-20394 - NPE in RelativePathResolver

        Earlier changes introduced the getDomainScopedPasswordAliasStore method which, when needed, looks up an hk2 service. Two call sites in the class weren't converted to use the method instead of referring directly to the field. This led to NPEs.

        This changes replaces the direct field references with invocations of the get... method.

        Approved: Michael
        Reviewed: Chris
        Passed: QL, offending connector deftest that exposed the NPE

        Revisions:
        ----------
        61604

        Modified Paths:
        ---------------
        trunk/main/nucleus/common/internal-api/src/main/java/org/glassfish/internal/api/RelativePathResolver.java

        Show
        Tim Quinn added a comment - Fix checked in. Project: glassfish Repository: svn Revision: 61604 Author: tjquinn Date: 2013-04-24 00:42:12 UTC Link: Log Message: ------------ GLASSFISH-20394 - NPE in RelativePathResolver Earlier changes introduced the getDomainScopedPasswordAliasStore method which, when needed, looks up an hk2 service. Two call sites in the class weren't converted to use the method instead of referring directly to the field. This led to NPEs. This changes replaces the direct field references with invocations of the get... method. Approved: Michael Reviewed: Chris Passed: QL, offending connector deftest that exposed the NPE Revisions: ---------- 61604 Modified Paths: --------------- trunk/main/nucleus/common/internal-api/src/main/java/org/glassfish/internal/api/RelativePathResolver.java

          People

          • Assignee:
            Tim Quinn
            Reporter:
            Tim Quinn
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: