glassfish
  1. glassfish
  2. GLASSFISH-20408

glassfish-verifier: bin script don't have execution permissions

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0_b86_RC2
    • Fix Version/s: 4.0_b87_RC3
    • Component/s: build_system
    • Labels:
      None

      Description

      glassfish-verifier: bin script don't have execution permissions

        Activity

        Hide
        Romain Grécourt added a comment -
        • What is the impact on the customer of the bug?
          Direct impact if they try to install glassfish-verifier package, they will have to chmod the bin verify script.

        How likely is it that a customer will see the bug and how serious is the bug?
        Every person trying to install and use glassfish-verify will see the bug.
        Not serious, but unprofessional

        Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)?
        Yes.

        What CTS failures are caused by this bug?
        None.

        • What is the cost/risk of fixing the bug?
          Easy, it should be a change in the pkg prototype to specify the permissions properly.

        How risky is the fix? How much work is the fix? Is the fix complicated?
        not risky.

        • Is there an impact on documentation or message strings?
          No.
        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
          Install glassfish-verifier and try to start the script after installation.
        • Which is the targeted build of 4.0 for this fix?
          b87
        • If this an integration of a new version of a component from another project,
          what are the changes that are being brought in? This might be list of
          Jira issues from that project or a list of revision messages.
        Show
        Romain Grécourt added a comment - What is the impact on the customer of the bug? Direct impact if they try to install glassfish-verifier package, they will have to chmod the bin verify script. How likely is it that a customer will see the bug and how serious is the bug? Every person trying to install and use glassfish-verify will see the bug. Not serious, but unprofessional Is it a regression? Does it meet other bug fix criteria (security, performance, etc.)? Yes. What CTS failures are caused by this bug? None. What is the cost/risk of fixing the bug? Easy, it should be a change in the pkg prototype to specify the permissions properly. How risky is the fix? How much work is the fix? Is the fix complicated? not risky. Is there an impact on documentation or message strings? No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? Install glassfish-verifier and try to start the script after installation. Which is the targeted build of 4.0 for this fix? b87 If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages.
        Hide
        Romain Grécourt added a comment -

        Project: glassfish
        Repository: svn
        Revision: 61763
        Author: romain_grecourt
        Date: 2013-05-01 09:33:41 UTC
        Link:

        Log Message:
        ------------
        fix for GLASSFISH-20408, make glassfish-verifier bin scripts executable

        Revisions:
        ----------
        61763

        Modified Paths:
        ---------------
        trunk/main/appserver/packager/glassfish-verifier/pom.xml

        Added Paths:
        ------------
        trunk/main/appserver/packager/glassfish-verifier/src/main/assembly
        trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml

        Diffs:
        ------
        Index: trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml
        ===================================================================
        — trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml (revision 0)
        +++ trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml (revision 61763)
        @@ -0,0 +1,68 @@
        +<?xml version="1.0" encoding="UTF-8"?>
        +<!--
        +
        + DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
        +
        + Copyright (c) 2013 Oracle and/or its affiliates. All rights reserved.
        +
        + The contents of this file are subject to the terms of either the GNU
        + General Public License Version 2 only ("GPL") or the Common Development
        + and Distribution License("CDDL") (collectively, the "License"). You
        + may not use this file except in compliance with the License. You can
        + obtain a copy of the License at
        + https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html
        + or packager/legal/LICENSE.txt. See the License for the specific
        + language governing permissions and limitations under the License.
        +
        + When distributing the software, include this License Header Notice in each
        + file and include the License file at packager/legal/LICENSE.txt.
        +
        + GPL Classpath Exception:
        + Oracle designates this particular file as subject to the "Classpath"
        + exception as provided by Oracle in the GPL Version 2 section of the License
        + file that accompanied this code.
        +
        + Modifications:
        + If applicable, add the following below the License Header, with the fields
        + enclosed by brackets [] replaced by your own identifying information:
        + "Portions Copyright [year] [name of copyright owner]"
        +
        + Contributor(s):
        + If you wish your version of this file to be governed by only the CDDL or
        + only the GPL Version 2, indicate your decision by adding "[Contributor]
        + elects to include this software in this distribution under the [CDDL or GPL
        + Version 2] license." If you don't indicate a single choice of license, a
        + recipient has the option to distribute your version of this file under
        + either the CDDL, the GPL Version 2 or to extend the choice of license to
        + its licensees as provided above. However, if you add GPL Version 2 code
        + and therefore, elected the GPL Version 2 license, then the option applies
        + only if the new code is made subject to such option by the copyright
        + holder.
        +
        +-->
        +
        +<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        + xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2 http://maven.apache.org/xsd/assembly-1.1.2.xsd">
        +
        + <id>stage-package</id>
        + <formats>
        + <format>dir</format>
        + </formats>
        +
        + <includeBaseDirectory>false</includeBaseDirectory>
        + <fileSets>
        + <fileSet>
        + <directory>$

        {temp.dir}/glassfish/bin</directory>
        + <outputDirectory>${install.dir.name}/glassfish/bin</outputDirectory>
        + <fileMode>755</fileMode>
        + </fileSet>
        + <fileSet>
        + <directory>${temp.dir}

        </directory>
        + <excludes>
        + <exclude>glassfish/bin/*</exclude>
        + <exclude>pkg_proto.py</exclude>
        + </excludes>
        + <outputDirectory>$

        {install.dir.name}

        </outputDirectory>
        + </fileSet>
        + </fileSets>
        +</assembly>

        Property changes on: trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml
        ___________________________________________________________________
        Added: svn:eol-style

          1. -0,0 +1 ##
            +native
            \ No newline at end of property
            Index: trunk/main/appserver/packager/glassfish-verifier/pom.xml
            ===================================================================
            • trunk/main/appserver/packager/glassfish-verifier/pom.xml (revision 61762)
              +++ trunk/main/appserver/packager/glassfish-verifier/pom.xml (revision 61763)
              @@ -52,6 +52,10 @@
              <name>Verifier Package</name>
              <packaging>distribution-fragment</packaging>
              <description>This pom describes how to assemble the Verifier package</description>
              +
              + <properties>
              + <temp.dir>$ {project.build.directory}

              /dependency</temp.dir>
              + </properties>

        <build>
        <plugins>

        Show
        Romain Grécourt added a comment - Project: glassfish Repository: svn Revision: 61763 Author: romain_grecourt Date: 2013-05-01 09:33:41 UTC Link: Log Message: ------------ fix for GLASSFISH-20408 , make glassfish-verifier bin scripts executable Revisions: ---------- 61763 Modified Paths: --------------- trunk/main/appserver/packager/glassfish-verifier/pom.xml Added Paths: ------------ trunk/main/appserver/packager/glassfish-verifier/src/main/assembly trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml Diffs: ------ Index: trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml =================================================================== — trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml (revision 0) +++ trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml (revision 61763) @@ -0,0 +1,68 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. + + Copyright (c) 2013 Oracle and/or its affiliates. All rights reserved. + + The contents of this file are subject to the terms of either the GNU + General Public License Version 2 only ("GPL") or the Common Development + and Distribution License("CDDL") (collectively, the "License"). You + may not use this file except in compliance with the License. You can + obtain a copy of the License at + https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html + or packager/legal/LICENSE.txt. See the License for the specific + language governing permissions and limitations under the License. + + When distributing the software, include this License Header Notice in each + file and include the License file at packager/legal/LICENSE.txt. + + GPL Classpath Exception: + Oracle designates this particular file as subject to the "Classpath" + exception as provided by Oracle in the GPL Version 2 section of the License + file that accompanied this code. + + Modifications: + If applicable, add the following below the License Header, with the fields + enclosed by brackets [] replaced by your own identifying information: + "Portions Copyright [year] [name of copyright owner] " + + Contributor(s): + If you wish your version of this file to be governed by only the CDDL or + only the GPL Version 2, indicate your decision by adding " [Contributor] + elects to include this software in this distribution under the [CDDL or GPL + Version 2] license." If you don't indicate a single choice of license, a + recipient has the option to distribute your version of this file under + either the CDDL, the GPL Version 2 or to extend the choice of license to + its licensees as provided above. However, if you add GPL Version 2 code + and therefore, elected the GPL Version 2 license, then the option applies + only if the new code is made subject to such option by the copyright + holder. + +--> + +<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2 http://maven.apache.org/xsd/assembly-1.1.2.xsd "> + + <id>stage-package</id> + <formats> + <format>dir</format> + </formats> + + <includeBaseDirectory>false</includeBaseDirectory> + <fileSets> + <fileSet> + <directory>$ {temp.dir}/glassfish/bin</directory> + <outputDirectory>${install.dir.name}/glassfish/bin</outputDirectory> + <fileMode>755</fileMode> + </fileSet> + <fileSet> + <directory>${temp.dir} </directory> + <excludes> + <exclude>glassfish/bin/*</exclude> + <exclude>pkg_proto.py</exclude> + </excludes> + <outputDirectory>$ {install.dir.name} </outputDirectory> + </fileSet> + </fileSets> +</assembly> Property changes on: trunk/main/appserver/packager/glassfish-verifier/src/main/assembly/glassfish-verifier.xml ___________________________________________________________________ Added: svn:eol-style -0,0 +1 ## +native \ No newline at end of property Index: trunk/main/appserver/packager/glassfish-verifier/pom.xml =================================================================== trunk/main/appserver/packager/glassfish-verifier/pom.xml (revision 61762) +++ trunk/main/appserver/packager/glassfish-verifier/pom.xml (revision 61763) @@ -52,6 +52,10 @@ <name>Verifier Package</name> <packaging>distribution-fragment</packaging> <description>This pom describes how to assemble the Verifier package</description> + + <properties> + <temp.dir>$ {project.build.directory} /dependency</temp.dir> + </properties> <build> <plugins>

          People

          • Assignee:
            Romain Grécourt
            Reporter:
            Romain Grécourt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 hour
              1h
              Remaining:
              Remaining Estimate - 1 hour
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified