glassfish
  1. glassfish
  2. GLASSFISH-20427

[regression] A distribution's dependencies are not optional

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0_b86_RC2
    • Fix Version/s: 4.1_b07
    • Component/s: build_system
    • Labels:
      None

      Description

      See GLASSFISH-17170 where in we had marked all the dependencies of a distribution optional so that one could use a distribution without having to pull in all its dependencies. It seems changes trunk has reverted that fix. Pl fix it for 4.0.

        Issue Links

          Activity

          Sanjeeb Sahoo created issue -
          Snjezana Sevo-Zenzerovic made changes -
          Field Original Value New Value
          Assignee Joe Di Pol [ jfdipol ] Romain Grécourt [ romain_grecourt ]
          Hide
          Romain Grécourt added a comment -

          I prefer to use intermediate poms, in order to cut the graph at distribution level, but still have a visible graph for inheritance between distributions.
          I'm not sure to address that in 4.0

          Show
          Romain Grécourt added a comment - I prefer to use intermediate poms, in order to cut the graph at distribution level, but still have a visible graph for inheritance between distributions. I'm not sure to address that in 4.0
          Romain Grécourt made changes -
          Link This issue depends on GLASSFISH-19770 [ GLASSFISH-19770 ]
          Hide
          Romain Grécourt added a comment -

          will fix it for 4.0.1

          Show
          Romain Grécourt added a comment - will fix it for 4.0.1
          Romain Grécourt made changes -
          Fix Version/s 4.0.1 [ 16061 ]
          Hide
          Sanjeeb Sahoo added a comment -

          This should be fixed in 4.0.

          Show
          Sanjeeb Sahoo added a comment - This should be fixed in 4.0.
          Hide
          Romain Grécourt added a comment -

          Michael, please evaluate. I can come up with a fix for 4.0 if needed.

          Show
          Romain Grécourt added a comment - Michael, please evaluate. I can come up with a fix for 4.0 if needed.
          Romain Grécourt made changes -
          Assignee Romain Grécourt [ romain_grecourt ] michael.y.chen [ michael.y.chen ]
          Romain Grécourt made changes -
          Fix Version/s 4.0 [ 10970 ]
          Fix Version/s 4.0.1 [ 16061 ]
          Hide
          michael.y.chen added a comment -

          This is a bug, but I don't consider it showstopper.

          • How likely is it that a customer will hit the bug?

          Not very likely. This bug is only encountered by maven users consuming glassfish.zip as a maven dependency in their project. It does not impact our download bundles.

          • How severe is the customer impact?

          Low. There is no loss of data or functionality. It is annoying that all dependencies are downloaded by maven, but functionally things work.

          Is this a regression? Yes, the 3.X glassfish.zip artifact does not have this behavior. But I still claim that customer impact is not severe enough to warrant it being a showstopper.

          Show
          michael.y.chen added a comment - This is a bug, but I don't consider it showstopper. How likely is it that a customer will hit the bug? Not very likely. This bug is only encountered by maven users consuming glassfish.zip as a maven dependency in their project. It does not impact our download bundles. How severe is the customer impact? Low. There is no loss of data or functionality. It is annoying that all dependencies are downloaded by maven, but functionally things work. Is this a regression? Yes, the 3.X glassfish.zip artifact does not have this behavior. But I still claim that customer impact is not severe enough to warrant it being a showstopper.
          michael.y.chen made changes -
          Assignee michael.y.chen [ michael.y.chen ] Romain Grécourt [ romain_grecourt ]
          Fix Version/s 4.0.1 [ 16061 ]
          Fix Version/s 4.0 [ 10970 ]
          Romain Grécourt made changes -
          Tags 4_0_1-review
          alan42 made changes -
          Tags 4_0_1-review
          alan42 made changes -
          Tags 4_0_1-reviewed
          Romain Grécourt made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.0.1_b07 [ 16925 ]
          Fix Version/s 4.0.1 [ 16061 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Romain Grécourt
              Reporter:
              Sanjeeb Sahoo
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: