glassfish
  1. glassfish
  2. GLASSFISH-20429

package-appclient script fails if invoked using a path that includes a space

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0_b86_RC2
    • Fix Version/s: 4.0.1
    • Component/s: standalone_client
    • Labels:
      None

      Description

      When GlassFish is installed on a non-Windows system into a directory which contains a space, the package-appclient script fails if the user invokes it using the part of the path which contains a space.

      This is because the AS_INSTALL symbol is created like this

      _AS_INSTALL=`dirname $0`/..

      Changing the declaration to this

      _AS_INSTALL=`dirname "$0"`/..

      (note the added double quote marks) resolves the problem.

        Issue Links

          Activity

          Hide
          Tim Quinn added a comment -

          Excluding this from 4.0.

          A workaround, suitable for release notes, is to (a) avoid installing GlassFish into a path which includes a space, or (b) invoke the package-appclient script using a relative path that does not include a space.

          Show
          Tim Quinn added a comment - Excluding this from 4.0. A workaround, suitable for release notes, is to (a) avoid installing GlassFish into a path which includes a space, or (b) invoke the package-appclient script using a relative path that does not include a space.
          Hide
          Gail Risdal added a comment -

          Added the following to the release notes:

          package-appclient script fails if invoked using a path that includes a space (20429)

          Description
          On non-Windows systems, when GlassFish Server is installed into a directory that contains a space in its name, the package-appclient script fails if the script is invoked using a path that includes a space.

          Workaround
          Install GlassFish Server into a path without a space or invoke the package-appclient script with a relative path that does not contain a space.

          Show
          Gail Risdal added a comment - Added the following to the release notes: package-appclient script fails if invoked using a path that includes a space (20429) Description On non-Windows systems, when GlassFish Server is installed into a directory that contains a space in its name, the package-appclient script fails if the script is invoked using a path that includes a space. Workaround Install GlassFish Server into a path without a space or invoke the package-appclient script with a relative path that does not contain a space.
          Hide
          Tim Quinn added a comment -

          Fix checked in.

          Project: glassfish
          Repository: svn
          Revision: 62758
          Author: tjquinn
          Date: 2013-09-24 14:18:00 UTC
          Link:

          Log Message:
          ------------
          Fix for GLASSFISH_20429 - package-appclient script fails if invoked using a path that includes a space

          Due to how command-line arguments are substituted in shells the package-appclient script did not correctly handle directory arguments that contained spaces. Adding judiciously-placed quote marks solves the problem.

          Tests: manual tests, RQ

          Revisions:
          ----------
          62758

          Modified Paths:
          ---------------
          trunk/main/appserver/appclient/client/appclient-scripts/src/main/resources/glassfish/bin/package-appclient

          Show
          Tim Quinn added a comment - Fix checked in. Project: glassfish Repository: svn Revision: 62758 Author: tjquinn Date: 2013-09-24 14:18:00 UTC Link: Log Message: ------------ Fix for GLASSFISH_20429 - package-appclient script fails if invoked using a path that includes a space Due to how command-line arguments are substituted in shells the package-appclient script did not correctly handle directory arguments that contained spaces. Adding judiciously-placed quote marks solves the problem. Tests: manual tests, RQ Revisions: ---------- 62758 Modified Paths: --------------- trunk/main/appserver/appclient/client/appclient-scripts/src/main/resources/glassfish/bin/package-appclient

            People

            • Assignee:
              Tim Quinn
              Reporter:
              Tim Quinn
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: