Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.0_b89_RC5
    • Fix Version/s: None
    • Component/s: logging
    • Labels:
      None

      Description

      After the activation of AMX, the following warnings are visible in the log file. They seem to be meaningless for the end user. Please remove it:

      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getInitialWindowSizeInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxConcurrentStreams(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getMaxFrameLengthInBytes(): int
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getSpdy2Enabled(): boolean
      INFO: Illegal non-string type for org.glassfish.grizzly.config.dom.Spdy.getEnabled(): boolean

        Activity

        Show
        smillidge-c2b2 added a comment - Fixed by https://github.com/payara/Payara/commit/177659f483b064556f6dfaed9ba52986ba5d50ce Diff in next comment
        Hide
        smillidge-c2b2 added a comment -

        diff --git a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java
        index 1da7f80..1e34f26 100644
        — a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java
        +++ b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java
        @@ -176,19 +176,19 @@ public class EnableSpdyCommand implements AdminCommand {
        if (maxStreams != null) {
        int maxStreamsLocal = Integer.parseInt(maxStreams);
        if (maxStreamsLocal > 0)

        { - spdy.setMaxConcurrentStreams(Integer.toString(maxStreamsLocal)); + spdy.setMaxConcurrentStreams(maxStreamsLocal); }

        }
        if (initialWindowSize != null) {
        int initialWindowSizeLocal = Integer.parseInt(initialWindowSize);
        if (initialWindowSizeLocal > 0)

        { - spdy.setInitialWindowSizeInBytes(Integer.toString(initialWindowSizeLocal)); + spdy.setInitialWindowSizeInBytes(initialWindowSizeLocal); }

        }
        if (maxFrameLengthInBytes != null) {
        int maxFrameLengthInBytesLocal = Integer.parseInt(maxFrameLengthInBytes);
        if (maxFrameLengthInBytesLocal > 0 && maxFrameLengthInBytesLocal < (1 << 24))

        { - spdy.setMaxFrameLengthInBytes(Integer.toString(maxFrameLengthInBytesLocal)); + spdy.setMaxFrameLengthInBytes(maxFrameLengthInBytesLocal); }

        }
        if (mode != null) {
        diff --git a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java
        index 898ecf3..29862f5 100644
        — a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java
        +++ b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java
        @@ -114,9 +114,9 @@ public class SpdyAddOnProvider implements AddOn, ConfigAwareElement<Spdy>

        { spdyAddOn = new GlassFishSpdyAddOn(spdyMode, spdyVersions); - spdyAddOn.setInitialWindowSize(Integer.getInteger(spdy.getInitialWindowSizeInBytes())); - spdyAddOn.setMaxConcurrentStreams(Integer.getInteger(spdy.getMaxConcurrentStreams())); - spdyAddOn.setMaxFrameLength(Integer.getInteger(spdy.getMaxFrameLengthInBytes())); + spdyAddOn.setInitialWindowSize(spdy.getInitialWindowSizeInBytes()); + spdyAddOn.setMaxConcurrentStreams(spdy.getMaxConcurrentStreams()); + spdyAddOn.setMaxFrameLength(spdy.getMaxFrameLengthInBytes()); }

        @Override
        diff --git a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java
        index bec06fe..871722c 100644
        — a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java
        +++ b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java
        @@ -717,7 +717,7 @@ public class GenericGrizzlyListener implements GrizzlyListener {
        final Spdy spdyElement,
        final FilterChainBuilder builder,
        final boolean secure) {

        • if (spdyElement != null && GrizzlyConfig.toBoolean(spdyElement.getEnabled())) {
          + if (spdyElement != null && spdyElement.getEnabled()) {

        boolean isNpnMode = spdyElement.getMode() == null ||
        "npn".equalsIgnoreCase(spdyElement.getMode());
        diff --git a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java
        index 1894988..1b8003c 100644
        — a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java
        +++ b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java
        @@ -62,9 +62,9 @@ public interface Spdy extends ConfigBeanProxy, PropertyBag {

        • Enables SPDY support.
          */
          @Attribute(defaultValue = "" + ENABLED, dataType = Boolean.class)
        • String getEnabled();
          + boolean getEnabled();
        • void setEnabled(String enabled);
          + void setEnabled(boolean enabled);

        /**

        • SPDY mode.
          @@ -80,25 +80,25 @@ public interface Spdy extends ConfigBeanProxy, PropertyBag {
        • The default is 50.
          */
          @Attribute(defaultValue = "" + MAX_CONCURRENT_STREAMS, dataType = Integer.class)
        • String getMaxConcurrentStreams();
          + int getMaxConcurrentStreams();
        • void setMaxConcurrentStreams(String maxConcurrentStreams);
          + void setMaxConcurrentStreams(int maxConcurrentStreams);

        /**

        • Configures the initial window size in bytes. The default is 64K.
          */
          @Attribute(defaultValue = "" + INITIAL_WINDOW_SIZE_IN_BYTES, dataType = Integer.class)
        • String getInitialWindowSizeInBytes();
          + int getInitialWindowSizeInBytes();
        • void setInitialWindowSizeInBytes(String initialWindowSizeInBytes);
          + void setInitialWindowSizeInBytes(int initialWindowSizeInBytes);

        /**

        • Configures the maximum length of SPDY frame to be accepted. The default is 2^24.
          */
          @Attribute(defaultValue = "" + MAX_FRAME_LENGTH_IN_BYTES, dataType = Integer.class)
        • String getMaxFrameLengthInBytes();
          + int getMaxFrameLengthInBytes();
        • void setMaxFrameLengthInBytes(String maxFrameLengthInBytes);
          + void setMaxFrameLengthInBytes(int maxFrameLengthInBytes);

        /**

        • Enables SPDY support.
        Show
        smillidge-c2b2 added a comment - diff --git a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java index 1da7f80..1e34f26 100644 — a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java +++ b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/EnableSpdyCommand.java @@ -176,19 +176,19 @@ public class EnableSpdyCommand implements AdminCommand { if (maxStreams != null) { int maxStreamsLocal = Integer.parseInt(maxStreams); if (maxStreamsLocal > 0) { - spdy.setMaxConcurrentStreams(Integer.toString(maxStreamsLocal)); + spdy.setMaxConcurrentStreams(maxStreamsLocal); } } if (initialWindowSize != null) { int initialWindowSizeLocal = Integer.parseInt(initialWindowSize); if (initialWindowSizeLocal > 0) { - spdy.setInitialWindowSizeInBytes(Integer.toString(initialWindowSizeLocal)); + spdy.setInitialWindowSizeInBytes(initialWindowSizeLocal); } } if (maxFrameLengthInBytes != null) { int maxFrameLengthInBytesLocal = Integer.parseInt(maxFrameLengthInBytes); if (maxFrameLengthInBytesLocal > 0 && maxFrameLengthInBytesLocal < (1 << 24)) { - spdy.setMaxFrameLengthInBytes(Integer.toString(maxFrameLengthInBytesLocal)); + spdy.setMaxFrameLengthInBytes(maxFrameLengthInBytesLocal); } } if (mode != null) { diff --git a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java index 898ecf3..29862f5 100644 — a/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java +++ b/appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java @@ -114,9 +114,9 @@ public class SpdyAddOnProvider implements AddOn, ConfigAwareElement<Spdy> { spdyAddOn = new GlassFishSpdyAddOn(spdyMode, spdyVersions); - spdyAddOn.setInitialWindowSize(Integer.getInteger(spdy.getInitialWindowSizeInBytes())); - spdyAddOn.setMaxConcurrentStreams(Integer.getInteger(spdy.getMaxConcurrentStreams())); - spdyAddOn.setMaxFrameLength(Integer.getInteger(spdy.getMaxFrameLengthInBytes())); + spdyAddOn.setInitialWindowSize(spdy.getInitialWindowSizeInBytes()); + spdyAddOn.setMaxConcurrentStreams(spdy.getMaxConcurrentStreams()); + spdyAddOn.setMaxFrameLength(spdy.getMaxFrameLengthInBytes()); } @Override diff --git a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java index bec06fe..871722c 100644 — a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java +++ b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java @@ -717,7 +717,7 @@ public class GenericGrizzlyListener implements GrizzlyListener { final Spdy spdyElement, final FilterChainBuilder builder, final boolean secure) { if (spdyElement != null && GrizzlyConfig.toBoolean(spdyElement.getEnabled())) { + if (spdyElement != null && spdyElement.getEnabled()) { boolean isNpnMode = spdyElement.getMode() == null || "npn".equalsIgnoreCase(spdyElement.getMode()); diff --git a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java index 1894988..1b8003c 100644 — a/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java +++ b/nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/dom/Spdy.java @@ -62,9 +62,9 @@ public interface Spdy extends ConfigBeanProxy, PropertyBag { Enables SPDY support. */ @Attribute(defaultValue = "" + ENABLED, dataType = Boolean.class) String getEnabled(); + boolean getEnabled(); void setEnabled(String enabled); + void setEnabled(boolean enabled); /** SPDY mode. @@ -80,25 +80,25 @@ public interface Spdy extends ConfigBeanProxy, PropertyBag { The default is 50. */ @Attribute(defaultValue = "" + MAX_CONCURRENT_STREAMS, dataType = Integer.class) String getMaxConcurrentStreams(); + int getMaxConcurrentStreams(); void setMaxConcurrentStreams(String maxConcurrentStreams); + void setMaxConcurrentStreams(int maxConcurrentStreams); /** Configures the initial window size in bytes. The default is 64K. */ @Attribute(defaultValue = "" + INITIAL_WINDOW_SIZE_IN_BYTES, dataType = Integer.class) String getInitialWindowSizeInBytes(); + int getInitialWindowSizeInBytes(); void setInitialWindowSizeInBytes(String initialWindowSizeInBytes); + void setInitialWindowSizeInBytes(int initialWindowSizeInBytes); /** Configures the maximum length of SPDY frame to be accepted. The default is 2^24. */ @Attribute(defaultValue = "" + MAX_FRAME_LENGTH_IN_BYTES, dataType = Integer.class) String getMaxFrameLengthInBytes(); + int getMaxFrameLengthInBytes(); void setMaxFrameLengthInBytes(String maxFrameLengthInBytes); + void setMaxFrameLengthInBytes(int maxFrameLengthInBytes); /** Enables SPDY support.

          People

          • Assignee:
            rajendra_inamdar
            Reporter:
            abien
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: