glassfish
  1. glassfish
  2. GLASSFISH-20760

Updating fighterfish uas's parent pom to use maven-war-plugin 2.4 version

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.0_b89_RC5
    • Fix Version/s: 4.1.1
    • Component/s: OSGi-JavaEE
    • Labels:
      None
    • Environment:

      Windows

      Description

      maven-war-plugin 2.1 version has a bug as following:

      While building war or wab in windows platform using 2.1 version, there are two same web.xml in the final war.

      So, I suggest updating maven-war-plugin into 2.4 version.

      Sahoo, do you agree with me?

        Activity

        Hide
        TangYong added a comment -

        About the bug, pl. seeing the following:

        http://jira.codehaus.org/browse/MWAR-235

        Show
        TangYong added a comment - About the bug, pl. seeing the following: http://jira.codehaus.org/browse/MWAR-235
        Hide
        TangYong added a comment -

        BTW: although currently, simpleweb needs not web.xml, for other using scene(eg. jsf), we'd better update the plugin.

        Show
        TangYong added a comment - BTW: although currently, simpleweb needs not web.xml, for other using scene(eg. jsf), we'd better update the plugin.
        Hide
        Sanjeeb Sahoo added a comment -

        I see no issues in upgrading the plugin version as long as there is no regression. Just to be clear, you want this changed in sample.parent-pom, don't you?

        Show
        Sanjeeb Sahoo added a comment - I see no issues in upgrading the plugin version as long as there is no regression. Just to be clear, you want this changed in sample.parent-pom, don't you?
        Hide
        TangYong added a comment -

        Yes, I want to make a change in sample.parent-pom. Just as you said, before updating the pom, we must guarantee there is no any regression.

        As an example or scene, you can see the issue by building https://github.com/tangyong/GlassFishOSGiJavaEESample/tree/master/glassfish.wab.sample

        Thanks
        Tang

        Show
        TangYong added a comment - Yes, I want to make a change in sample.parent-pom. Just as you said, before updating the pom, we must guarantee there is no any regression. As an example or scene, you can see the issue by building https://github.com/tangyong/GlassFishOSGiJavaEESample/tree/master/glassfish.wab.sample Thanks Tang
        Hide
        TangYong added a comment -

        Regression Test is OK except for GLASSFISH-20782 and GLASSFISH-20782 is not related to the jira.

        So, I will commit the change.

        Show
        TangYong added a comment - Regression Test is OK except for GLASSFISH-20782 and GLASSFISH-20782 is not related to the jira. So, I will commit the change.
        Hide
        TangYong added a comment -

        Done.

        Revisions:
        ----------
        62656

        Show
        TangYong added a comment - Done. Revisions: ---------- 62656

          People

          • Assignee:
            Sanjeeb Sahoo
            Reporter:
            TangYong
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: