glassfish
  1. glassfish
  2. GLASSFISH-20922

upgrading weld-osgi-bundle.jar into 2.2.1.Final

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: cdi
    • Labels:
      None

      Description

      upgrading weld-osgi-bundle.jar into 2.1.0.Final, in the version, there is the following big changes based on [1] and [2]

      1. javax.inject has been removed from <_exportcontents> and javax.inject dependency has been removed

      2. javax.enterprise.* has been removed from <_exportcontents> and javax.enterprise:cdi-api dependency has been removed

      3. guava dependency has been removed

      All is based on [3]and [4]

      [1]: https://github.com/weld/core/blob/2.1/bundles/osgi/pom.xml
      [2]: https://github.com/weld/core/commit/3e5cc452783161a9aae40160da1656216084bc33
      [3]: https://issues.jboss.org/browse/WELD-1428
      [4]: https://issues.jboss.org/browse/WELD-1477

      Once upgrading 2.1.0.Final, these big changes will need GF distro to do the following:

      1. javax.enterprise:cdi-api will be put into modules
      2. whether current guava module in gf will meet the demand from weld-osgi-bundle. This needs to be confirm.

        Activity

        Hide
        TangYong added a comment -

        3. also confirm whether some modules which only depend on cdi api originally exported by weld-osgi-bundle, needs to be
        switched into depending on javax.enterprise:cdi-api?

        Show
        TangYong added a comment - 3. also confirm whether some modules which only depend on cdi api originally exported by weld-osgi-bundle, needs to be switched into depending on javax.enterprise:cdi-api?
        Hide
        mauritzlovgren added a comment -

        Might be important to inform current 4.0.0 users of the serious memory leak in the Weld version that is bundled with 4.0.0 release (Weld 2.0). Weld has released a fix for part of this memory leak that was causing big trouble in our production environment: http://weld.cdi-spec.org/news/2014/01/14/weld-212-final/. I assume that GF 4.0.1 will have a newer version of Weld, at least 2.0.5.Final or newer?).

        Show
        mauritzlovgren added a comment - Might be important to inform current 4.0.0 users of the serious memory leak in the Weld version that is bundled with 4.0.0 release (Weld 2.0). Weld has released a fix for part of this memory leak that was causing big trouble in our production environment: http://weld.cdi-spec.org/news/2014/01/14/weld-212-final/ . I assume that GF 4.0.1 will have a newer version of Weld, at least 2.0.5.Final or newer?).
        Hide
        elio.alves added a comment -

        I fix this bug and update the weld version toweld-2.1.2.Final but I dont know how to commit.

        Somebody can help-me?

        Below my changes

        update of lib weld-osgi-api to weld-2.1.2.Final because the atual version have a bug that mixing the sessions
        update on BootstrapConfigurationImpl and ACLSingletonProvider to works with weld-2.1.2.Final. I implemented 4 methods that reuse the same old methods
        I put two others bundles because the weld require it
        I created another packager... but i dont know if are in the correct form, but, works fine

        Show
        elio.alves added a comment - I fix this bug and update the weld version toweld-2.1.2.Final but I dont know how to commit. Somebody can help-me? Below my changes update of lib weld-osgi-api to weld-2.1.2.Final because the atual version have a bug that mixing the sessions update on BootstrapConfigurationImpl and ACLSingletonProvider to works with weld-2.1.2.Final. I implemented 4 methods that reuse the same old methods I put two others bundles because the weld require it I created another packager... but i dont know if are in the correct form, but, works fine
        Hide
        elio.alves added a comment -

        How I can commit my changes?
        This is my first fix in the java.net/jira

        Show
        elio.alves added a comment - How I can commit my changes? This is my first fix in the java.net/jira
        Hide
        jjsnyder83 added a comment -

        If you send me the changes I will get them committed in the next few days. There are a couple other steps that have to be done too before we can change the version.

        Show
        jjsnyder83 added a comment - If you send me the changes I will get them committed in the next few days. There are a couple other steps that have to be done too before we can change the version.
        Hide
        elio.alves added a comment -

        Hi jjsnyder83.

        How I can send to you?

        Show
        elio.alves added a comment - Hi jjsnyder83. How I can send to you?
        Hide
        jjsnyder83 added a comment -

        I am in the middle of updating GlassFish to CDI 1.2 and Weld 2.2.1.Final. I have a few tck failures to track down and then I will check it all in. Hopefully in a few days.

        Show
        jjsnyder83 added a comment - I am in the middle of updating GlassFish to CDI 1.2 and Weld 2.2.1.Final. I have a few tck failures to track down and then I will check it all in. Hopefully in a few days.
        Hide
        jjsnyder83 added a comment -

        Committed revision 63317.

        There are still a couple of tck failures. Jersey is causing a bunch and the Jersey team is supposed to update the version used in GlassFish today or tomorrow. Also there are 2 ejb test failures that should be fixed soon.

        Show
        jjsnyder83 added a comment - Committed revision 63317. There are still a couple of tck failures. Jersey is causing a bunch and the Jersey team is supposed to update the version used in GlassFish today or tomorrow. Also there are 2 ejb test failures that should be fixed soon.

          People

          • Assignee:
            jjsnyder83
            Reporter:
            TangYong
          • Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: