glassfish
  1. glassfish
  2. GLASSFISH-2117

thread-unsafe code in com.sun.enterprise.server.logging.ServerLogManager

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 9.1pe
    • Fix Version/s: not determined
    • Component/s: logging
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      2,117

      Description

      The variables 'customHandler' and 'customFilter' are not synchronized or volatile, leading to visibility
      and/or race condition issues. With both of them being used, any synchronization has to surround the
      paired usage:

      private static Handler customHandler = null;
      private static Filter customFilter = null;
      ....

      private static Filter getCustomFilter( ) {
      if(( customFilter != null )

      ( customFilterError ) ) { return customFilter; }

      LogService logService = getLogService( );
      if( logService == null )

      { return null; }

      String customFilterClassName = null;
      try

      { customFilterClassName = logService.getLogFilter( ); customFilter = (Filter) getInstance( customFilterClassName ); }

      catch( Exception e )

      { customFilterError = true; new ErrorManager().error( "Error In Instantiating Custom Filter " + customFilterClassName, e, ErrorManager.GENERIC_FAILURE ); }

      return customFilter;
      }

        Activity

        Hide
        gfbugbridge added a comment -

        <BT6515594>

        Show
        gfbugbridge added a comment - <BT6515594>
        Hide
        sridatta added a comment -

        will be fixed for FCS.Downgrading to a P3.

        Show
        sridatta added a comment - will be fixed for FCS.Downgrading to a P3.
        Hide
        jielin added a comment -

        They are not reaaly bugs. Will not fix at this time frame.

        Show
        jielin added a comment - They are not reaaly bugs. Will not fix at this time frame.
        Hide
        llc added a comment -

        You're claiming they're thread safe?

        Or that they're not thread safe, but somehow called in a way that is thread safe?

        If "they won't be fixed at this time", then that presumes there is something to fix, so how can they "not be
        bugs"?

        Show
        llc added a comment - You're claiming they're thread safe? Or that they're not thread safe, but somehow called in a way that is thread safe? If "they won't be fixed at this time", then that presumes there is something to fix, so how can they "not be bugs"?
        Hide
        dpatil added a comment -

        reassigning

        Show
        dpatil added a comment - reassigning
        Hide
        Tom Mueller added a comment -

        Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

        Show
        Tom Mueller added a comment - Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

          People

          • Assignee:
            jielin
            Reporter:
            llc
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: