glassfish
  1. glassfish
  2. GLASSFISH-215

PUMatchingEMRefTest should consider jar-file name

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.0pe
    • Fix Version/s: 9.0pe
    • Component/s: verifier
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      215

      Description

      The attached ear file looks like this:
      app.ear
      par.jar
      lib/par1.jar
      lib/par2.jar
      foo.war
      WEB-INF/classes/sahoo/Servlet.class

      Servlet.class uses an injected EM, but it does not specify unitName.
      entities are packaged in three ear scoped PUs:
      par.jar, lib/par1.jar and lib/par2.jar.
      All the three jar files are identical except their names.
      They all define a single PU inside them called em1.

      When I run verifier against it, it does not complain that the same named em
      exist in ear scope thrice and hence unitName must be used to resolve it. In
      fact, in this case, we have to use jar#unit syntax.

      When I analysed the code, I found that the bug is in
      AbstractPUMatchingEMRefTest.java#getPUs(Descriptor descriptor). In that method
      we should consider adding puRoot.

        Activity

        Hide
        Sanjeeb Sahoo added a comment -

        Created an attachment (id=61)
        test case along with README

        Show
        Sanjeeb Sahoo added a comment - Created an attachment (id=61) test case along with README
        Hide
        Sanjeeb Sahoo added a comment -

        Bhavani will look into this one.

        Show
        Sanjeeb Sahoo added a comment - Bhavani will look into this one.
        Hide
        Sanjeeb Sahoo added a comment -

        I am working on it.

        Show
        Sanjeeb Sahoo added a comment - I am working on it.
        Hide
        Sanjeeb Sahoo added a comment -

        Checking in
        appserv-commons/src/java/com/sun/enterprise/deployment/BundleDescriptor.java;
        /cvs/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/BundleDescriptor.java,v
        <-- BundleDescriptor.java
        new revision: 1.20; previous revision: 1.19
        done
        Checking in
        appserv-core/src/java/com/sun/enterprise/appclient/PersistenceUnitLoaderImpl.java;
        /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/appclient/PersistenceUnitLoaderImpl.java,v
        <-- PersistenceUnitLoaderImpl.java
        new revision: 1.2; previous revision: 1.1
        done
        Checking in
        avk/src/tools/com/sun/enterprise/tools/verifier/tests/AbstractPUMatchingEMRefTest.java;
        /cvs/glassfish/avk/src/tools/com/sun/enterprise/tools/verifier/tests/AbstractPUMatchingEMRefTest.java,v
        <-- AbstractPUMatchingEMRefTest.java
        new revision: 1.3; previous revision: 1.2
        done
        Checking in avk/src/tools/com/sun/enterprise/tools/verifier/LocalStrings.properties;
        /cvs/glassfish/avk/src/tools/com/sun/enterprise/tools/verifier/LocalStrings.properties,v
        <-- LocalStrings.properties
        new revision: 1.66; previous revision: 1.65
        done

        Show
        Sanjeeb Sahoo added a comment - Checking in appserv-commons/src/java/com/sun/enterprise/deployment/BundleDescriptor.java; /cvs/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/BundleDescriptor.java,v <-- BundleDescriptor.java new revision: 1.20; previous revision: 1.19 done Checking in appserv-core/src/java/com/sun/enterprise/appclient/PersistenceUnitLoaderImpl.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/appclient/PersistenceUnitLoaderImpl.java,v <-- PersistenceUnitLoaderImpl.java new revision: 1.2; previous revision: 1.1 done Checking in avk/src/tools/com/sun/enterprise/tools/verifier/tests/AbstractPUMatchingEMRefTest.java; /cvs/glassfish/avk/src/tools/com/sun/enterprise/tools/verifier/tests/AbstractPUMatchingEMRefTest.java,v <-- AbstractPUMatchingEMRefTest.java new revision: 1.3; previous revision: 1.2 done Checking in avk/src/tools/com/sun/enterprise/tools/verifier/LocalStrings.properties; /cvs/glassfish/avk/src/tools/com/sun/enterprise/tools/verifier/LocalStrings.properties,v <-- LocalStrings.properties new revision: 1.66; previous revision: 1.65 done

          People

          • Assignee:
            Sanjeeb Sahoo
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: