glassfish
  1. glassfish
  2. GLASSFISH-2381

error message is not clear about how to resolve

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.1pe
    • Fix Version/s: 9.0pe
    • Component/s: deployment
    • Labels:
      None
    • Environment:

      Operating System: Mac OS X
      Platform: Macintosh

    • Issuezilla Id:
      2,381

      Description

      It looks like the error message for the 'deploy a jar that has no ejbs' case has
      become more obtuse.

      In https://glassfish.dev.java.net/issues/show_bug.cgi?id=819, the error for the
      Java EE 5 case is pretty decent.

      The new message

      ADM1006:Uploading the file
      to:[/private/tmp/s1astempdomain1server-311955579/EJBModule1.jar]
      mbean.deploy_failed
      com.sun.enterprise.admin.common.exception.DeploymentException: Error attempting
      to determine the Java EE module type for
      /private/tmp/s1astempdomain1server-311955579/EJBModule1.jar; the archive may be
      incorrectly constructed, non-existent, or inaccessible from the server

      is much harder to understand.

        Issue Links

          Activity

          Hide
          vince kraemer added a comment -

          here is a jar that demonstrates the issue.

          Show
          vince kraemer added a comment - here is a jar that demonstrates the issue.
          Hide
          Hong Zhang added a comment -

          The test case attached is different than what we have fixed in 819.

          1. In issue 819 case, we know it's a ejb jar (from application.xml declaration
          etc), but it contains zero ejb. So it's invalid packaged ejb jar.

          2. In this new test case you attached, it's just a jar file. We try to
          dertermine the JavaEE module type of this jar (ejb or appclient) and we just
          couldn't dertermine the type after examining the contents of the jar.

          Show
          Hong Zhang added a comment - The test case attached is different than what we have fixed in 819. 1. In issue 819 case, we know it's a ejb jar (from application.xml declaration etc), but it contains zero ejb. So it's invalid packaged ejb jar. 2. In this new test case you attached, it's just a jar file. We try to dertermine the JavaEE module type of this jar (ejb or appclient) and we just couldn't dertermine the type after examining the contents of the jar.
          Hide
          vince kraemer added a comment -

          You are right. The error is not a regression. It is just a bad error message.

          So, the jar file is an app client, without the proper manifest file entry OR an
          ejb jar that has no EJBs right?

          So, the message should probably say something like that...

          Show
          vince kraemer added a comment - You are right. The error is not a regression. It is just a bad error message. So, the jar file is an app client, without the proper manifest file entry OR an ejb jar that has no EJBs right? So, the message should probably say something like that...
          Hide
          Hong Zhang added a comment -

          Ok, will add more hints to the error message.

          Show
          Hong Zhang added a comment - Ok, will add more hints to the error message.
          Hide
          Hong Zhang added a comment -

          Have improved message to be more helpful/diagnostic.

          Show
          Hong Zhang added a comment - Have improved message to be more helpful/diagnostic.

            People

            • Assignee:
              Hong Zhang
              Reporter:
              vince kraemer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: