Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 9.0pe
    • Fix Version/s: not determined
    • Component/s: admin_gui
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      254

      Description

      All the default HTTP page returned (for instance HTTP 403) must be refreshed to
      some clean HTML and XHTML page that will pass the w3c validator.

      Page encoding has to be fixed, using UTF-8 everywhere and under firefox 1.5 b36
      returns '?' instead of any diacritic sign enabled letter like é è à ...

      Choosing XHTML 1.0 Transitional and encoding the page in UTF-8 as well might be
      a good choice for their compatibility "good citizen" known behaviors.

        Activity

        bjb created issue -
        Hide
        jluehe added a comment -

        In an effort to fix:

        http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6412710
        ("Core messages display in garbled if start application server in locale")

        we now set the response locale (and therefore the response encoding) of the
        server's default error page to match the locale of the resource bundle that was
        used to resolve the error codes whose corresponding error messages are included
        in the error page.

        For example, if you start your appserver in the zh_CN.EUC locale:

        env LANG=zh_CN.EUC ./asadmin start-domain --user admin

        and bundle resource files of the form LocalStrings_zh_CN.properties in your
        domain's lib directory, the response encoding of the server's default error page
        will be:

        Content-Type: text/html;charset=GB2312

        Please let me know if you're satisfied with this change, and what other changes
        you'd like to see made to the format of the server's default error page.

        Show
        jluehe added a comment - In an effort to fix: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6412710 ("Core messages display in garbled if start application server in locale") we now set the response locale (and therefore the response encoding) of the server's default error page to match the locale of the resource bundle that was used to resolve the error codes whose corresponding error messages are included in the error page. For example, if you start your appserver in the zh_CN.EUC locale: env LANG=zh_CN.EUC ./asadmin start-domain --user admin and bundle resource files of the form LocalStrings_zh_CN.properties in your domain's lib directory, the response encoding of the server's default error page will be: Content-Type: text/html;charset=GB2312 Please let me know if you're satisfied with this change, and what other changes you'd like to see made to the format of the server's default error page.
        Hide
        bjb added a comment -

        Hi Jan,
        Using environment locale looks a very good step in the right direction.

        Example of clean up in "JSF" template pages of admin_gui to be done :
        + http://localhost:4848/asadmin/admingui/TopFrameset to be put as XHTML 1.0
        Frameset ( http://www.w3.org/TR/xhtml1/dtds.html#a_dtd_XHTML-1.0-Frameset )
        +
        http://localhost:4848/asadmin/admingui/Index?collapseBranch=Collapse+Branch&expandBranch=Expand+Branch&tree.tasks=Common+Tasks&isLH21=false&Index.RightSidePage=

        ( the default tree display), there you got a big m*ss : for instance, two html
        tag level ! XHTML doctype, but then lots of errors with single image tag without
        / at the end, bad entity encoding in URL for ampersand, usage of non-standard
        event, ...

        Actually, most of the pages have lots of page cleaning to comply with w3c
        specification (clening in verious module to be done, then ...).

        To find what has to be done, use w3c validator by pasting the generated admin
        code, it will show you what needs t o be fixed.

        Current templating solution use make page validation very complex .. IMHO,
        moving the "template" of admin to facelet should be anticipated at some point of
        time to provide an easy way of changing the GF GUI without having to dig in
        complex code. Facelet provide an JSF and XML compatible way to define templates
        in an efficient and powerfull way.

        Show
        bjb added a comment - Hi Jan, Using environment locale looks a very good step in the right direction. Example of clean up in "JSF" template pages of admin_gui to be done : + http://localhost:4848/asadmin/admingui/TopFrameset to be put as XHTML 1.0 Frameset ( http://www.w3.org/TR/xhtml1/dtds.html#a_dtd_XHTML-1.0-Frameset ) + http://localhost:4848/asadmin/admingui/Index?collapseBranch=Collapse+Branch&expandBranch=Expand+Branch&tree.tasks=Common+Tasks&isLH21=false&Index.RightSidePage= ( the default tree display), there you got a big m*ss : for instance, two html tag level ! XHTML doctype, but then lots of errors with single image tag without / at the end, bad entity encoding in URL for ampersand, usage of non-standard event, ... Actually, most of the pages have lots of page cleaning to comply with w3c specification (clening in verious module to be done, then ...). To find what has to be done, use w3c validator by pasting the generated admin code, it will show you what needs t o be fixed. Current templating solution use make page validation very complex .. IMHO, moving the "template" of admin to facelet should be anticipated at some point of time to provide an easy way of changing the GF GUI without having to dig in complex code. Facelet provide an JSF and XML compatible way to define templates in an efficient and powerfull way.
        Hide
        jluehe added a comment -

        The web container's default error page now conforms to XHTML 1.0 Strict and
        passes http://validator.w3.org/check without any errors.

        Checking in ErrorReportValve.java;
        /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/valves/ErrorReportValve.java,v
        <-- ErrorReportValve.java
        new revision: 1.18; previous revision: 1.17
        done

        Reassigning this issue to admin_gui so they can take it from here.

        Show
        jluehe added a comment - The web container's default error page now conforms to XHTML 1.0 Strict and passes http://validator.w3.org/check without any errors. Checking in ErrorReportValve.java; /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/valves/ErrorReportValve.java,v <-- ErrorReportValve.java new revision: 1.18; previous revision: 1.17 done Reassigning this issue to admin_gui so they can take it from here.
        Hide
        Anissa Lam added a comment -

        Assign to Ken.

        Show
        Anissa Lam added a comment - Assign to Ken.
        kenaiadmin made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 254 31858
        Hide
        Tom Mueller added a comment -

        Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

        Show
        Tom Mueller added a comment - Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.
        Tom Mueller made changes -
        Fix Version/s not determined [ 11149 ]
        Fix Version/s 9.0pe [ 10971 ]

          People

          • Assignee:
            kenpaulsen
            Reporter:
            bjb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: