glassfish
  1. glassfish
  2. GLASSFISH-327

persistence property names aren't qualified

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.0pe
    • Fix Version/s: 9.0pe
    • Component/s: entity-persistence
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      327

      Description

      There's quite a few property names, hint names, etc. that
      aren't qualified in any way that makes it clear they're specific to the
      implementation. For example, "jdbc.driver" is to be named
      "toplink.jdbc.driver" or something like that. We don't want to
      give the impression that these implementation-specific properties are
      really standard properties that are (or should) be supported by all
      implementations. (If necessary, the implementation could support
      both the old names and the new names for compatibility, while only
      documenting the new names.)

        Issue Links

          Activity

          Hide
          Bill Shannon added a comment -

          Why does issue tracker require a comment when adding myself to the CC list?

          Show
          Bill Shannon added a comment - Why does issue tracker require a comment when adding myself to the CC list?
          Hide
          pkrogh added a comment -

          Please publish list of new names on the glashfish persistence webpage.
          Included in this fix will be new properties that may not yet appear on the web
          page.

          Show
          pkrogh added a comment - Please publish list of new names on the glashfish persistence webpage. Included in this fix will be new properties that may not yet appear on the web page.
          Hide
          marina vatkina added a comment -

          These are non-qualified published names

          referenceClass
          cacheUsage
          refresh
          lockMode
          expression
          call
          cascadeLevel

          jdbc.driver
          jdbc.connection.string
          jdbc.user
          jdbc.password

          no.weaving

          Show
          marina vatkina added a comment - These are non-qualified published names referenceClass cacheUsage refresh lockMode expression call cascadeLevel jdbc.driver jdbc.connection.string jdbc.user jdbc.password no.weaving
          Hide
          marina vatkina added a comment -

          Depend on 402

          Show
          marina vatkina added a comment - Depend on 402
          Hide
          marina vatkina added a comment -

          No strings has been renamed

          Show
          marina vatkina added a comment - No strings has been renamed
          Hide
          pkrogh added a comment -

          referenceClass = toplink.reference-class
          cacheUsage = toplink.cache-usage
          refresh = toplink.refresh
          lockMode = toplink.pessimistic-lock
          expression = toplink.expression
          call = toplink.call
          cascadeLevel = toplink.cascade

          jdbc.driver = toplink.jdbc.driver
          jdbc.connection.string = toplink.jdbc.url
          jdbc.user = toplink.jdbc.user
          jdbc.password = toplink.jdbc.password

          no.weaving = toplink.weaving***

              • Note - this involves changing the functionality of this tag. the weaving
                tag must be set to false to turn off weaving and will default to true.
          Show
          pkrogh added a comment - referenceClass = toplink.reference-class cacheUsage = toplink.cache-usage refresh = toplink.refresh lockMode = toplink.pessimistic-lock expression = toplink.expression call = toplink.call cascadeLevel = toplink.cascade jdbc.driver = toplink.jdbc.driver jdbc.connection.string = toplink.jdbc.url jdbc.user = toplink.jdbc.user jdbc.password = toplink.jdbc.password no.weaving = toplink.weaving*** Note - this involves changing the functionality of this tag. the weaving tag must be set to false to turn off weaving and will default to true.
          Hide
          marina vatkina added a comment -

          Also will be fixing these:
          oracle.toplink.essentials.ejb.cmp3.EntityManagerFactoryProvider

          an these are

          public static final String DDL_GENERATION = "ddl-generation";
          public static final String CREATE_ONLY = "createtables";
          public static final String DROP_AND_CREATE = "dropandcreate";
          public static final String NONE = "none";
          public static final String APP_LOCATION = "application-location";
          public static final String CREATE_JDBC_DDL_FILE = "create-ddl-jdbc-file-name";
          public static final String DROP_JDBC_DDL_FILE = "drop-ddl-jdbc-file-name";

          Show
          marina vatkina added a comment - Also will be fixing these: oracle.toplink.essentials.ejb.cmp3.EntityManagerFactoryProvider an these are public static final String DDL_GENERATION = "ddl-generation"; public static final String CREATE_ONLY = "createtables"; public static final String DROP_AND_CREATE = "dropandcreate"; public static final String NONE = "none"; public static final String APP_LOCATION = "application-location"; public static final String CREATE_JDBC_DDL_FILE = "create-ddl-jdbc-file-name"; public static final String DROP_JDBC_DDL_FILE = "drop-ddl-jdbc-file-name";
          Hide
          marina vatkina added a comment -

          Java2db strings will be changed as follows:

          names:
          ddl-generation -> toplink.ddl-generation
          application-location -> toplink.application-location
          create-ddl-jdbc-file-name -> toplink.create-ddl-jdbc-file-name
          drop-ddl-jdbc-file-name -> toplink.drop-ddl-jdbc-file-name

          values:
          createtables -> create-tables
          dropandcreate -> drop-and-create-tables

          Show
          marina vatkina added a comment - Java2db strings will be changed as follows: names: ddl-generation -> toplink.ddl-generation application-location -> toplink.application-location create-ddl-jdbc-file-name -> toplink.create-ddl-jdbc-file-name drop-ddl-jdbc-file-name -> toplink.drop-ddl-jdbc-file-name values: createtables -> create-tables dropandcreate -> drop-and-create-tables
          Hide
          marina vatkina added a comment -

          Committed the chages:

          Checking in src/java/oracle/toplink/essentials/ejb/cmp3/EJBQuery.java;
          /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EJBQuery.java,v
          <-- EJBQuery.java
          new revision: 1.3; previous revision: 1.2
          done
          Checking in
          src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java;
          /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java,v
          <-- EntityManagerFactoryProvider.java
          new revision: 1.23; previous revision: 1.22
          done
          Checking in
          src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java;
          /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java,v
          <-- EntityManagerSetupImpl.java
          new revision: 1.22; previous revision: 1.21
          done
          Checking in
          src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java;
          /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java,v
          <-- JavaSECMPInitializer.java
          new revision: 1.10; previous revision: 1.9
          done

          Show
          marina vatkina added a comment - Committed the chages: Checking in src/java/oracle/toplink/essentials/ejb/cmp3/EJBQuery.java; /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EJBQuery.java,v <-- EJBQuery.java new revision: 1.3; previous revision: 1.2 done Checking in src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java; /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java,v <-- EntityManagerFactoryProvider.java new revision: 1.23; previous revision: 1.22 done Checking in src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java; /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java,v <-- EntityManagerSetupImpl.java new revision: 1.22; previous revision: 1.21 done Checking in src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java; /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java,v <-- JavaSECMPInitializer.java new revision: 1.10; previous revision: 1.9 done

            People

            • Assignee:
              marina vatkina
              Reporter:
              marina vatkina
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: