glassfish
  1. glassfish
  2. GLASSFISH-3423

Context-specific error messages should name the context

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 9.1peur1
    • Fix Version/s: 9.1pe_dev
    • Component/s: web_container
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      3,423

      Description

      Context-specific error messages should name the context. Some, such as the
      following, do not:

      PWC1306: Context startup failed due to previous errors

        Activity

        Hide
        kmeduri added a comment -

        Now the message shows the context name.

        PWC12Dev_Branch commit log:
        Checking in StandardContext.java;
        /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/StandardContext.java,v
        <-- StandardContext.java
        new revision: 1.22.6.9; previous revision: 1.22.6.8
        done
        Checking in LocalStrings.properties;
        /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/LocalStrings.properties,v
        <-- LocalStrings.properties
        new revision: 1.11.10.4; previous revision: 1.11.10.3
        done

        Show
        kmeduri added a comment - Now the message shows the context name. PWC12Dev_Branch commit log: Checking in StandardContext.java; /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/StandardContext.java,v <-- StandardContext.java new revision: 1.22.6.9; previous revision: 1.22.6.8 done Checking in LocalStrings.properties; /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/LocalStrings.properties,v <-- LocalStrings.properties new revision: 1.11.10.4; previous revision: 1.11.10.3 done
        Hide
        jluehe added a comment -

        Index: StandardContext.java
        ===================================================================
        RCS file:
        /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/StandardContext.java,v
        retrieving revision 1.47
        retrieving revision 1.48
        diff -u -r1.47 -r1.48
        — StandardContext.java 18 Jul 2007 15:31:56 -0000 1.47
        +++ StandardContext.java 25 Jul 2007 00:52:04 -0000 1.48
        @@ -144,7 +144,7 @@
        *

        • @author Craig R. McClanahan
        • @author Remy Maucherat
        • * @version $Revision: 1.47 $ $Date: 2007/07/18 15:31:56 $
          + * @version $Revision: 1.48 $ $Date: 2007/07/25 00:52:04 $
          */

        public class StandardContext
        @@ -5198,7 +5198,7 @@
        log.trace("Starting completed");
        setAvailable(true);
        } else {

        • log.error(sm.getString("standardContext.startFailed"));
          + log.error(sm.getString("standardContext.startFailed", getName()));
          try { stop(); }

          catch (Throwable t) {

        Index: LocalStrings.properties
        ===================================================================
        RCS file:
        /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/LocalStrings.properties,v
        retrieving revision 1.16
        retrieving revision 1.17
        diff -u -r1.16 -r1.17
        — LocalStrings.properties 5 May 2007 05:31:54 -0000 1.16
        +++ LocalStrings.properties 25 Jul 2007 00:52:04 -0000 1.17
        @@ -127,7 +127,7 @@
        standardContext.servletMap.name=PWC1303: Servlet mapping specifies an unknown
        servlet name

        {0}
        standardContext.servletMap.pattern=PWC1304: Invalid <url-pattern> {0}

        in
        servlet mapping
        standardContext.startCleanup=PWC1305: Exception during cleanup after start failed
        -standardContext.startFailed=PWC1306: Context startup failed due to previous errors
        +standardContext.startFailed=PWC1306: Startup of context

        {0} failed due to
        previous errors
        standardContext.startingContext=PWC1307: Error starting context {0}

        standardContext.startingLoader=PWC1308: Exception starting Loader
        standardContext.startingManager=PWC1309: Exception starting Manager

        Show
        jluehe added a comment - Index: StandardContext.java =================================================================== RCS file: /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/StandardContext.java,v retrieving revision 1.47 retrieving revision 1.48 diff -u -r1.47 -r1.48 — StandardContext.java 18 Jul 2007 15:31:56 -0000 1.47 +++ StandardContext.java 25 Jul 2007 00:52:04 -0000 1.48 @@ -144,7 +144,7 @@ * @author Craig R. McClanahan @author Remy Maucherat * @version $Revision: 1.47 $ $Date: 2007/07/18 15:31:56 $ + * @version $Revision: 1.48 $ $Date: 2007/07/25 00:52:04 $ */ public class StandardContext @@ -5198,7 +5198,7 @@ log.trace("Starting completed"); setAvailable(true); } else { log.error(sm.getString("standardContext.startFailed")); + log.error(sm.getString("standardContext.startFailed", getName())); try { stop(); } catch (Throwable t) { Index: LocalStrings.properties =================================================================== RCS file: /cvs/glassfish/appserv-webtier/src/java/org/apache/catalina/core/LocalStrings.properties,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 — LocalStrings.properties 5 May 2007 05:31:54 -0000 1.16 +++ LocalStrings.properties 25 Jul 2007 00:52:04 -0000 1.17 @@ -127,7 +127,7 @@ standardContext.servletMap.name=PWC1303: Servlet mapping specifies an unknown servlet name {0} standardContext.servletMap.pattern=PWC1304: Invalid <url-pattern> {0} in servlet mapping standardContext.startCleanup=PWC1305: Exception during cleanup after start failed -standardContext.startFailed=PWC1306: Context startup failed due to previous errors +standardContext.startFailed=PWC1306: Startup of context {0} failed due to previous errors standardContext.startingContext=PWC1307: Error starting context {0} standardContext.startingLoader=PWC1308: Exception starting Loader standardContext.startingManager=PWC1309: Exception starting Manager

          People

          • Assignee:
            jluehe
            Reporter:
            kmeduri
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: