glassfish
  1. glassfish
  2. GLASSFISH-3625

Report non-portable annotation use in code

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: 9.1pe
    • Fix Version/s: not determined
    • Component/s: verifier
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      3,625

      Description

      Verifier currently does not report about non-portable annotation usage in the
      code. The API scanning facility needs to be improved to scan class data section
      that contains annotations. An example of where current verifier does not report
      a failure is given below:

      @WebService
      public class MyServletEndpoint {
      @javax.ejb.TransactionAttribute(REQUIRES_NEW) // incorrect use
      public void registerUser(String username, String encodedPW)

      { // ... }


      }

      I think, we need to switch to ASM based API scanning implementation to address
      this issue.

      Sahoo

      1. Bug3625.zip
        290 kB
        seemarich
      2. Bug3625.zip
        295 kB
        seemarich

        Activity

        Hide
        Sanjeeb Sahoo added a comment -

        Confirming the issue.

        Show
        Sanjeeb Sahoo added a comment - Confirming the issue.
        Hide
        seemarich added a comment -

        Created an attachment (id=1537)
        New files, old files, patch and a readme

        Show
        seemarich added a comment - Created an attachment (id=1537) New files, old files, patch and a readme
        Hide
        seemarich added a comment -

        Created an attachment (id=1558)
        Updated patch is attached

        Show
        seemarich added a comment - Created an attachment (id=1558) Updated patch is attached
        Hide
        Tom Mueller added a comment -

        Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

        Show
        Tom Mueller added a comment - Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

          People

          • Assignee:
            Sanjeeb Sahoo
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: