glassfish
  1. glassfish
  2. GLASSFISH-3826

Prevent CometHandler to corrupt the Response object if the connection has been resumed

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.1peur1
    • Fix Version/s: 9.1peur1_dev
    • Component/s: web_container
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      3,826

      Description

      Some CometHandler can always invoke, during the same transaction, the
      addCometHandler, and the spawn a Thread and invoke the resumeCometHandler. In
      that situation, the Response object might be invoked twice (once when Grizzly
      resume it, one when the CometHandler does the same things), corrupting the
      response (as the response get the last chunked bytes twice). Fix is easy.

        Activity

        Hide
        basler added a comment -

        Approved for check into the SJSAS91_UR1_BRANCH

        Show
        basler added a comment - Approved for check into the SJSAS91_UR1_BRANCH
        Hide
        basler added a comment -

        Approved wrong bug

        Show
        basler added a comment - Approved wrong bug
        Hide
        jfarcand added a comment -

        Fixed.

        Checking in CometContext.java;
        /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/comet/CometContext.java,v
        <-- CometContext.java
        new revision: 1.29.4.4; previous revision: 1.29.4.3
        done
        Checking in CometEngine.java;
        /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/comet/CometEngine.java,v
        <-- CometEngine.java
        new revision: 1.24.4.4; previous revision: 1.24.4.3
        done
        Checking in CometTask.java;
        /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/comet/CometTask.java,v
        <-- CometTask.java
        new revision: 1.14.4.3; previous revision: 1.14.4.2
        done

        Show
        jfarcand added a comment - Fixed. Checking in CometContext.java; /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/comet/CometContext.java,v <-- CometContext.java new revision: 1.29.4.4; previous revision: 1.29.4.3 done Checking in CometEngine.java; /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/comet/CometEngine.java,v <-- CometEngine.java new revision: 1.24.4.4; previous revision: 1.24.4.3 done Checking in CometTask.java; /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/comet/CometTask.java,v <-- CometTask.java new revision: 1.14.4.3; previous revision: 1.14.4.2 done
        Hide
        jfarcand added a comment -

        One day I will get the target right

        Show
        jfarcand added a comment - One day I will get the target right

          People

          • Assignee:
            jfarcand
            Reporter:
            jfarcand
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: