glassfish
  1. glassfish
  2. GLASSFISH-440

Many DTD's are missing a DOCTYPE hint...

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.0pe
    • Fix Version/s: 9.0pe_dev
    • Component/s: other
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      440

      Description

      If you look in <glassfish>/lib/dtds/application_1_3.dtd, you see...

      This is the XML DTD for the J2EE 1.3 application deployment
      descriptor. All J2EE 1.3 application deployment descriptors
      must include a DOCTYPE of the following form:

      <!DOCTYPE application PUBLIC
      "-//Sun Microsystems, Inc.//DTD J2EE Application 1.3//EN"
      "http://java.sun.com/dtd/application_1_3.dtd">

      This is very useful and complete information for developers.

      If you look at sun-web-app_2_5-0.dtd, you see this:

      The PUBLIC ID (defined in DOCTYPE) associated with this dtd is:
      "-//Sun Microsystems, Inc.//DTD Application Server 9.0 Servlet 2.5//EN"

      This isn't quite as complete. When a user needs to create a sun-web.xml, they
      will need to hunt around to find the SYSTEM ID (the http://.... part) that
      should probably be added to the DOCTYPE declaration that they add to the top of
      their file.

      Of the 44 dtds in <glassfish>/lib/dtd only about 15 have ANY information about
      the DOCTYPE that authors (or tools) should use to identify the content of the
      file....

        Activity

        Hide
        dochez added a comment -

        The DTDs mentioned belongs to the J2EE specs therefore cannot be update without
        doing a maintenance of the specs. I don't think we want to do a maintenance of
        any J2EE 1.3 specs...

        Show
        dochez added a comment - The DTDs mentioned belongs to the J2EE specs therefore cannot be update without doing a maintenance of the specs. I don't think we want to do a maintenance of any J2EE 1.3 specs...
        Hide
        vince kraemer added a comment -

        So there is no commitment to make the 'hint' complete for:

        sun-application-client_5_0.dtd
        sun-application_5_0-0.dtd
        sun-ejb-jar_3_0-0.dtd
        sun-resources_1_2.dtd – doesn't have any hint whatsoever...
        sun-web-app_2_5-0.dtd

        None of these Glassfish dtds have any info about their location/System ID.

        Show
        vince kraemer added a comment - So there is no commitment to make the 'hint' complete for: sun-application-client_5_0.dtd sun-application_5_0-0.dtd sun-ejb-jar_3_0-0.dtd sun-resources_1_2.dtd – doesn't have any hint whatsoever... sun-web-app_2_5-0.dtd None of these Glassfish dtds have any info about their location/System ID.
        Hide
        Hong Zhang added a comment -

        The deployment team will take care of
        sun-application-client_5_0.dtd
        sun-application_5_0-0.dtd
        sun-ejb-jar_3_0-0.dtd
        sun-web-app_2_5-0.dtd

        And admin team will take care of sun-resources_1_2.dtd.

        Show
        Hong Zhang added a comment - The deployment team will take care of sun-application-client_5_0.dtd sun-application_5_0-0.dtd sun-ejb-jar_3_0-0.dtd sun-web-app_2_5-0.dtd And admin team will take care of sun-resources_1_2.dtd.
        Hide
        km105526 added a comment -

        IMO, this is not a defect. A DTD does not have to provide the so called hint
        because it (the hint) is a part of a comment in DTD and is not mandatory.

        Show
        km105526 added a comment - IMO, this is not a defect. A DTD does not have to provide the so called hint because it (the hint) is a part of a comment in DTD and is not mandatory.
        Hide
        Hong Zhang added a comment -

        I have fixed the deployment related dtds:
        sun-application-client_5_0.dtd
        sun-application_5_0-0.dtd
        sun-ejb-jar_3_0-0.dtd
        sun-web-app_2_5-0.dtd

        Transfer the issue to admin team now to fix sun-resources_1_2.dtd.

        Show
        Hong Zhang added a comment - I have fixed the deployment related dtds: sun-application-client_5_0.dtd sun-application_5_0-0.dtd sun-ejb-jar_3_0-0.dtd sun-web-app_2_5-0.dtd Transfer the issue to admin team now to fix sun-resources_1_2.dtd.
        Hide
        km105526 added a comment -

        Sreeni,
        Please add the following to existing comments section in:

        <!--
        A resources instance document referring to this DTD should have a DOCTYPE as
        follows:

        <!DOCTYPE resources PUBLIC "-//Sun Microsystems, Inc.//DTD Application Server
        9.0 Resource Definitions //EN"
        "http://www.sun.com/software/appserver/dtds/sun-resources_1_2.dtd">

        -->

        /glassfish/admin-core/config-api/dtds/sun-resources_1_2.dtd.

        Show
        km105526 added a comment - Sreeni, Please add the following to existing comments section in: <!-- A resources instance document referring to this DTD should have a DOCTYPE as follows: <!DOCTYPE resources PUBLIC "-//Sun Microsystems, Inc.//DTD Application Server 9.0 Resource Definitions //EN" "http://www.sun.com/software/appserver/dtds/sun-resources_1_2.dtd"> --> /glassfish/admin-core/config-api/dtds/sun-resources_1_2.dtd.
        Hide
        msreddy added a comment -

        [sreeni@bnr dtds]$ cvs commit -m "fix for bug# 6401696, GlassFish issue#
        440" sun-resources_1_2.dtd
        Checking in sun-resources_1_2.dtd;
        /cvs/glassfish/admin-core/config-api/dtds/sun-resources_1_2.dtd,v <--
        sun-resources_1_2.dtd
        new revision: 1.6; previous revision: 1.5
        done
        [sreeni@bnr dtds]$

        Show
        msreddy added a comment - [sreeni@bnr dtds] $ cvs commit -m "fix for bug# 6401696, GlassFish issue# 440" sun-resources_1_2.dtd Checking in sun-resources_1_2.dtd; /cvs/glassfish/admin-core/config-api/dtds/sun-resources_1_2.dtd,v <-- sun-resources_1_2.dtd new revision: 1.6; previous revision: 1.5 done [sreeni@bnr dtds] $
        Hide
        kravtch added a comment -

        sun-resources_1_2.dtd is autogenerated from .rng schema files in
        admin-core/config-api, so your changes will disappear next time when new changes
        in domain dtd will be approved.
        I will keep this DOCTYPE there, but in future we need to modify XSLT scripts for
        that.

        Show
        kravtch added a comment - sun-resources_1_2.dtd is autogenerated from .rng schema files in admin-core/config-api, so your changes will disappear next time when new changes in domain dtd will be approved. I will keep this DOCTYPE there, but in future we need to modify XSLT scripts for that.

          People

          • Assignee:
            msreddy
            Reporter:
            vince kraemer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: