glassfish
  1. glassfish
  2. GLASSFISH-5294

HTTP file cache is not enabled if Servlet filters are present

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.1peur2
    • Fix Version/s: 9.1.1_dev
    • Component/s: grizzly-kernel
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      5,294
    • Status Whiteboard:
      Hide

      911Approved

      Show
      911Approved

      Description

      HTTP file caching is bypassed in the presence of filters.

      The following check is evaluated before files are added to the cache.

      Class: com.sun.enterprise.web.connector.grizzly.handlers.NoParsingHandler ==>
      line 118

      if ( cr.getContext().findConstraints().length == 0
      && cr.getContext().findFilterDefs().length == 0 ){
      ...
      fileCache.add(..)
      ...
      }

      Since Filters are often used for a variety of purposes (we use it to put and get
      content from Memcached), this requirement limits the use of HTTP file cache. At
      the moment, it looks like the user will have to choose between either adding a
      filter or enabling file cache. It would be good to provide a way to enable both.

        Activity

        Hide
        jfarcand added a comment -

        Patch ready...pending approval from Harpreet

        Show
        jfarcand added a comment - Patch ready...pending approval from Harpreet
        Hide
        harpreet added a comment -

        Approved for v2.1

        Show
        harpreet added a comment - Approved for v2.1
        Hide
        jfarcand added a comment -

        Fixed

        Checking in
        src/java/com/sun/enterprise/web/connector/grizzly/DefaultProcessorTask.java;
        /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/DefaultProcessorTask.java,v
        <-- DefaultProcessorTask.java
        new revision: 1.16.2.2; previous revision: 1.16.2.1
        done
        Checking in
        src/java/com/sun/enterprise/web/connector/grizzly/handlers/ContentLengthHandler.java;
        /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/handlers/ContentLengthHandler.java,v
        <-- ContentLengthHandler.java
        new revision: 1.13.6.1; previous revision: 1.13
        done
        Checking in
        src/java/com/sun/enterprise/web/connector/grizzly/handlers/NoParsingHandler.java;
        /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/handlers/NoParsingHandler.java,v
        <-- NoParsingHandler.java
        new revision: 1.13.6.1; previous revision: 1.13
        done

        Show
        jfarcand added a comment - Fixed Checking in src/java/com/sun/enterprise/web/connector/grizzly/DefaultProcessorTask.java; /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/DefaultProcessorTask.java,v <-- DefaultProcessorTask.java new revision: 1.16.2.2; previous revision: 1.16.2.1 done Checking in src/java/com/sun/enterprise/web/connector/grizzly/handlers/ContentLengthHandler.java; /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/handlers/ContentLengthHandler.java,v <-- ContentLengthHandler.java new revision: 1.13.6.1; previous revision: 1.13 done Checking in src/java/com/sun/enterprise/web/connector/grizzly/handlers/NoParsingHandler.java; /cvs/glassfish/appserv-http-engine/src/java/com/sun/enterprise/web/connector/grizzly/handlers/NoParsingHandler.java,v <-- NoParsingHandler.java new revision: 1.13.6.1; previous revision: 1.13 done

          People

          • Assignee:
            jfarcand
            Reporter:
            binujohn
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: