glassfish
  1. glassfish
  2. GLASSFISH-5322

method to get the ciphersuites should be changed

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.1peur2
    • Fix Version/s: 9.1.1_dev
    • Component/s: admin_gui
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      5,322
    • Status Whiteboard:
      Hide

      911Approved

      Show
      911Approved

      Description

      GUI calls the method getDefaultCipherSuites to show to user in the SSL tab.
      According to Kumar, We should change to use getSupportedcipherSuites().

      Here is the email from Kumar:

      >> Actually it appears to me that both in V2 and V3 we should have been calling
      factory.getSupportedCipherSuites() instead of
      factory.getDefaultCipherSuites(). Apparently this is causing issues for a
      GlassFish V2 user. See the following thread :

      http://forums.java.net/jive/thread.jspa?messageID=277179

      Also see the Javadoc of those two methods here :
      http://java.sun.com/j2se/1.4.2/docs/api/javax/net/ssl/SSLSocketFactory.html#getSupportedCipherSuites()

      I have asked the user to file an Issue on GF. IMO it should be fixed in V3 and
      V2 as well.

      ============
      The fix is put in to V3 already. Will wait for approval to checkin to the FCS
      branch and BETA branch.

      This is changing for 1 line:

      from:
      SSLServerSocketFactory factory =
      (SSLServerSocketFactory)SSLServerSocketFactory.getDefault();
      String[] supportedCiphers = factory.getDefaultCipherSuites();

      to
      SSLServerSocketFactory factory =
      (SSLServerSocketFactory)SSLServerSocketFactory.getDefault();
      String[] supportedCiphers = factory.getSupprtedCipherSuites();

        Activity

        Hide
        Anissa Lam added a comment -

        change target milestone.

        Show
        Anissa Lam added a comment - change target milestone.
        Hide
        Anissa Lam added a comment -

        Fix checked in on 10/16.

        Show
        Anissa Lam added a comment - Fix checked in on 10/16.

          People

          • Assignee:
            Anissa Lam
            Reporter:
            Anissa Lam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: