glassfish
  1. glassfish
  2. GLASSFISH-6300

Badly designed class called ComponentInvocation

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: V3
    • Fix Version/s: not determined
    • Component/s: other
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      6,300
    • Status Whiteboard:
      Hide

      gfv3-prelude-excluded

      Show
      gfv3-prelude-excluded

      Description

      I am referring to org.glassfish.api.invocation.ComponentInvocation. First of all
      I don't understand why we are making a @Service available as part of
      glassfish-api. Should this not be a @Contract to reduce glassfish-api's
      dependency on other modules? Secondly, it has a lovely enum defined like this:

      public enum ComponentInvocationType

      { SERVLET_INVOCATION, EJB_INVOCATION, APP_CLIENT_INVOCATION, UN_INITIALIZED, SERVICE_STARTUP }

      This seems like a violation of extensibility of GFv3. What if I have an
      invocation context which is not one of the above?

      Given that any publicly visible signature of glassfish-api will be difficult to
      change after prelude, please be more careful while designing them.

        Activity

        Hide
        kumara added a comment -

        v3 defect tracking

        Show
        kumara added a comment - v3 defect tracking
        Hide
        kumara added a comment -

        glassfish-api for prelude release is of "Unstable" classification. A change to
        the class at this stage is risky and this should be taken up after the Prelude
        release.

        Show
        kumara added a comment - glassfish-api for prelude release is of "Unstable" classification. A change to the class at this stage is risky and this should be taken up after the Prelude release.
        Hide
        kumara added a comment -

        Reclassifying as P4 because these issues are not must fix for prelude release.
        This issue will be scrubbed after prelude release and will be given the right
        priority for v3 final release.

        Show
        kumara added a comment - Reclassifying as P4 because these issues are not must fix for prelude release. This issue will be scrubbed after prelude release and will be given the right priority for v3 final release.
        Hide
        Tom Mueller added a comment -

        Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

        Show
        Tom Mueller added a comment - Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

          People

          • Assignee:
            Mahesh Kannan
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: