glassfish
  1. glassfish
  2. GLASSFISH-6611

Unnecessary checked in src/main/resources/META-INF/MANIFEST.MF files

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: V3
    • Fix Version/s: future release
    • Component/s: build_system
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      6,611
    • Status Whiteboard:
      Hide

      gfv3-prelude-excluded

      Show
      gfv3-prelude-excluded

      Description

      All (most?) javax.xxx modules have empty src/main/resources/META-INF/MANIFEST.MF
      checked in into the src tree. Only javax.ejb seems to need it (because 'jar'goal
      doesn't know about a different manifest file created by the felix plugin).

        Activity

        Hide
        Sanjeeb Sahoo added a comment -

        will look into it in future.

        Show
        Sanjeeb Sahoo added a comment - will look into it in future.
        Hide
        marina vatkina added a comment -

        If we want to remove src/main/resources/META-INF/MANIFEST.MF in javax.ejb, the
        following changes in the pom.xml seem to allow it:
        Index: javax.ejb/pom.xml
        ===================================================================
        — javax.ejb/pom.xml (revision 23609)
        +++ javax.ejb/pom.xml (working copy)
        @@ -83,7 +83,7 @@
        plugin in creating manifest file entries for an embedded
        dependencies
        -->

        • <manifestLocation>$ {pom.build.directory}

          </manifestLocation>
          +
          <manifestLocation>$

          {project.build.outputDirectory}</manifestLocation>

          <!-- Maven uses the output directory (target/classes)
          rather than the final bundle, when compiling against
          @@ -104,6 +104,14 @@
          </execution>
          </executions>
          </plugin>
          + <plugin>
          + <artifactId>maven-jar-plugin</artifactId>
          + <configuration>
          + <archive>
          +
          <manifestFile>${project.build.outputDirectory}

          /MANIFEST.MF</manifestFile>
          + </archive>
          + </configuration>
          + </plugin>
          </plugins>
          </build>

        Show
        marina vatkina added a comment - If we want to remove src/main/resources/META-INF/MANIFEST.MF in javax.ejb, the following changes in the pom.xml seem to allow it: Index: javax.ejb/pom.xml =================================================================== — javax.ejb/pom.xml (revision 23609) +++ javax.ejb/pom.xml (working copy) @@ -83,7 +83,7 @@ plugin in creating manifest file entries for an embedded dependencies --> <manifestLocation>$ {pom.build.directory} </manifestLocation> + <manifestLocation>$ {project.build.outputDirectory}</manifestLocation> <!-- Maven uses the output directory (target/classes) rather than the final bundle, when compiling against @@ -104,6 +104,14 @@ </execution> </executions> </plugin> + <plugin> + <artifactId>maven-jar-plugin</artifactId> + <configuration> + <archive> + <manifestFile>${project.build.outputDirectory} /MANIFEST.MF</manifestFile> + </archive> + </configuration> + </plugin> </plugins> </build>
        Hide
        kumara added a comment -

        Reclassifying as P4 because these issues are not must fix for prelude release.
        This issue will be scrubbed after prelude release and will be given the right
        priority for v3 final release.

        Show
        kumara added a comment - Reclassifying as P4 because these issues are not must fix for prelude release. This issue will be scrubbed after prelude release and will be given the right priority for v3 final release.
        Hide
        marina vatkina added a comment -

        Not for prelude

        Show
        marina vatkina added a comment - Not for prelude

          People

          • Assignee:
            janey
            Reporter:
            marina vatkina
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: