glassfish
  1. glassfish
  2. GLASSFISH-8436

Need QL or SQE Tests for start|stop domain

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: V3
    • Fix Version/s: not determined
    • Component/s: sqe-test
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      8,436

      Description

      See #8387

      The regression in that bug was from V2->V3. The bug sat undetected for a year.
      What that bug says is:

      • If the domain is already running then 'asadmin start-domain' should return
        zero (success)
      • If the domain is NOT running then 'asadmin stop-domain' should return zero
        (success).

      Before the fix both of these situations returned in hard errors with non-zero
      getting returned.

      ===============================================================

      A QL test should be added – or some other frequently run automated test to
      detect it if it regresses again.

      I tried to add a QL test but it is very complicated to add a test in there –
      (ant maven TestNG are all firing at the same time and talking to each other) not
      to mention dangerous since so many developers depend on it.

      For the test all you have to do is run asadmin start-domain twice in a row.
      Both times a zero (success) should be returned. Exact same story for stop-domain.

        Activity

        Hide
        Byron Nevins added a comment -

        Defect -> Enhancement

        Show
        Byron Nevins added a comment - Defect -> Enhancement
        Hide
        Byron Nevins added a comment -

        Changed back to defect. Read on...

        -------------------------------------------------------------------

        In the process of filing Issue 8455 I noticed the following Issue.
        Because of 8455 my environment was now in the state where it was impossible to
        ever start the domain again.

        QL tries to start the domain. It prints a message saying it could not be
        started. And then QL gamely presses on anyways! But every successive test is,
        of course, going to fail now.

        The domain not starting is a catastrophic error and QL tests ought to instantly
        come to a screeching halt. Any more tests are just a waste of time, no possible
        good can come from it.

        It is very simple to fix this – just add the "fail-on-error=true" to the
        start-domain ant command.

        Show
        Byron Nevins added a comment - Changed back to defect. Read on... ------------------------------------------------------------------- In the process of filing Issue 8455 I noticed the following Issue. Because of 8455 my environment was now in the state where it was impossible to ever start the domain again. QL tries to start the domain. It prints a message saying it could not be started. And then QL gamely presses on anyways! But every successive test is, of course, going to fail now. The domain not starting is a catastrophic error and QL tests ought to instantly come to a screeching halt. Any more tests are just a waste of time, no possible good can come from it. It is very simple to fix this – just add the "fail-on-error=true" to the start-domain ant command.
        Hide
        Byron Nevins added a comment -

        Changing to P1.

        My domain would not start because I added a nutty jvm option. I forgot about
        it. So in my environment the domain will not start.

        QL knew this IMMEDIATELY. But instead of telling me "domain won't start" and
        stopping, it continues for a half hour wasting time running tests that can't
        possibly pass.

        Finally I get an Ant error message that has nothing whatsoever to do with the
        real error.

        ONE line of code will fix this problem.

        Show
        Byron Nevins added a comment - Changing to P1. My domain would not start because I added a nutty jvm option. I forgot about it. So in my environment the domain will not start. QL knew this IMMEDIATELY. But instead of telling me "domain won't start" and stopping, it continues for a half hour wasting time running tests that can't possibly pass. Finally I get an Ant error message that has nothing whatsoever to do with the real error. ONE line of code will fix this problem.
        Hide
        kumara added a comment -

        Moving to sqe-test as there is no subcomponent for quicklook tests.

        Show
        kumara added a comment - Moving to sqe-test as there is no subcomponent for quicklook tests.
        Hide
        mzh777 added a comment -

        Change the type to Enhancement.

        I changed the adminCLI tests to detect the asadmin return type (0 or 1) since
        then. Tried to call asadmin start/stop domain from the test but it causes QL
        hangs on windows (other platforms are fine). Had email communications with Bill
        and Kedar and didn't find a way to go through. Put the issue in the list of QL
        enhancement.

        Show
        mzh777 added a comment - Change the type to Enhancement. I changed the adminCLI tests to detect the asadmin return type (0 or 1) since then. Tried to call asadmin start/stop domain from the test but it causes QL hangs on windows (other platforms are fine). Had email communications with Bill and Kedar and didn't find a way to go through. Put the issue in the list of QL enhancement.
        Hide
        Tom Mueller added a comment -

        Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

        Show
        Tom Mueller added a comment - Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

          People

          • Assignee:
            mzh777
            Reporter:
            Byron Nevins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: